Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGS-6457] Don't check file system when host has protocol/scheme. #466

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

EarthlingDavey
Copy link
Contributor

Fixes #442

pwtyler and others added 23 commits May 15, 2023 10:00
…heon-systems#360)

* fix: Fixes assumption that CACHE_PORT & CACHE_PASSWORD are Set.

* Fixes pantheon-systems#359
* Falls back on port 6379 if the CACHE_PORT is not configured.
* Doesn't require a CACHE_PASSWORD to be set when it isn't used, or can't be.
* Improves code quality by reducing Redis default port & databasei duplicate values to a share variables.
* Fixes invalid code changes made in PR [pantheon-systems#400 ](pantheon-systems#400) to the core plugin connectivity testing that prevent connectivty checks if the port/password/database aren't explicitly defined.

* update changelog

---------

Co-authored-by: Chris Reynolds <chris@jazzsequence.com>
Co-authored-by: Ryan Wagner <ryan.wagner@pantheon.io>
* Updates behat tests and behaviors.

* Updates behat tests and behaviors.

* port diff from pantheon-systems#426

* tabs to spaces

* don't enable redis as part of the prepare step
we end up making a dozen differnet enable redis requests and inevitably a lot of those fail because there are so many happening simultaneously (assumption). It's okay to just enable it and leave it on, rather than turning it on and off.

---------

Co-authored-by: Ryan Wagner <ryan.wagner@pantheon.io>
Co-authored-by: Chris Reynolds <chris@jazzsequence.com>
* re-add missing else

* use the already-defined value of $port instead of hard-coding

* remove ternary in favor of elseif
* add wporg validator action

* fix wporg validation steps

* ignore unescaped echo

* separate multiple rules with comma

* ignore unescaped exit output

* update changelog
…er issues (pantheon-systems#434)

* fix: Fixes incorrect order of array_replace_recursive arguments & other issues

* Fixes pantheon-systems#433
* Fixes pantheon-systems#432
* Fixes pantheon-systems#431
* Further clean-up & standardization between object-cache.php & wp-redis.php.
* Fixes incorrect order of array_replace_recursive arguments.
* Addresses issue with port still not being null for socket connections due to defaults array_repalce_recursive use.

* fix: Fixes sanitization methods and linting issues

* Adjusts some items to use type-based sanitization.
* Adds linting expection handling with comments for cases that require it.

* fix: Removes invalid change made in pantheon-systems#437

* Reverts this incorrect change that was made due to the incorrect use of `array_replace_recursive()`.

* update  changelog

* Update wp-redis.php

* update language in changelogs

* fix missing closing )

---------

Co-authored-by: Chris Reynolds <chris@jazzsequence.com>
Co-authored-by: Phil Tyler <philip@tylerdigital.com>
* Bump behat/behat from 3.13.0 to 3.14.0

Bumps [behat/behat](https://github.com/Behat/Behat) from 3.13.0 to 3.14.0.
- [Release notes](https://github.com/Behat/Behat/releases)
- [Changelog](https://github.com/Behat/Behat/blob/master/CHANGELOG.md)
- [Commits](Behat/Behat@v3.13.0...v3.14.0)

---
updated-dependencies:
- dependency-name: behat/behat
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Upgrade yoast/phpunit-polyfills to 1.1.0

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Phil Tyler <phil.tyler@pantheon.io>
Bumps [pantheon-systems/pantheon-wp-coding-standards](https://github.com/pantheon-systems/Pantheon-WP-Coding-Standards) from 1.0.1 to 2.0.1.
- [Release notes](https://github.com/pantheon-systems/Pantheon-WP-Coding-Standards/releases)
- [Commits](pantheon-systems/Pantheon-WP-Coding-Standards@1.0.1...2.0.1)

---
updated-dependencies:
- dependency-name: pantheon-systems/pantheon-wp-coding-standards
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Default was left behind from a previous implementation.
Bumps [yoast/phpunit-polyfills](https://github.com/Yoast/PHPUnit-Polyfills) from 1.1.0 to 2.0.0.
- [Release notes](https://github.com/Yoast/PHPUnit-Polyfills/releases)
- [Changelog](https://github.com/Yoast/PHPUnit-Polyfills/blob/2.x/CHANGELOG.md)
- [Commits](Yoast/PHPUnit-Polyfills@1.1.0...2.0.0)

---
updated-dependencies:
- dependency-name: yoast/phpunit-polyfills
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…stems#457)

* Bump pantheon-systems/wpunit-helpers from 1.0.1 to 2.0.0

Bumps [pantheon-systems/wpunit-helpers](https://github.com/pantheon-systems/wpunit-helpers) from 1.0.1 to 2.0.0.
- [Release notes](https://github.com/pantheon-systems/wpunit-helpers/releases)
- [Commits](pantheon-systems/wpunit-helpers@v1.0.1...v2.0.0)

---
updated-dependencies:
- dependency-name: pantheon-systems/wpunit-helpers
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Tests require WP-CLI

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Phil Tyler <phil.tyler@pantheon.io>
Bumps [yoast/phpunit-polyfills](https://github.com/Yoast/PHPUnit-Polyfills) from 2.0.0 to 2.0.1.
- [Release notes](https://github.com/Yoast/PHPUnit-Polyfills/releases)
- [Changelog](https://github.com/Yoast/PHPUnit-Polyfills/blob/2.x/CHANGELOG.md)
- [Commits](Yoast/PHPUnit-Polyfills@2.0.0...2.0.1)

---
updated-dependencies:
- dependency-name: yoast/phpunit-polyfills
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
pantheon-systems#460)

* Bump pantheon-systems/pantheon-wp-coding-standards from 2.0.1 to 2.0.3

Bumps [pantheon-systems/pantheon-wp-coding-standards](https://github.com/pantheon-systems/Pantheon-WP-Coding-Standards) from 2.0.1 to 2.0.3.
- [Release notes](https://github.com/pantheon-systems/Pantheon-WP-Coding-Standards/releases)
- [Commits](pantheon-systems/Pantheon-WP-Coding-Standards@2.0.1...2.0.3)

---
updated-dependencies:
- dependency-name: pantheon-systems/pantheon-wp-coding-standards
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* parentheses around different binary boolean

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Chris Reynolds <chris@jazzsequence.com>
@EarthlingDavey EarthlingDavey requested a review from a team as a code owner September 20, 2024 08:21
@EarthlingDavey EarthlingDavey changed the title Don't check file system when host has protocol/scheme. Fixes #442 [BUGS-6457] Don't check file system when host has protocol/scheme. Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUGS-6457] Warning when using tls protocol
8 participants