chore: update live tag in menu #11143
Conversation
chef-ryan
requested review from
ChefMomota,
Chef-Yogi,
chefjackson,
ChefJerry,
thechefpenguin and
chef-eric
as code owners
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
There was a problem hiding this comment.
@chef-ryan https://github.com/pancakeswap/pancake-frontend/blob/develop/apps/web/src/components/Menu/hooks/useIfoStatus.ts will automatically put it to live
only 30min left for this ifo start. |
eigenpie ifo needs to be marked isactive false ( since it is finished) to fetch the latest active ifo #11144 so there will be no need for extra deployments for menu status |
menu module only has a dependency to web/hooks (not directly to ifo) which has dependency to ifo module (which is ok imo) |
qstns:
my answer is simply: no. |
| @@ -200,7 +200,7 @@ const config: ( | |||
| label: t('IFO'), | |||
| href: '/ifo', | |||
| image: '/images/ifos/ifo-bunny.png', | |||
| status: { text: t('SOON'), color: 'warning' }, | |||
| status: { text: t('NEW'), color: 'success' }, | |||
There was a problem hiding this comment.
this should be removed (it will be fetched via hook) in order to remove the tag automatically when ifo is finished
There was a problem hiding this comment.
We should add a new tag, it's requirement.
There was a problem hiding this comment.
yes, it will be added by a hook automatically useIfoStatus
PR-Codex overview
This PR updates the status of an item in the
Menucomponent and modifies localization translations.Detailed summary
apps/web/src/components/Menu/config/config.ts, changed thestatustext fromSOONtoNEWwith a corresponding color change fromwarningtosuccess.packages/localization/src/config/translations.json, added a new translation forNEWand removed theSOONentry.