Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove ifo status and solv banner #11145

Merged
merged 7 commits into from
Jan 18, 2025

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Jan 16, 2025


PR-Codex overview

This PR focuses on updating the IFO (Initial Farm Offering) advertisement components and their configurations, enhancing their rendering logic based on active IFO configurations and improving the associated translation and display mechanics.

Detailed summary

  • Removed Basic IFO and NEW translations from translations.json.
  • Renamed AdListaPie component to AdIfo.
  • Implemented useShouldRenderAdIfo hook to determine if the IFO ad should render.
  • Updated useActiveIfoConfigAcrossChains to use orderBy instead of sortBy.
  • Modified AdIfo to use the active IFO configuration for rendering.
  • Adjusted ad configuration to include the new AdIfo component and its rendering conditions.
  • Removed unused EigenpieIFOBanner logic from the banner configuration.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 0:26am
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 0:26am
blog ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 0:26am
bridge ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 0:26am
games ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 0:26am
gamification ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 0:26am
uikit ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 0:26am
ton ⬜️ Skipped (Inspect) Jan 17, 2025 0:26am

Copy link

changeset-bot bot commented Jan 16, 2025

⚠️ No Changeset found

Latest commit: 796ad2d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@memoyil
Copy link
Collaborator Author

memoyil commented Jan 16, 2025

@chef-ryan this can be removed, to not show soon tag initially

Copy link
Contributor

@chef-ryan chef-ryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#11143

check this ,

@memoyil
Copy link
Collaborator Author

memoyil commented Jan 16, 2025

#11143

check this ,

added a comment #11143 (comment)

chef-ryan
chef-ryan previously approved these changes Jan 17, 2025
@memoyil memoyil force-pushed the feature/chore_remove_ifo_status branch from a03db2f to 57661b8 Compare January 17, 2025 12:16
@vercel vercel bot temporarily deployed to Preview – ton January 17, 2025 12:17 Inactive
@vercel vercel bot temporarily deployed to Preview – ton January 17, 2025 12:17 Inactive
@memoyil memoyil requested a review from chef-ryan January 17, 2025 12:18
@chef-ryan chef-ryan merged commit bddd49b into develop Jan 18, 2025
20 checks passed
@chef-ryan chef-ryan deleted the feature/chore_remove_ifo_status branch January 18, 2025 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants