-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release #5 #4466
Merged
Release #5 #4466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adding some docs * Update src/field/pokemon.ts Co-authored-by: NightKev <[email protected]> * seems like battleStats changed to statStages * Apply suggestions from code review editing doc text Co-authored-by: flx-sta <[email protected]> * Update tsdocs, convert comment to tsdoc in `pokemon.ts` --------- Co-authored-by: NightKev <[email protected]> Co-authored-by: flx-sta <[email protected]>
#4067) * fix scrappy + etc. update inverse battle test code * update test code following request from swain
- remove any `.js` extension imports - remove unncessary dynamic imports of `modifier.ts` file. The file was being imported statically & dynamically. Made it pure static - increase vite chunk-size warning limit Co-authored-by: Mumble <[email protected]>
…, abilities triggers, error messages and some misc ajustements) (#4068) * Update battle.json * Update battler-tags.json * Update battle.json * Update battle.json * Update battler-tags.json * Update battle.json * Update battler-tags.json * Update battler-tags.json * Update battle.json * Update battle.json * Update battler-tags.json * Update battler-tags.json * Update battle.json * Update battle.json * Update battler-tags.json * Update battler-tags.json * Update battle.json * Update battle.json * Update battler-tags.json * Update battle.json * Update battle.json * Update battle.json * Update battler-tags.json * Update battle.json * Update battle.json * Update src/locales/de/battle.json Co-authored-by: Jannik Tappert <[email protected]> * Update src/locales/de/battler-tags.json Co-authored-by: Jannik Tappert <[email protected]> * Update battler-tags.json * Update src/locales/ko/battle.json Co-authored-by: sodam <[email protected]> * Update src/locales/ko/battler-tags.json Co-authored-by: sodam <[email protected]> * Update src/locales/it/battle.json Co-authored-by: Niccolò <[email protected]> * Update src/locales/it/battler-tags.json Co-authored-by: Niccolò <[email protected]> * Update menu.json * Update ability-trigger.json * Update ability-trigger.json * Update ability-trigger.json * Update ability-trigger.json * Update ability-trigger.json * Update ability-trigger.json * Update ability-trigger.json * Update ability-trigger.json * Update menu.json * Update menu.json * Update menu.json * Update menu.json * Update menu.json * Update menu.json * Update menu.json * Update menu.json * Update src/locales/de/ability-trigger.json Co-authored-by: Jannik Tappert <[email protected]> * Update src/locales/de/ability-trigger.json Co-authored-by: Jannik Tappert <[email protected]> * Update src/locales/de/menu.json Co-authored-by: Jannik Tappert <[email protected]> * Update src/locales/ko/ability-trigger.json Co-authored-by: Leo Kim <[email protected]> * Update src/locales/ko/menu.json Co-authored-by: Leo Kim <[email protected]> * Update src/locales/ko/ability-trigger.json Co-authored-by: Leo Kim <[email protected]> * Update src/locales/ko/menu.json Co-authored-by: Leo Kim <[email protected]> * Update menu.json * Update ability-trigger.json * Update ability-trigger.json * Update ability-trigger.json * Update ability-trigger.json * Update ability-trigger.json * Update ability-trigger.json * Update menu.json * Update ability-trigger.json * Update battle.json * Update battler-tags.json * Update src/locales/zh_CN/battle.json Co-authored-by: Yonmaru40 <[email protected]> * Update src/locales/zh_TW/battle.json Co-authored-by: Yonmaru40 <[email protected]> * Update modifier-type.json * Update modifier-type.json * Update modifier-type.json * Update modifier-type.json * Update modifier-type.json * Update modifier-type.json * Update modifier-type.json * Update modifier-type.json * Update modifier-type.json * Update modifier-type.json * Update modifier-type.json * Update menu.json * Update battler-tags.json * Update battle.json * Update ability-trigger.json * Update battler-tags.json * Update battler-tags.json * Update battler-tags.json * Update battler-tags.json * Update modifier-type.json * Update menu.json * Update battle.json * Update tutorial.json * Update tutorial.json * Update egg.json * Update battle.json * Update battle.json * Update tutorial.json * Update egg.json * Update modifier-type.json * Update modifier-type.json * Update modifier-type.json * Update modifier-type.json * Update modifier-type.json * Update challenges.json * Update src/locales/ko/modifier-type.json Co-authored-by: Enoch <[email protected]> * Update src/locales/ko/modifier-type.json Co-authored-by: Enoch <[email protected]> * Update src/locales/ja/battle.json Co-authored-by: Chapybara-jp <[email protected]> * Update src/locales/ja/menu.json Co-authored-by: Chapybara-jp <[email protected]> * Update src/locales/ja/modifier-type.json Co-authored-by: Chapybara-jp <[email protected]> * Update src/locales/ja/modifier-type.json Co-authored-by: Chapybara-jp <[email protected]> * Update src/locales/ja/modifier-type.json Co-authored-by: Chapybara-jp <[email protected]> * Update dialogue.json * Update dialogue-misc.json * Update dialogue-final-boss.json * Update dialogue-double-battle.json * Update ability-trigger.json * Update achv.json * Update arena-tag.json * Update battle.json * Update battler-tags.json * Update command-ui-handler.json * Update menu.json * Update modifier-type.json * Update modifier.json * Update move-trigger.json * Update pokemon-info-container.json * Update pokemon-info.json * Update splash-messages.json * Update status-effect.json * Update tutorial.json * Update voucher.json * Update weather.json * Update ability-trigger.json * Update src/locales/de/modifier-type.json Co-authored-by: Jannik Tappert <[email protected]> * Update src/locales/de/modifier-type.json Co-authored-by: Jannik Tappert <[email protected]> * Update modifier-type.json * Update bgm-name.json * Update bgm-name.json * Update src/locales/it/menu.json Co-authored-by: Niccolò <[email protected]> * types_ja.png update * Apply suggestions from code review Co-authored-by: Yonmaru40 <[email protected]> --------- Co-authored-by: Jannik Tappert <[email protected]> Co-authored-by: sodam <[email protected]> Co-authored-by: Niccolò <[email protected]> Co-authored-by: Leo Kim <[email protected]> Co-authored-by: Yonmaru40 <[email protected]> Co-authored-by: Enoch <[email protected]> Co-authored-by: Chapybara-jp <[email protected]>
…ching with your only pokemon that was not fainted (#4025) * fix #762 by using slotIndex to add to party for now the new pokemon was ALWAYS just pushed to the party array. Now it's put into the slot that was also previously selected as the mon to release * add docs for `Pokemon.addToParty()` * add simple tests for addToParty * update `isBetween` docs. Remove `.js` imports
* Learn Move Phase rewrite * Typedocs * messages with confirm do not need an extra button press no more * Added Documentation * This does not work * so sad * Some updates * Eslint issues + clean up * Additions to handle learning during evolution + test fixes * some more checks * Update src/overrides.ts Co-authored-by: NightKev <[email protected]> * Update src/test/phases/learn-move-phase.test.ts Co-authored-by: NightKev <[email protected]> * Added new function and updated tests * Fixed bracketing and added parameter types * Added Sketch to the conditional * Added some fixes. Weird stuff going on. * Whoops * async implementation done * Update src/phases/learn-move-phase.ts Co-authored-by: NightKev <[email protected]> * Apply suggestions from code review Co-authored-by: NightKev <[email protected]> * Made showText=> summary a promise * adapt learn-move-phase to `async-await` * await add --------- Co-authored-by: frutescens <info@laptop> Co-authored-by: NightKev <[email protected]> Co-authored-by: flx-sta <[email protected]>
…d Ice Face bug (#4129) * Update ability-trigger.json * Update ability.json * Update arena-flyout.json * Update arena-tag.json * Update battle.json * Update fight-ui-handler.json * Update berry.json * Update menu.json * Update party-ui-handler.json * Update starter-select-ui-handler.json * Update tutorial.json * Update move.json * Update battle.json * Update arena-flyout.json * Update arena-flyout.json * Update arena-tag.json * Update party-ui-handler.json * Update settings.json
* fully implement throat chop * add linkcode in docs * address comments * update test
* Delete public/images/ui/legacy/summary_moves_effect_de.png * Delete public/images/ui/legacy/summary_moves_effect_es.png * Delete public/images/ui/legacy/summary_moves_effect_fr.png * Delete public/images/ui/legacy/summary_moves_effect_it.png * Delete public/images/ui/legacy/summary_moves_effect_pt-BR.png * Delete public/images/ui/legacy/summary_moves_effect_zh-CN.png
* fully implement power shift * cleanup
…4062) * Make `OPP_MOVESET_OVERRIDE` fully override the enemy's moveset * Update tests with new override behavior * Fix tests * Fix another test * Move overrides no longer required to be arrays * Remove `SPLASH_ONLY` test utility variable * Update moveset override helper functions * Missed some tests
…damage (#3492) * Fixed Delta Stream remaining active when last mon dies to indirect damage * Rebasing changes * Linting fix * Combined if statements * Changed params to optional * Added unit test * Apply suggestions from code review * Fix test and remove `.js` from import --------- Co-authored-by: NightKev <[email protected]>
…plate script (#4072) * add imports, handle kebab-case fileName argument * fix spacing
…ect screen (#4023) * Add ability and passive tooltips to starter select screen * Remove explicit casts to BattleScene * Increase tooltip size, reverse y when necessary, and always show passive tooltip * Add ability name to tooltip title and persist tooltips between Pokemon * Use vi function mocks
* fully implement gorilla tactics * fix atk increase * update oversight * add showAbility param * fix postmerge * fix postmerge * update tests
* Complete after you implementation (no localization) * reset override changes * Remove hardcoded English text, add tests * Fix test * Make sure phases occur in the correct order * fix after-you issues - fix i18n interpolation ot state "target name" and not "pokemon name" as the target takes the offer, not the user - fix some tsdocs - add override to apply - update scene.findPhase to be able to use generic types. Add tsdocs * add move-trigger.afterYou for DE * fix after_you.test.ts --------- Co-authored-by: NightKev <[email protected]> Co-authored-by: flx-sta <[email protected]>
* Make "CH-CHING!" sound when unlocking passive * Remove unused parameters in line above sound
Chapybara-jp
previously approved these changes
Sep 27, 2024
Tempo-anon
previously approved these changes
Sep 27, 2024
returntoice
previously approved these changes
Sep 27, 2024
* Update modifier-type.json * Update modifier-type.json * Update modifier-type.json * Update modifier-type.json * Update modifier-type.json * Update modifier-type.json * Update modifier-type.json * Update modifier-type.json * Update modifier-type.json * Update modifier-type.json * Update modifier-type.json * Update modifier-type.json * Update modifier-type.json * Update modifier-type.json * Update modifier-type.json * Update modifier-type.json * Update src/locales/ko/modifier-type.json * Update src/locales/ko/modifier-type.json * Update modifier-type.json * Update src/locales/it/modifier-type.json * Update src/locales/it/modifier-type.json * Update src/locales/ko/modifier-type.json * Update modifier-type.json * Update src/locales/es/modifier-type.json * Update src/locales/ja/modifier-type.json * Update src/locales/ko/modifier-type.json Co-authored-by: returntoice <[email protected]> * Update modifier-type.json * Update modifier-type.json * Update modifier-type.json * Update modifier-type.json * Update modifier-type.json * Update modifier-type.json * Update modifier-type.json * Update battler-tags.json * Update modifier-type.json * Update battler-tags.json * Update battler-tags.json --------- Co-authored-by: Jannik Tappert <[email protected]> Co-authored-by: returntoice <[email protected]>
Tempo-anon
dismissed stale reviews from returntoice, Chapybara-jp, and themself
via
September 27, 2024 20:56
d28c77d
* Fix Gimmighoul evolution * Fix counter * Less janky maxStack check --------- Co-authored-by: flx-sta <[email protected]>
Tempo-anon
previously approved these changes
Sep 27, 2024
CodeTappert
previously approved these changes
Sep 27, 2024
CodeTappert
dismissed stale reviews from Tempo-anon and themself
via
September 27, 2024 21:35
4364ab3
CodeTappert
approved these changes
Sep 27, 2024
Tempo-anon
approved these changes
Sep 27, 2024
damocleas
approved these changes
Sep 27, 2024
DayKev
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Game Balance
Changes focused on game balance
Game Design
Completely new features and/or mechanics
Lead Dev Review
Lead Dev Review is required
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release No. 5
2024/9/27 The Mystery Encounter Update
Major Changes
Minor Changes
Implementations/Fixes
Moves
Abilities
Items
QOL
Other Bug Fixes