[Bug] Refactor moves that call a random move (Metronome, Assist, Sleep Talk, Copycat, Mirror Move)

[schmidtc1]

Rebranch of #3075

TODO

• Prevent allies being targets of Metronome/Copycat/other random move targetting
  • Verify that self-status/Aromatic Mist still can target allies
• Fix issue of two-turn moves with Metronome/multi-hit moves only hitting once with Sleep Talk
  • Test refactor for removing QueuedMove in favor of TurnMove (see 714211d)
• Refactor Copycat/Mirror Move. (potentially make a CallMoveAttr, have all other attributes extend off of this one)
• Refactor Promises into async/await pattern
• Write unit tests for
  • Metronome
  • Assist
  • Sleep Talk
  • Copycat
  • Mirror Move

What are the changes?

Properly implements Assist.
Refactors RandomMovesetMoveAttr to extend RandomMoveAttr.
Creates arrays of invalid moves for each move: Assist, Sleep Talk, Metronome, since they each have different sets of uncallable moves.

Why am I doing these changes?

Assist did not call ally moves, had useless code, and was given no distinction in logic from Sleep Talk.
Metronome calls random moves in a similar manner to the two other moves, so it makes sense to have Assist/Sleep Talk reuse the code for calling moves.
None of Assist/Sleep Talk/Metronome had properly implemented lists of uncallable moves.

What did change?

• Assist now uses the entire team's party
• Assist/Sleep Talk's attribute now extends RandomMoveAttr and uses its callMoves function (which has been modified slightly to accommodate this) to call the move
• Sleep Talk targeting is changed to NEAR_ENEMY
• Copycat's last move used is now unaffected by moves that fail, see Copycat's bulbapedia
• Mirror Move can now properly copy status moves
• Mirror Move now targets a pokemon and copies that pokemon's last used move
• Assist/Sleep Talk/Metronome/Copycat now have individual arrays listing uncallable moves. These arrays were created referencing Bulbapedia's list of uncallable moves.
• Uncallable moves for Assist
• Uncallable moves for Sleep Talk
• Uncallable moves for Metronome
• Uncallable moves for Copycat

Note: Sleep Talk specifies that it targets the opposite opponent. Since there is no MoveTarget specifically for opposite opponents, I chose to make it NEAR_ENEMY for now.

Screenshots/Videos

Metronome

Metronome.mp4

Assist

Assist.mp4

Sleep Talk

Sleep.Talk.mp4

How to test the changes?

Use src/overrides.ts to give yourself one of the three moves. If using Metronome, observe it will never call certain moves. If using Assist, observe it calling your party pokemon's moves. If using Sleep Talk, observe it only calling its own moveset.
Note that each move will no longer call certain moves: attempt Assist/Sleep Talk with 2 turn moves to see them fail.
List of moves that won't be callable are given above by links to bulbapedia.

Checklist

• I'm using beta as my base branch
• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I considered writing automated tests for the issue?
• Have I tested the changes (manually)?
  • Are all unit tests still passing? (npm run test)
• Are the changes visual?
  • Have I provided screenshots/videos of the changes?

[frutescens]

Do you think it would be helpful to have tests for these moves?

[schmidtc1]

Do you think it would be helpful to have tests for these moves?

The only thing I could think to test is that they are not choosing invalid moves. Do you think this is necessary/have any edge cases to test for?

[Snailman11]

Hello, might be too late + disregard for the process, but could you consider adding this as part of your fix?
#3874 (Metronome and Copycat targeting allies)

[schmidtc1]

Hello, might be too late + disregard for the process, but could you consider adding this as part of your fix? #3874 (Metronome and Copycat targeting allies)

I'll attempt a fix.

[flx-sta]

@schmidtc1 please make sure to resolve your merge conflicts