[Refactor] Code readability update #3085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code provided by DerTapp on Discord
CodeTappert
approved these changes
Jul 21, 2024
mcmontag
reviewed
Jul 21, 2024
|
If you are refactoring code, please write automated tests for the refactored section to make sure that you didn’t change any expected results |
flx-sta
requested changes
Jul 22, 2024
flx-sta
approved these changes
Jul 23, 2024
CodeTappert
approved these changes
Jul 23, 2024
Vassiat
pushed a commit
to Vassiat/pokerogue
that referenced
this pull request
Jul 26, 2024
* Clean up/clarify `src/field/pokemon.ts` a bit Code provided by DerTapp on Discord * Update `PokemonSpeciesForm.getAbilityCount()` * Update `PokemonSpeciesForm.getAbility()` * Add explicit `Abilities.NONE` checks * Add tests * Add jsdoc and implement test suggestions
f-fsantos
added a commit
that referenced
this pull request
Jul 27, 2024
* feat: Add Google and Discord login functionality feat: Add link to Discord in menu UI feat: Add Discord and Google login functionality Add container around discord and google icons refactor: Update environment variable names for Discord and Google client IDs feat: Add "Or use" translation for login options in multiple languages feat: Update menu UI translations for multiple languages Code review fixes refactor: Update Discord and Google client IDs in environment variables * refactor: Add missing properties to initLoggedInUser function * Update src/locales/de/menu-ui-handler.ts Co-authored-by: Jannik Tappert <[email protected]> * make i18n debugging an optional env setting this also reduces output noise in tests * set development default also to "0" * fix inaccurate docs for TypeImmunityAbAttr (#2957) * chore: Add beta branch to GitHub Actions tests workflow * chore: Add beta branch to GitHub Actions linter and gh-pages workflow * Update src/locales/ko/menu-ui-handler.ts Co-authored-by: lnuvy <[email protected]> * Update src/locales/ko/menu.ts Co-authored-by: lnuvy <[email protected]> * Localization(pt): translated bgm-name.ts (#2955) * Localization(pt): translated bgm-name.ts * fix * update VITE_I18N_DEBUG in .env files * chore: Update environment variables for beta and production environments * chore: Add beta branch to GitHub Actions deploy workflow * Hardcoded Pokemon should have proper names (#2941) * Refactor challenges and add fresh start (#2963) * [Balance] Update many TM learnsets (#2879) * Update TMs for more Indigo Disk changes * Fix typo, more Stored Power * Refactor challenges and add fresh start (#2964) * Refactor challenges and add fresh start * Add achievement for fresh start challenge * [Bug] Fix off-by-one error in damage calc (#2970) * Fix random damage roll to be 85-100% instead of 85-99% * Update battle.test.ts to reflect the fix * [Bug] Grounded on Terrain fixes (#2969) * [Help] [Move/Bug] Patches Psychic Terrain applicability edge cases Was cancelling moves even if targeted mons weren't on the terrain. * [Bug `]Pokemon.isGrounded` does not exist Replaced with `Pokemon.isGrounded()`, which does. * [Bug] Psychic Terrain priority move cancel ignoring ungrounded * [Bug] Semi-invulnerable should not be grounded * Update game-stats-ui-handler.ts (italian) (#2965) * [Bugfix] Fix a bug during bgm-bar initialization (#2822) * Prevent sizing error * Make reboot not necessary for show BGM * Makes the BGM Bar active by default + It had originally been decided that this would not be active by default because it was to be displayed outside the pause menu, but since its behavior has changed between this decision and its integration, the default deactivation is no longer necessary * [Mirror][Localization] Translate game victory sentences #2254 (#2906) * Translate forgotten sentences on phases * Translate to de forgotten sentences on phases * Translate to es forgotten sentences on phases * Translate to fr forgotten sentences on phases * Translate to it forgotten sentences on phases * Translate to ko forgotten sentences on phases * Translate to pt br forgotten sentences on phases * Translate to zh cn forgotten sentences on phases * Translate to zh tw forgotten sentences on phases * remove duplicate message * remove duplicate message * Update src/locales/pt_BR/battle.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/de/battle.ts Co-authored-by: Jannik Tappert <[email protected]> * Update src/locales/de/battle.ts Co-authored-by: Jannik Tappert <[email protected]> * Update battle.ts [Localization(it)] * Update src/locales/zh_CN/battle.ts Co-authored-by: Yonmaru40 <[email protected]> --------- Co-authored-by: Alexis <[email protected]> Co-authored-by: 송지원 <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: Jannik Tappert <[email protected]> Co-authored-by: Niccolò <[email protected]> Co-authored-by: Yonmaru40 <[email protected]> * [Mirror][Localization] Translate summary #2336 (#2907) * Translate pokemon summary * Translate pokemon summary to fr * Translate pokemon summary to de * Translate pokemon summary to es * Translate pokemon summary to it * Translate pokemon summary to ko * Translate pokemon summary to pt br * Translate pokemon summary to zh cn * Translate pokemon summary to zh tw * Fix import * Update partially for en and ko * Update interface name for en * Merge trainerLabel&Text and calculate typeLabel width * Update src/locales/es/pokemon-summary.ts Co-authored-by: GoldTra <[email protected]> * Apply translations key to all languages with interface TranslationEtries * Update ko/translationKey of status * Update ko/translationKey of pokemonInfo * Update de/translationKeys of memostring and metFragment * Update de/translationKeys of memostring and metFragment 2 * Update src/locales/ko/pokemon-summary.ts Co-authored-by: Enoch <[email protected]> * Update src/locales/ko/pokemon-summary.ts Co-authored-by: returntoice <[email protected]> * Update src/locales/pt_BR/pokemon-summary.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/ko/pokemon-summary.ts * Update src/locales/pt_BR/pokemon-summary.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update pokemon-summary.ts [Localization(it)] * remove unused code * Update src/locales/zh_CN/pokemon-summary.ts Co-authored-by: Yonmaru40 <[email protected]> * Update src/locales/zh_CN/pokemon-summary.ts Co-authored-by: Yonmaru40 <[email protected]> * Update src/locales/zh_CN/pokemon-summary.ts Co-authored-by: Yonmaru40 <[email protected]> * Update src/locales/es/pokemon-summary.ts Co-authored-by: Arxxer <[email protected]> * Update src/locales/es/pokemon-summary.ts Co-authored-by: Arxxer <[email protected]> --------- Co-authored-by: Alexis <[email protected]> Co-authored-by: Mr.WaterT <[email protected]> Co-authored-by: Alexis Faizeau <[email protected]> Co-authored-by: GoldTra <[email protected]> Co-authored-by: returntoice <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: 송지원 <[email protected]> Co-authored-by: Niccolò <[email protected]> Co-authored-by: Yonmaru40 <[email protected]> Co-authored-by: Arxxer <[email protected]> * [Localization] Localization arena flyout (Active Battle Effects) (#2932) * localizing Active Battle Effects (working) * Localize Active Battle Effects * Change return value * Modify arena terrain desc * Update src/locales/zh_CN/arena-flyout.ts Co-authored-by: Yonmaru40 <[email protected]> * Update src/locales/de/arena-flyout.ts Co-authored-by: Jannik Tappert <[email protected]> * Update src/locales/fr/arena-flyout.ts Co-authored-by: Lugiad' <[email protected]> * Update arena-flyout.ts (IT) * Update src/locales/pt_BR/arena-flyout.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/es/arena-flyout.ts Co-authored-by: Arxxer <[email protected]> * Change util function name --------- Co-authored-by: 송지원 <[email protected]> Co-authored-by: Yonmaru40 <[email protected]> Co-authored-by: Jannik Tappert <[email protected]> Co-authored-by: Lugiad' <[email protected]> Co-authored-by: Niccolò <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: Arxxer <[email protected]> * This should prevent gym leaders appear as doubles (marnie & piers) when they arent fixed battles (#2904) * The stat messages can now be plural (#2600) * The stat messages are now plural * "And" can now be localized * Revert Override * Update src/locales/fr/battle.ts Co-authored-by: Lugiad' <[email protected]> * Update src/locales/fr/battle.ts Co-authored-by: Lugiad' <[email protected]> * Update src/locales/fr/battle.ts Co-authored-by: Lugiad' <[email protected]> * Update src/locales/zh_CN/battle.ts Co-authored-by: Yonmaru40 <[email protected]> * Update src/locales/ko/battle.ts Co-authored-by: Enoch <[email protected]> * Update src/locales/ko/battle.ts Co-authored-by: Enoch <[email protected]> * Update src/locales/es/battle.ts Co-authored-by: GoldTra <[email protected]> * Update src/locales/es/battle.ts Co-authored-by: GoldTra <[email protected]> * Update src/locales/de/battle.ts * Update src/locales/pt_BR/battle.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/pt_BR/battle.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/data/battle-stat.ts * Update src/locales/zh_CN/battle.ts Co-authored-by: Yonmaru40 <[email protected]> * Changed the way the multiple is handeled to use the i18n way * Missed one file * Apply suggestions from code review * Apply suggestions from code review * Changed the tests so they work now with the i18n hting * Fixed some other tests (chinese still makes problems... * Fix tests for chinese * Tests * Update src/test/battle-stat.spec.ts * Update src/locales/zh_CN/battle.ts Co-authored-by: Yonmaru40 <[email protected]> * Apply suggestions from code review --------- Co-authored-by: Lugiad' <[email protected]> Co-authored-by: Yonmaru40 <[email protected]> Co-authored-by: Enoch <[email protected]> Co-authored-by: GoldTra <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * [Enhancement][QoL] Add option to adjust shop overlay opacity (#2622) * add option to adjust shop overlay opacity * add localization * fix bug * Update src/locales/fr/settings.ts Co-authored-by: Lugiad' <[email protected]> * Update src/locales/zh_CN/settings.ts Co-authored-by: Yonmaru40 <[email protected]> * Update src/locales/fr/settings.ts Co-authored-by: Lugiad' <[email protected]> * update default value * update setting values * re-add value 10 * Update src/locales/pt_BR/settings.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/ko/settings.ts Co-authored-by: Enoch <[email protected]> * Update src/locales/es/settings.ts Co-authored-by: InnocentGameDev <[email protected]> * Update settings.ts --------- Co-authored-by: Lugiad' <[email protected]> Co-authored-by: Yonmaru40 <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: Enoch <[email protected]> Co-authored-by: InnocentGameDev <[email protected]> Co-authored-by: Niccolò <[email protected]> * [Bug] Fix battler tags lapsing at incorrect times (#2944) * Fix battler tags lapsing at incorrect times * Document FlinchedTag * Update French pokemon-summary.ts (#2976) * [Test] Prevent tests from running if overrides are different from the default values (#2110) * mock default overrides in test setup * change beforeEach to beforeALl * move some more enums into the enums directory * replace modules that import i18n into overrides with modules that don't * add pre tests and update vitest configs, scripts * replace tabs with spaces * fix vitest server port overlap warning * add missing overrides and clean up workspace config * change test name * include spec files in main test suite * [QoL] Highlight targets of multitarget moves instead of immediate execution (#2863) * show targets for move targeting multiple pokemon * dont allow selecting target if multiple * fix targeting * cleanup * more cleanup * only highlight targets is move is not status * fix tests failing * fix tests * change "immediately" to "auto" * nevermind just remove auto * remove status move condition * [Refactor] rewrite applyAbAttrsInternal to use an iterator. (#1832) * initial rewrite of applyAbAttrsInternal * clean up applyAbAttrsInternal * remove the await because it wraps non Promises in a promise * add TODO comment about promises * fix broken costar test, hopefully * Update typescript and typedoc (#2988) * update typescript and typedoc to latest versions * forgot to add the package-lock * add fixes for breaking type gen * update workflow (#2989) * [Qol/Balance] Dynamax cannon tweak (#2540) * Dynamax Cannon fix * Update src/locales/fr/move.ts Added fr translation. Co-authored-by: Lugiad' <[email protected]> * Update src/locales/fr/move.ts Adding an important missing precision in French description Co-authored-by: Lugiad' <[email protected]> * Update src/locales/de/move.ts German locale commit. Co-authored-by: Jannik Tappert <[email protected]> * Update src/locales/zh_CN/move.ts Chinese locale commit, checked by a native speaker Co-authored-by: Lugiad' <[email protected]> * Update src/locales/ko/move.ts Korean locale added Co-authored-by: returntoice <[email protected]> * fixed trailing space in Chinese locale * added es locale * Different Dynamax Cannon fix. This one is the one * Dynamax Cannon fix localisations * Update src/locales/fr/move.ts Added fr locale Co-authored-by: Lugiad' <[email protected]> * Update src/locales/de/move.ts German translation ^^ Co-authored-by: Jannik Tappert <[email protected]> * Update src/locales/pt_BR/move.ts pt-BR translation Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/de/move.ts Eslint fix, good catch @Enoch Co-authored-by: Enoch <[email protected]> * Update src/locales/ko/move.ts Korean locale ^^ Co-authored-by: sodam <[email protected]> * Update src/locales/zh_CN/move.ts zh_CN locale Co-authored-by: RimKnight <[email protected]> * Update src/locales/zh_TW/move.ts zh_TW locale Co-authored-by: RimKnight <[email protected]> * Update move.ts linting mistake due to how my comment was written * Update move.ts linting mistake due to how my comment was written * Update move.ts [Localization(it)] * WIP test * WIP test part 2 * [Test] Add Unit Tests for Dynamax Cannon * removed some unnecessary cases in the test to reduce testing overhead * Update src/locales/ko/move.ts Updated kr locale Co-authored-by: Enoch <[email protected]> * [Test] Adjust Unit Tests for Dynamax Cannon --------- Co-authored-by: Lugiad' <[email protected]> Co-authored-by: Jannik Tappert <[email protected]> Co-authored-by: returntoice <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: Enoch <[email protected]> Co-authored-by: sodam <[email protected]> Co-authored-by: RimKnight <[email protected]> Co-authored-by: Niccolò <[email protected]> Co-authored-by: xsn34kzx <[email protected]> * [Test] Fix/Extend Unit Test for Hard Press (#2992) * [Test] Update tests to enable no-crits override (#2971) * Update tests to enable no-crits override * Rename variable maxHP to initialHP * [Localization]Localized move-trigger text (#2913) * [Localization]Localized move-trigger text * [Localization]Localized zh-cn move-trigger text * [Localization]fix typo * [Localization]fix typo * Update src/locales/pt_BR/move-trigger.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * [Localization]add pokemonName to move-trigger.ts * [Localization]add pokemonName to move-trigger.ts * Update zh_TW move-trigger.ts * Update zh_CN move-trigger.ts * Update move.ts * Update src/locales/ko/move-trigger.ts Co-authored-by: Enoch <[email protected]> * Update src/locales/ko/move-trigger.ts Co-authored-by: Enoch <[email protected]> * Update move-trigger.ts * Update src/locales/de/move-trigger.ts Co-authored-by: Jannik Tappert <[email protected]> * [Localization]add affix to target pokemon names * Update src/locales/fr/move-trigger.ts Co-authored-by: Lugiad' <[email protected]> * localized type --------- Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: Enoch <[email protected]> Co-authored-by: Jannik Tappert <[email protected]> Co-authored-by: Lugiad' <[email protected]> * [Bug] Fix description of rare candy to have proper amount of level (#2903) * [Bug] Fix description of rare candy to have proper amount of level * Update en locales * Add locales * Add locales * Update src/locales/de/modifier-type.ts Co-authored-by: Jannik Tappert <[email protected]> * Update src/locales/de/modifier-type.ts Co-authored-by: Jannik Tappert <[email protected]> * Update src/locales/fr/modifier-type.ts Co-authored-by: Lugiad' <[email protected]> * Update src/locales/fr/modifier-type.ts Co-authored-by: Lugiad' <[email protected]> * Update src/locales/ko/modifier-type.ts Co-authored-by: Enoch <[email protected]> * Update src/locales/ko/modifier-type.ts Co-authored-by: Enoch <[email protected]> * Update src/locales/zh_CN/modifier-type.ts Co-authored-by: Yonmaru40 <[email protected]> * Update src/locales/zh_CN/modifier-type.ts Co-authored-by: Yonmaru40 <[email protected]> * Update src/locales/pt_BR/modifier-type.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/pt_BR/modifier-type.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update modifier-type.ts (IT) * Update src/locales/es/modifier-type.ts Co-authored-by: Arxxer <[email protected]> * Update src/locales/es/modifier-type.ts Co-authored-by: Arxxer <[email protected]> --------- Co-authored-by: Jannik Tappert <[email protected]> Co-authored-by: Lugiad' <[email protected]> Co-authored-by: Enoch <[email protected]> Co-authored-by: Yonmaru40 <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: Niccolò <[email protected]> Co-authored-by: Arxxer <[email protected]> * move status effect enum into separate file (#2998) * add .env.test (#2997) block i18n debug output by default * [QoL] Create default overrides class and export that with custom overrides (#2999) * Create default overrides class and export that with custom overrides * add comment to mock import and replace typecast with type narrowing * change modifier override type to pick keys from modifierTypes * [Feature][FUN] add breedersInSpace splash message (#2631) * add spaceBreeder splash message * fix typo (whops) * Add pt_BR translation Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * replace text & key with breedersInSpace * add french tanslation Co-authored-by: Lugiad' <[email protected]> * remove obsolete array split in splash-messages.ts * Update src/locales/pt_BR/splash-messages.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/es/splash-messages.ts Co-authored-by: Asdar <[email protected]> * Update splash-messages.ts (Italian) * Update src/locales/zh_CN/splash-messages.ts Co-authored-by: Yonmaru40 <[email protected]> * Update src/locales/ko/splash-messages.ts Co-authored-by: sodam <[email protected]> --------- Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: Lugiad' <[email protected]> Co-authored-by: Asdar <[email protected]> Co-authored-by: Niccolò <[email protected]> Co-authored-by: Yonmaru40 <[email protected]> Co-authored-by: sodam <[email protected]> * [Enhancement] Pokemon generation number tooltip (#2642) * Create tooltip to show Pokemon generation * Add option to toggle generation tooltip * Use roman numeral for generation tooltip * Revert "Add option to toggle generation tooltip" This reverts commit 414b2366fc55c5642f8858d6f4854aa62c4caf60. * Update src/locales/de/battle-info.ts Co-authored-by: Jannik Tappert <[email protected]> * Update src/locales/fr/battle-info.ts Co-authored-by: Lugiad' <[email protected]> * Update src/locales/pt_BR/battle-info.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/zh_TW/battle-info.ts Co-authored-by: RimKnight <[email protected]> * Update src/locales/zh_CN/battle-info.ts Co-authored-by: RimKnight <[email protected]> * Update src/locales/ko/battle-info.ts Co-authored-by: Enoch <[email protected]> * Update battle-info.ts (IT) --------- Co-authored-by: Jannik Tappert <[email protected]> Co-authored-by: Lugiad' <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: RimKnight <[email protected]> Co-authored-by: Enoch <[email protected]> Co-authored-by: Niccolò <[email protected]> * [Beta] Updating the manage data->unlock all option to work with all abilities, natures, forms and passives (#2967) * Updated code to allow user to unlock all pokemon from the manage data menu option * Added code to Utils to allow it to check for a beta env, and hid the unlock all code behind that. This should stop it from being accessed in prod envs * Updated another section to be locked behind beta check, and also updated the everything.prsv to have everything unlocked going forward * Fixed some code reviews * [Bug] vite port (for development) (#3003) * make vite-port configurable and make it default 8000 * add retries for `does not trigger by non damage moves` test * feat: Update isBeta check in utils.ts to use import.meta.env.MODE The current implementation of the isBeta check in utils.ts is using import.meta.env.DEV, which gives the same value for both beta and dev environments. This commit updates the check to use import.meta.env.MODE === "beta" to accurately determine if the environment is beta. This ensures that the unlock all code is only accessible in the beta environment and not in production environments. * refactor: Update trainerId and secretId in game data This commit updates the `trainerId` and `secretId` properties in the `GameData` class. The values are replaced with the corresponding values from the `this.trainerId` and `this.secretId` variables. This change ensures that the `trainerId` and `secretId` are correctly updated in the game data. * Adds bg glow behind starters with unlocked passives (#2497) * [Localization] Localize missed things in battlers-tag.ts (#3004) * Localize missed things in battlers-tag * Change orders of configs * Add missed phase * Update src/locales/zh_CN/battle.ts Co-authored-by: RimKnight <[email protected]> * Update src/locales/zh_CN/battle.ts Co-authored-by: RimKnight <[email protected]> * Update src/locales/zh_TW/battle.ts Co-authored-by: RimKnight <[email protected]> * Update src/locales/zh_TW/battle.ts Co-authored-by: RimKnight <[email protected]> * Update src/locales/zh_TW/battler-tags.ts Co-authored-by: RimKnight <[email protected]> * Update src/locales/zh_CN/battler-tags.ts Co-authored-by: RimKnight <[email protected]> --------- Co-authored-by: RimKnight <[email protected]> * [Feature] Fully implement Octolock (#2985) * implement octolock * Add tests * [Bug] Fix import of overrides in a test (#3009) * [BUG] Fixes Sketch copying the first move used by the opponent instead of the last (#2759) * Changes getMoveHistory to getLastXMoves to fix sketch copying first move used instead of last * Optimizes move search and early return * Reverts check for virtual moves * [Bug] Making FormChangeItems Untransferrable (#2695) * Made FormChangeItems untransferrable. Replaced getTransferrable() * Made isTransferrable readonly. Removed unnecessary 'm as PokemonHeldItemModifier'. * [Bug] Fix Clear terrains upon Trainer Battle (#2027) * Clear terrains upon Trainer Battle * Adjusted comment * Fix item reward overrides going out of bounds (#3012) * [Localization] Localize Berry Heal message (#2996) * Localize berry heal message (HP/PP) * Change location of translation * conflict resolve * Update src/locales/de/battle.ts Co-authored-by: Jannik Tappert <[email protected]> Update src/locales/de/battle.ts Co-authored-by: Jannik Tappert <[email protected]> Update src/locales/de/battle.ts Co-authored-by: Jannik Tappert <[email protected]> * Update src/locales/zh_CN/battle.ts Co-authored-by: mercurius-00 <[email protected]> * Update src/locales/zh_TW/battle.ts Co-authored-by: mercurius-00 <[email protected]> * Update src/locales/fr/battle.ts Co-authored-by: Lugiad' <[email protected]> * Update src/locales/pt_BR/battle.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/pt_BR/battle.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update battle.ts (Berries ITALIAN) --------- Co-authored-by: 송지원 <[email protected]> Co-authored-by: Jannik Tappert <[email protected]> Co-authored-by: mercurius-00 <[email protected]> Co-authored-by: Lugiad' <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: Niccolò <[email protected]> * Adds a check to the bgm-bar display to prevent it from being displayed in case of an empty value (#3007) * [Sprite] Improves Corviknight Palette usage (#3020) * [Sprite] Compress Corviknight exp * [Sprite] Compress Corviknight exp * [Sprite] Compress Corviknight exp * [Sprite] Compress Corviknight exp * [Sprite] Compress Corviknight exp * [Beta][Localization] Update French battler-tags.ts and battle.ts (#3015) * Update French battler-tags.ts * Update battle.ts * [Bug] Fix Lock-On and Mind Reader not working on the first turn (#3001) * [Bug] Struggle Recoil should ignore Magic Guard (#3017) * Drafted testable conditions for Magic Guard * Weather Test * Update src/test/abilities/magic_guard.test.ts InnerThunder Co-authored-by: innerthunder <[email protected]> * Implemented checks for poison/toxic/burn * Added tests for recoil moves and volatile status * Updated Rock Head, Magic Guard, and Reckless interactions with Struggle * Removed stray file * Fixed Typedoc errors * Implemented innerthunder's feedback --------- Co-authored-by: Frutescens <info@laptop> Co-authored-by: innerthunder <[email protected]> * [Enhancement] Decouple move power calculation from Pokemon.apply(), Fixes Power Spot & Battery not boosting ally's move (#2984) * refactor power calc, fix battery & power spot * fix hard press unit test * fix hard press * refactor tests * use sypOn hp instead * rename method * cleanup tests * improve tests * use slow vs fast pokemon * fix steely spirit test * fix steely spirit for real this time * remove unnecessary test * address pr feedback * add removed code * [QoL] Offset the status indicator to keep pokeball in view (#2966) * Offset the status indicator to keep pokeball in view * Only use offsetX when the Pokemon is the enemy * Adjust position to accomodate boss health bar * [Bug] Fix to epic shiny Yungoos icon (#2991) (#3016) Fixed a floating pixel in epic shiny Yungoos' icon. Caused by Mimikyu's epic shiny sprite being placed too high on the sprite sheet. Moved Mimikyu's sprite down and updated json to reflect the change. * [Localization(ko)] Change line-break position of ghost type curse add message (#3022) * Revert "[Localization]Localized move-trigger text (#2913)" (#3026) This reverts commit 39bdfea0c8b33a759db760809d6488d825b510e2. * [Localization(ko)] Fixed typo in Bertha's dialogue (#3025) * [Bug] Prevent fixed-damage and OHKO moves from being modified by damage-reducing abilities (#2703) * ReceivedMoveDamageMultiplierAbAttr patch: WIP refactored damage calculation, reordered ReceivedMoveDamageMultiplierAbAttr to avoid issues with fixed damage and OHKO moves, stubbed unit tests for dragon rage (fixed damage) and fissure (OHKO) * ReceivedMoveDamageMultiplierAbAttr patch: commented concerns regarding EnemyDamageBooster/ReducerModifier for others' reference in WIP branch * ReceivedMoveDamageMultiplierAbAttr patch: reordered ReceivedMoveDamageMultiplierAbAttr and EnemyDamageBooster/ReducerModifier to not trigger for fixed damage and OHKO moves, completed relevant tests for dragon rage and fissure * ReceivedMoveDamageMultiplierAbAttr patch: removed newline * ReceivedMoveDamageMultiplierAbAttr patch: in the unit test, extracted hard-coded Dragon Rage damage to a variable * ReceivedMoveDamageMultiplierAbAttr patch: naming consistency * ReceivedMoveDamageMultiplierAbAttr patch: replaced awaiting DamagePhase with TurnEndPhase as the former assumes damage will be done * ReceivedMoveDamageMultiplierAbAttr patch: removed redundant overrides in Fissure tests * ReceivedMoveDamageMultiplierAbAttr patch: tests: refactored crit removal, removed berries, fixed bug associated with Porygon sometimes getting Trace and copying the opponent's ability, which would override the manual ability override * Fixed unit tests * Added a comment and cleaned up an existing one * [Localization] Brought german localization up to date (#3010) * Fixed errors in the german localization * Fresh Start Challenge * Update src/locales/de/move-trigger.ts Co-authored-by: flx-sta <[email protected]> * Apply suggestions from code review --------- Co-authored-by: flx-sta <[email protected]> * [Bug] Remove redundant damage number popups (#3024) * Remove magic number from Belly Drum's attr * Remove redundant damage number popup * Fix merge issue and remove another duplicate damage number instance * [Move] Implements Conversion 2 (#2943) * Creates function to get type resistances, implements conversion 2 * Removes unimplemented tag, adds condition for move history to exist * Cleans up type selection, creates i18n entries for typeChanged * Uses typeChanged i18n in Conversion move * More detailed docs, early return with stellar/unknown type * Adds note that it wont track type-changing moves properly * Rephrases doc description, adds partial since it can't track type-changing moves * Updates localization, removes typeChanged entry to use move-trigger entry * Missed locale de entry in last commit * Adds comment for reason of .partial() * Fixes localization error due to revert, removes improper merge conflict from prior commit * [BUG] Fixes bug with Metronome freezing the game (#2819) * Tests MovePhase with new PokemonMove instead of moveset search * Accounts for metronome call on charging moves * Update comment in ChargeAttr to be clearer * Add missing passive background graphic for legacy UI Relating to #2497 , this adds an identical graphic to the legacy UI files, as it will show up as a missing texture otherwise. * [Localization] Localize ability messages in ability.ts (trigger, apply...) (#2972) * localize ability messages * Update src/locales/de/ability-trigger.ts Co-authored-by: Jannik Tappert <[email protected]> * Modify parameter name, fix eslint * Korean Translation, modify some wrong param * Add missed message * Update src/locales/de/ability-trigger.ts Co-authored-by: Jannik Tappert <[email protected]> * Update ability-trigger.ts (Partial) (Italian) * Localize type name * Localize type name > Libero, Protean * param bug fix * Update src/data/ability.ts * Update zh-cn * Update ability-trigger.ts (Partial part 2, still not completed) (Italian) * Update src/locales/fr/ability-trigger.ts Co-authored-by: Lugiad' <[email protected]> * Update src/locales/pt_BR/ability-trigger.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/fr/ability-trigger.ts Co-authored-by: Lugiad' <[email protected]> --------- Co-authored-by: 송지원 <[email protected]> Co-authored-by: Jannik Tappert <[email protected]> Co-authored-by: Niccolò <[email protected]> Co-authored-by: Lugiad' <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update egg.ts (italian) (#3038) * [Sprite] Revert Larvesta, fixing stray pixels (#3042) * [Sprite] Remove normal Larvesta stray pixels Taken from original commit * [Sprite] Revert shiny Larvesta stray pixels Taken from original commit * [Sprite] Match variant Larvesta colours * [Bug] Fix level 100 moves being skipped if leveled past 100 (#3040) * [Bug][Fix][Surf][Muddy Water][Sludge Wave][Animation] Added image to move animations. (#3044) * Update muddy-water.json * Update sludge-wave.json * Update surf.json * [Sprite] Fix Cofagrigus sprite (#3045) * Fix Cofagrigus sprite * Base sprite fix * Created json variant file... manually * Fix FR typo (#3051) * [Beta][Localization] Update Portuguese battler-tags.ts and battle.ts (#3050) * [Music/BGM] Fix bgm file & loop for battle_rival (#3053) * stop loading pride-update banner (#3057) * [Item] Add Scope Lens and Leek (#2666) * [Item] Add Scope Lens and Leek * Add Entry to pt_BR * Localize for pt_BR Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Fix & Clean Unit Tests --------- Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * [Music/BGM] New music added for the "Slum" biome, composed by Andr06 (#3000) * Replacement of the BGM in the slum biome (by Andr06) * Modification of BGM credits in README.md * Replacement of the BGM name by the title chosen by its composer in all languages * Update BGM loop point for biome 'SLUM' * [Bug] implemented multi target damage penalty (#2329) * fix: damage multiplier by the number of targets * fix: used actual number value rather than the number holder * test: added unit test for counting targets * multi-target: fixed names of the unit tests. * test: simple-test changes * test: changed multi-target test code * test: testing damage decreasement * test: multi-target test fix * resolved conflicts in test --------- Co-authored-by: Tempoanon <[email protected]> * [BUG] Uturn faint switch bug fix (#2980) * reordering adding switch phases for u-turn * reverting some temp changes * generalizing function * adding PR suggestions * nit indenting * [Sprite] Remove extra Oinkologne sprites (#3067) * Delete public/images/pokemon/female/916.png * Delete public/images/pokemon/exp/female/916.json * Delete public/images/pokemon/exp/female/916.png * Delete public/images/pokemon/female/916.json * [Sprite] Mega Mewtwo sprite fixes (#3065) * [Sprite] Add static epic Mega Mewtwo Y Colours taken from exp, as consistent/exp rare backs share palettes. * [Sprite] Fix transparent pixels on Mega Mewtwo X * [Sprite] Fix transparent pixels on Mega Mewtwo X * [Sprite] Add static epic Mega Mewtwo Y Now exists, and is a paletteswap * [Music/BGM] New music added for the "Sea" biome, composed by Andr06 (#3063) * Replacement of the BGM in the sea biome (by Andr06) * Modification of BGM credits in README.md * Replacement of the BGM name by the title chosen by its composer in all languages * Update BGM loop point for biome 'SEA' * [Balance] Add 12 new TMs and remove 3 (#2733) * Added Counter TM * Counter, Aqua Tail, Gastro Acid, Pluck, Secret Power, Aurora Veil, Incinerate * Placed TMs in proper order, added to pool * Add Secret Power to the pool * Add TM for Synthesis * Covet, Heal Bell, PUPunch, Recycle, Volt Tackle, Worry Seed * Remove species specific TMs * Remove Secret Power TM until implementation * [Refactor/Test] Update Dynamax Cannon Unit Tests (#3074) * [Refactor/Test] Update Dynamax Cannon Unit Tests * Adjust Test Names * fix: update SameSite attribute in setCookie function to None * fix: update SameSite attribute in setCookie function to Strict * feat: Add prompt=none to Discord OAuth authorization URL * fix: Remove unnecessary cookie setting in LoginPhase and MenuUiHandler * feat: Improve cookie handling in getCookie function * feat: Delete duplicate cookies with the same name in getCookie function * [Localization] Add minor Korean translations to ability-trigger file (trace) (#3093) * modify trace trigger description (refered from official translation) modify trace trigger description (refered from official translation) * modify trace trigger description (refered from official translation) modify trace trigger description (refered from official translation) * Fix broken `multi_target` tests and remove RNG-based failures (#3095) * Prevent RNG from breaking the Quick Draw tests (#3096) * Make EXP boosting items stack additively and not multiplicatively (#3094) Fixes #2040 * [Bug] Fixes Encore bug with multi-target moves missing (#3060) * Pushes move history even when multi target move misses * Move pushMoveHistory out of Move Pending condition * Add remaining relearn moves (#2894) * [Enhancement] Decouple move accuracy and accuracy multiplier calculation from phases.ts (#2899) * refactor accuracy calc * update doc * move accuracy multiplier calculation outside phases * update wonder skin unit test * rename method * add docs * add unit tests * address feedback * rename method * fix imports * improve tests * add test for ohko move accuracy * [Sprite] Fix a number of sprite issues including the Zubat line, Goldeen, Golett, Dudunsparce, H-Sneasel, Garchomp, Sylveon, Marshadow (#3069) * Batfix, Goldeen, Chomp, Golett, genies * Fix Dudunsparce using Reborn shiny backsprite for whatever reason * Fix female Hisuian Sneasel missing variants * Marshadow epic front and Zenith, Sylveon back * Fix Zubat line back sprite inconsistencies * Fix Noivern shiny back * [Move] Finish implementation of Glaive Rush (#2720) * Finish implementation of Glaive Rush * Fix test RNG * Add code/test for Multi-Lens interaction * Fix off-by-one error in test caused by rounding issues * Update for code changes * Fix BattlerTag name * [Bug] fix not changing moveset after add to starter #1932 (#2396) * [Bug] Enemies can properly use stuff cheeks (#3090) * [Feature] Added pokemon nicknames/renaming (#2570) * Added basic temp renaming * Made nickname persistant after reloading * Localization and cancel button * Fixed instant rename on active pokemon * Small bugfix to prevent console errors * Changed logic to use the new nickname field. Replaced most .name with getNameToRender() for display. * Changed evolution message. Removed log messagesc * Added localization keys for other languages * Removed empty lines * French translation Co-authored-by: Lugiad' <[email protected]> * Chinese translation Co-authored-by: Yonmaru40 <[email protected]> * Portuguese (Brazil) translation Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Korean translation Co-authored-by: Enoch <[email protected]> * Update menu.ts * Update menu.ts [Localization(it)] * Changed most .getNameToRender() instance to getPokemonNameWithAffix() * Changed wild encounter messages back to just use the name without affix. * Added localization for the party ui rename selection * Escaping nickname characters to support all characters * Better Error handling * Update src/field/pokemon.ts Co-authored-by: flx-sta <[email protected]> --------- Co-authored-by: Lugiad' <[email protected]> Co-authored-by: Yonmaru40 <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: Enoch <[email protected]> Co-authored-by: Niccolò <[email protected]> Co-authored-by: flx-sta <[email protected]> * [Sprite] Show Partner Eevee variants (#3097) * [Sprite] Show Partner Eevee variants Taken from non-partner Eevee * [Sprite] Show Partner Eevee variants Taken from non-partner Eevee * [Sprite] Show Partner Eevee variants * Allow Necrozma forms to play their special music (#3054) * [BUG] fixing multi-hit and move messages on faint (#2981) * fixing order of messages, scences, to render messages before fainting * updated fix for effectiveness text rendering order for multi hit moves * fixing messages not appearing for multi-hit moves on faint * updated multi-hit condition) * fixing PR conflicts * adding comments and FaintPhase setPhaseQueueSplice bug, fixing overrides merge conflict * writing better comments * removing space diff in overrides * adding fainting check for self damage moves * emergency fixing broken last commit * additional comments for multi-hit problem * updating comments, jsdoc style * fixing linter, destiny bond errors * splitting up varaible comments to be in JSDoc format * fixing tests and merge mistakes * adding rendering of multihit moves that only hit once * fixing comment formatting_tabs and spaces --------- Co-authored-by: Benjamin Odom <[email protected]> * [Bug] Sheer Force/Serene Grace Flyout Bugfix (#2496) * Disable Show Ability for Serene Grace and Sheer Force when opponent calculates targetBenefitScore * Add comment and definition to argument * [Visual] Achievement icons (#2617) * Text Changes to MonoGen Challenges * Item Texture Files * MonoGen Ribbons added * Resolving merge conflict * Updated texture files? I think * Changed image names and added new localizations for syntax * Removed unused ribbons * [Feature] replace bug-report template with form (#2772) * replace bug-report template with form * update bug_report.yml * add palceholders for data & session file * Update item atlas * Update item atlas again This time, after merging main into the PR. * [Sprite] Show Partner Eevee variants (#3097) * [Sprite] Show Partner Eevee variants Taken from non-partner Eevee * [Sprite] Show Partner Eevee variants Taken from non-partner Eevee * [Sprite] Show Partner Eevee variants * Merged with beta's new items * Fixed typedoc issues * Removing localizations * Text Changes to MonoGen Challenges * Item Texture Files * MonoGen Ribbons added * Resolving merge conflict * Updated texture files? I think * Changed image names and added new localizations for syntax * Removed unused ribbons * Update item atlas * [Feature] replace bug-report template with form (#2772) * replace bug-report template with form * update bug_report.yml * add palceholders for data & session file * Update item atlas again This time, after merging main into the PR. * Merged with beta's new items * Fixed typedoc issues * Removing localizations * Allow Necrozma forms to play their special music (#3054) * Allow Necrozma forms to play their special music (#3054) * MonoGen Ribbons added * Text Changes to MonoGen Challenges * Item Texture Files * MonoGen Ribbons added * Updated texture files? I think * Changed image names and added new localizations for syntax * Fixed typedoc issues * Revert "Text Changes to MonoGen Challenges" This reverts commit 3bf79acc6a797b0e28e68e113e644b30096ea9ce. * Text Changes to MonoGen Challenges * Item Texture Files * MonoGen Ribbons added * Resolving merge conflict * Updated texture files? I think * Changed image names and added new localizations for syntax * Removed unused ribbons * Update item atlas * [Feature] replace bug-report template with form (#2772) * replace bug-report template with form * update bug_report.yml * add palceholders for data & session file * Update item atlas again This time, after merging main into the PR. * Merged with beta's new items * Fixed typedoc issues * Removing localizations * Text Changes to MonoGen Challenges * Item Texture Files * MonoGen Ribbons added * Resolving merge conflict * Updated texture files? I think * Changed image names and added new localizations for syntax * Removed unused ribbons * Update item atlas * Update item atlas again This time, after merging main into the PR. * Merged with beta's new items * Fixed typedoc issues * Removing localizations * MonoGen Ribbons added * Text Changes to MonoGen Challenges * Item Texture Files * MonoGen Ribbons added * Updated texture files? I think * Changed image names and added new localizations for syntax * Fixed typedoc issues * Revert "Text Changes to MonoGen Challenges" This reverts commit 3bf79acc6a797b0e28e68e113e644b30096ea9ce. * Please fix this. * Revert "[Feature] replace bug-report template with form (#2772)" This reverts commit aa69b107778123b2173bee6130e5d172d201b637. --------- Co-authored-by: Frutescens <info@laptop> Co-authored-by: flx-sta <[email protected]> Co-authored-by: Madmadness65 <[email protected]> Co-authored-by: chaosgrimmon <[email protected]> Co-authored-by: Madmadness65 <[email protected]> * Re-add changes accidentally deleted by #2617 * Fix some broken images in item atlas & achievement Fixed the broken sprites in the item atlas, and fixed the Baton Pass achievement to use the Baton item now (it was broken by the Leek being renamed). Also resized the Baton item image to 32*32, like all the other items. * fix: Remove unnecessary cookie setting in removeCookie function * fix: Update removeCookie function to use Max-Age=-1 instead of Expires header The removeCookie function was updated to use the Max-Age=-1 attribute instead of setting the Expires header to a past date. This change ensures that the cookie is immediately expired when removed, preventing any potential login loops. Additionally, a legacy cookie without a domain was added to handle older cookies. This commit resolves the unnecessary cookie setting in the removeCookie function. * [QoL] Starter UI selection update to allow removing specific pokemon from party (#1983) * Initial commits with logic to remove starters if they're in your party. Still need to make it work so that the starter selection cursor disappears when a starter is unselected * Updated code to be able to remove pokemon, including the side icons and cursor locations * Fixed popstarter to work with any index * Updating code to allow navigation of starter icons * Updating code to allow navigation of party starter icons * Updaing navigation of party icons * Updated logic to fix incorrect icon in top left of pokemon options when navigating the starter icons * Updated logic to include the ability to navigate and interact with the starter icons * Forgot to push the actual starter-select-ui-handler. Might be a bit hard to test things out without that :) * Removed some unnecessary comments * Fixed small bug with not being able to move from the far right to the gen selection when the starter icons were empty * Updated code to not be using a method to generate the party menu and made it more like it used to be. This should help with merge conflicts in the future * I committed the merged version but forgot to make the starter-select-ui-handler staged after making the changes * Accidentally broke challenges that had a specific typing requirement with last commit. This should fix it * Changed how navigation worked based on popular demand * Fixed code review comments * Accidentally left in a whole block of commented code. Intentionally removing it now * Started adding logic for mono type challenge runs to not break the game if the user tries to start a run with an invalid party * Updated the text to say the party is invalid * Updated logic to make invalid pokemon greyed out when no valid pokemon are in your party * Added comments on some code * Updated locales to include the key for trying to start with invalid parties during a challenge * Fixed some code from a bad merge where a challenge related param that was previously a number now needed to be a boolean and wasn't * Removed comment as per review * [Bug] Ability changing on evolution fix (#2995) * Prevent Pokemon with their second ability from evolving into their HA * Add check for fusions too * Localization(pt): Updated move.ts (#3078) * Localization(pt): Updated move.ts and fixed King's Shield * more fixes * [Bug] Enemy pokemon's Harvest creates berry icons on the player's side when triggered (#3077) * [Bug] Fix hustle not applying attack boost (#3101) * [Sprite] Mega Latis using opposite's eye colour (#3102) * [Sprite] Mega Latis using opposite eyes Taken from counterpart Lati * [Sprite] Update Mega Latios eyes * [Sprite] Update Mega Latias eyes * [Sprite] Mega Latias duplicated palette value Colour taken from non-exp Mega Latias * [Bug] Fix Thousand Arrows not hitting targets under the effects of Magnet Rise (#3100) * Fix Thousand Arrows not hitting through Magnet Rise * Add integration test for Thousand Arrows vs. Magnet Rise * ESLint * Remove unnecessary checks in integration tests * [Move] Aeroblast is a wind move (#3109) * Hardcoded Pokemon should have proper names * Aeroblast is a wind move * [Refactor] Replaces the single and double battles overrides with a single override (#3104) `SINGLE_BATTLE_OVERRIDE` and `DOUBLE_BATTLE_OVERRIDE` are now `BATTLE_TYPE` Also updates all uses of the old overrides with the new one * fix `Overrides` capitalization (#3111) * [Balance] More TM fixes (#3081) * More TM fixes * Leaf Storm * Removed sexy matcha * [Refactor] Code readability update (#3085) * Clean up/clarify `src/field/pokemon.ts` a bit Code provided by DerTapp on Discord * Update `PokemonSpeciesForm.getAbilityCount()` * Update `PokemonSpeciesForm.getAbility()` * Add explicit `Abilities.NONE` checks * Add tests * Add jsdoc and implement test suggestions * [Move] Implement Stockpile, Spit Up, Swallow (#2960) * feat: Implement Stockpile, Spit Up, Swallow * chore: Minor, likely unnecessary null checks * feat: Localization * Undo non-English localizations (unsure if they went through proper channels) * ko localization from @EnochG1 Co-authored-by: Enoch <[email protected]> * linting fix * add tests, tiny (non-functional) tweaks * Remove unnecessary cast * Update src/data/move.ts (oops) * remove some unnecessary comments, rename something for clarity --------- Co-authored-by: Enoch <[email protected]> * [Bug] Remove ability swap code in `PlayerPokemon.evolve()` (#3113) * [Test] Add test for rollout move (#3114) * add test for rollout move Co-authored-by: Zach Day <[email protected]> * fix tests still using `SINGLE_BATTLE_OVERRIDE` --------- Co-authored-by: Zach Day <[email protected]> * [Bug][Beta] Fix Hyper Beam, etc. permanently recharging (#3115) * Fix Hyper Beam, etc. permanently recharging * Fix override in hyper beam test * [QoL] New Starter Select UI with Filter (#2916) * update images for new UI * add updated starter UI with filter code * update starter-select test code * update win filter condition to pass test * remove unnecessary console log * update test code to match current filter UI * merge update * apply bugfix & chrry-pick small issues fix which are handled beta branch * resolve conflicts * fix lint errors * Fixed a bug where the target location for escaping using the left and right buttons on the starter button did not account for scrolling * update filter bar label color change when activated * fix lint error * fix lint * fix octolock.text.ts. it looks override import error. idk why it is happend in this PR. but it looks ok now * add passive dropdown in unlocks filter * fix lint * fix double button sound bug. refactoring genSpecies -> allSpecies, starterContainers -> starterContainer which are remove unnecessary generation axis * optimize updateStarterValueLabel function which is bottleneck of UI update latency * apply translation of gen filter label. fix lint * add # candies sort option * merge beta * resolve confilcts * fix offset of starter and start cursor * make compatible with starter UI * add missing feature * add images for legacy UI. adjust the position and size of the starterContainerWindow * [Localization] Implement Form localization (#3030) * Implement Pokemon forms localization * Update French pokemon-form.ts * Update French pokemon-form.ts * Update pokemon-form.ts * Add battle forms korean translation from returntoice Co-authored-by: returntoice <[email protected]> * Add cosplay forms korean translation from returntoice Co-authored-by: returntoice <[email protected]> * Add pichu form korean translation from returntoice Co-authored-by: returntoice <[email protected]> * Add castform forms korean translation by returntoice Co-authored-by: returntoice <[email protected]> * Add remaining forms korean translation by returntoice Co-authored-by: returntoice <[email protected]> * French typo corrections pokemon-form.ts * Update Korean pokemon-form.ts * Modify froakiBattleBond like rockruff of OwnTempo case, it is froakie, not greninja. * Modify zygardePc Power construct is more important information Switch its position to 50% or 10% to avoid overlapping with the sprite * Modify mispelling * Added german forms * Changed Gigadynamax and Unendynamax so it fits at all * Add partner pikachu and eevee form localization * Add mimikyu forms localization * Partner Pikachu, Partner Evoli und Mimikyu Formen hinzugefügt * Update pokemon-form.ts * Update partners * Fix conflicts * Fix useless ? by flx-sta Co-authored-by: flx-sta <[email protected]> * Fix switch use by flx-sta * Fix conflicts * Please work !!!!!!! * Update src/locales/fr/pokemon-form.ts Co-authored-by: Lugiad' <[email protected]> * Update src/locales/fr/pokemon-form.ts Co-authored-by: Lugiad' <[email protected]> * Add pt_br primal localization Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Add pt_br pikachu localization Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Add pt_br castform localization Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Add pt_br 3g localization Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Add zh_cn localization Co-authored-by: Yonmaru40 <[email protected]> * Add pt_br other localization Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Add es castform localization Co-authored-by: InnocentGameDev <[email protected]> * Add es burmy localization Co-authored-by: InnocentGameDev <[email protected]> * Add es shellos localization Co-authored-by: InnocentGameDev <[email protected]> * Add es rotom localization Co-authored-by: InnocentGameDev <[email protected]> * Add es basculin localization Co-authored-by: InnocentGameDev <[email protected]> * Add es deerling localization Co-authored-by: InnocentGameDev <[email protected]> * Add es froakie localization Co-authored-by: InnocentGameDev <[email protected]> * Add es scatterbug localization Co-authored-by: InnocentGameDev <[email protected]> * Add es furfrou localization Co-authored-by: InnocentGameDev <[email protected]> * Add es xerneas localization Co-authored-by: InnocentGameDev <[email protected]> * Add es zygarde localization Co-authored-by: InnocentGameDev <[email protected]> * Add es pumpkaboo localization Co-authored-by: InnocentGameDev <[email protected]> * Add es flabebe localization Co-authored-by: InnocentGameDev <[email protected]> * Add es oricorio localization Co-authored-by: InnocentGameDev <[email protected]> * Add es minior localization Co-authored-by: InnocentGameDev <[email protected]> * Add es magearna localization Co-authored-by: InnocentGameDev <[email protected]> * Add es marshadow localization Co-authored-by: InnocentGameDev <[email protected]> * Add es sinistea ocalization Co-authored-by: InnocentGameDev <[email protected]> * Add es eiscue localization Co-authored-by: InnocentGameDev <[email protected]> * Add es indeedee localization Co-authored-by: InnocentGameDev <[email protected]> * Add es rockruff localization Co-authored-by: InnocentGameDev <[email protected]> * Add es mimikyu localization Co-authored-by: InnocentGameDev <[email protected]> * Add es zarude localization Co-authored-by: InnocentGameDev <[email protected]> * Add es squawkabilly localization Co-authored-by: InnocentGameDev <[email protected]> * Add es tatsugiri localization Co-authored-by: InnocentGameDev <[email protected]> * Add es gimmighoul localization Co-authored-by: InnocentGameDev <[email protected]> * Add es poltchageit localization Co-authored-by: InnocentGameDev <[email protected]> * Add es paldeaTauros localization Co-authored-by: InnocentGameDev <[email protected]> * Add es primal localization Co-authored-by: InnocentGameDev <[email protected]> * Add es pikachu localization Co-authored-by: InnocentGameDev <[email protected]> * Add es partner localization Co-authored-by: InnocentGameDev <[email protected]> * Fix typedocs error * Fix typedocs error * cn form prefix added Co-authored-by: Yonmaru40 <[email protected]> * Fix german translate error * Fix typo Zh_CN Co-authored-by: mercurius-00 <[email protected]> * Update pokemon-form.ts [Localization(it)] * Update src/locales/es/pokemon-form.ts Co-authored-by: InnocentGameDev <[email protected]> * Fix megas forms bug and add forgotten forms * Fix wrong ko config * Add fr localization for new forms Co-authored-by: Lugiad' <[email protected]> * Add de localization for new forms Co-authored-by: Jannik Tappert <[email protected]> * Remove forgotten debug line Co-authored-by: Jannik Tappert <[email protected]> * Optimize battle forms * Update pokemon-form.ts (additional forms, italian localization) * The same typo is in the zh_TW placeholder text too. Co-authored-by: Madmadness65 <[email protected]> * Fix forgotten megaY Co-authored-by: Jannik Tappert <[email protected]> * Add capitalizeString to utils * Fix typedoc error * Update src/data/pokemon-species.ts Co-authored-by: Jannik Tappert <[email protected]> * Add ko localization for new forms Co-authored-by: MrWaterT <[email protected]> --------- Co-authored-by: Lugiad <[email protected]> Co-authored-by: returntoice <[email protected]> Co-authored-by: Mr.WaterT <[email protected]> Co-authored-by: MrWaterT <[email protected]> Co-authored-by: Jannik Tappert <[email protected]> Co-authored-by: flx-sta <[email protected]> Co-authored-by: Benjamin Odom <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: Yonmaru40 <[email protected]> Co-authored-by: InnocentGameDev <[email protected]> Co-authored-by: EnochG1 <[email protected]> Co-authored-by: mercurius-00 <[email protected]> Co-authored-by: Niccolò <[email protected]> Co-authored-by: Madmadness65 <[email protected]> * [Move] Fully implement Jungle Healing/Lunar Blessing status heal (#2785) * [Bug] Fix tags not resetting on switch (#3119) Fixes #2982 * [Move] Water Shuriken guarantees 3 hits with battle bond (#2687) * [Bug] Make on-summon abilities trigger after the switch check (#3118) * Make on-summon abilities trigger after the switch check * Add test * [Ability] Cloud Nine now displays a message on activation Maintains parity with Air Lock. Both of these probably need to be localized. Should fix issue 491 though * [QoL] Summary Option for Caught Pokemon (#2921) * Option to view Summary before adding new Pokemon to party * Fixed issues described by HopsWas * Adjusted makeRoomForConfirmUi to improve window spacing * Fixed ESLint issue + addressed OrangeRed review * Fixed Github pages issue * Removed duplicate unshiftPhase * Fixed phase order * Don't start from beginning of catch function * Option to view Summary before adding new Pokemon to party * Fixed issues described by HopsWas * Adjusted makeRoomForConfirmUi to improve window spacing * Fixed Github pages issue * Fixed phase order * Quick fix * This should fix the summaryOption feature without bugging confirm-ui-handler in other cases * Revert "Merge remote-tracking branch 'origin/summaryOption1' into summaryOption1" This reverts commit ea7d0ce59e3f5631a8ef3d76646069a3945ed036, reversing changes made to 4c565958dafe6904925015ed7100e4940f041213. * Added a better conditional that reflects its source and purpose --------- Co-authored-by: Frutescens <info@laptop> Co-authored-by: AJ Fontaine <[email protected]> * [Bug] Fix HP rounding issues (#2968) * [Bug] Fixes bug with frenzy moves keeping the confusion counter despite disruption (#3041) * Adds frenzyMissFunc trigger on NO_EFFECT hit result * Refactors FrenzyAttr to properly lapse tags each turn and remove tags on disrupt * Makes comment on CONFUSED tag clear…
Tempo-anon
added a commit
that referenced
this pull request
Jul 29, 2024
* feat: Add Google and Discord login functionality feat: Add link to Discord in menu UI feat: Add Discord and Google login functionality Add container around discord and google icons refactor: Update environment variable names for Discord and Google client IDs feat: Add "Or use" translation for login options in multiple languages feat: Update menu UI translations for multiple languages Code review fixes refactor: Update Discord and Google client IDs in environment variables * refactor: Add missing properties to initLoggedInUser function * Update src/locales/de/menu-ui-handler.ts Co-authored-by: Jannik Tappert <[email protected]> * make i18n debugging an optional env setting this also reduces output noise in tests * set development default also to "0" * fix inaccurate docs for TypeImmunityAbAttr (#2957) * chore: Add beta branch to GitHub Actions tests workflow * chore: Add beta branch to GitHub Actions linter and gh-pages workflow * Update src/locales/ko/menu-ui-handler.ts Co-authored-by: lnuvy <[email protected]> * Update src/locales/ko/menu.ts Co-authored-by: lnuvy <[email protected]> * Localization(pt): translated bgm-name.ts (#2955) * Localization(pt): translated bgm-name.ts * fix * update VITE_I18N_DEBUG in .env files * chore: Update environment variables for beta and production environments * chore: Add beta branch to GitHub Actions deploy workflow * Hardcoded Pokemon should have proper names (#2941) * Refactor challenges and add fresh start (#2963) * [Balance] Update many TM learnsets (#2879) * Update TMs for more Indigo Disk changes * Fix typo, more Stored Power * Refactor challenges and add fresh start (#2964) * Refactor challenges and add fresh start * Add achievement for fresh start challenge * [Bug] Fix off-by-one error in damage calc (#2970) * Fix random damage roll to be 85-100% instead of 85-99% * Update battle.test.ts to reflect the fix * [Bug] Grounded on Terrain fixes (#2969) * [Help] [Move/Bug] Patches Psychic Terrain applicability edge cases Was cancelling moves even if targeted mons weren't on the terrain. * [Bug `]Pokemon.isGrounded` does not exist Replaced with `Pokemon.isGrounded()`, which does. * [Bug] Psychic Terrain priority move cancel ignoring ungrounded * [Bug] Semi-invulnerable should not be grounded * Update game-stats-ui-handler.ts (italian) (#2965) * [Bugfix] Fix a bug during bgm-bar initialization (#2822) * Prevent sizing error * Make reboot not necessary for show BGM * Makes the BGM Bar active by default + It had originally been decided that this would not be active by default because it was to be displayed outside the pause menu, but since its behavior has changed between this decision and its integration, the default deactivation is no longer necessary * [Mirror][Localization] Translate game victory sentences #2254 (#2906) * Translate forgotten sentences on phases * Translate to de forgotten sentences on phases * Translate to es forgotten sentences on phases * Translate to fr forgotten sentences on phases * Translate to it forgotten sentences on phases * Translate to ko forgotten sentences on phases * Translate to pt br forgotten sentences on phases * Translate to zh cn forgotten sentences on phases * Translate to zh tw forgotten sentences on phases * remove duplicate message * remove duplicate message * Update src/locales/pt_BR/battle.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/de/battle.ts Co-authored-by: Jannik Tappert <[email protected]> * Update src/locales/de/battle.ts Co-authored-by: Jannik Tappert <[email protected]> * Update battle.ts [Localization(it)] * Update src/locales/zh_CN/battle.ts Co-authored-by: Yonmaru40 <[email protected]> --------- Co-authored-by: Alexis <[email protected]> Co-authored-by: 송지원 <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: Jannik Tappert <[email protected]> Co-authored-by: Niccolò <[email protected]> Co-authored-by: Yonmaru40 <[email protected]> * [Mirror][Localization] Translate summary #2336 (#2907) * Translate pokemon summary * Translate pokemon summary to fr * Translate pokemon summary to de * Translate pokemon summary to es * Translate pokemon summary to it * Translate pokemon summary to ko * Translate pokemon summary to pt br * Translate pokemon summary to zh cn * Translate pokemon summary to zh tw * Fix import * Update partially for en and ko * Update interface name for en * Merge trainerLabel&Text and calculate typeLabel width * Update src/locales/es/pokemon-summary.ts Co-authored-by: GoldTra <[email protected]> * Apply translations key to all languages with interface TranslationEtries * Update ko/translationKey of status * Update ko/translationKey of pokemonInfo * Update de/translationKeys of memostring and metFragment * Update de/translationKeys of memostring and metFragment 2 * Update src/locales/ko/pokemon-summary.ts Co-authored-by: Enoch <[email protected]> * Update src/locales/ko/pokemon-summary.ts Co-authored-by: returntoice <[email protected]> * Update src/locales/pt_BR/pokemon-summary.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/ko/pokemon-summary.ts * Update src/locales/pt_BR/pokemon-summary.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update pokemon-summary.ts [Localization(it)] * remove unused code * Update src/locales/zh_CN/pokemon-summary.ts Co-authored-by: Yonmaru40 <[email protected]> * Update src/locales/zh_CN/pokemon-summary.ts Co-authored-by: Yonmaru40 <[email protected]> * Update src/locales/zh_CN/pokemon-summary.ts Co-authored-by: Yonmaru40 <[email protected]> * Update src/locales/es/pokemon-summary.ts Co-authored-by: Arxxer <[email protected]> * Update src/locales/es/pokemon-summary.ts Co-authored-by: Arxxer <[email protected]> --------- Co-authored-by: Alexis <[email protected]> Co-authored-by: Mr.WaterT <[email protected]> Co-authored-by: Alexis Faizeau <[email protected]> Co-authored-by: GoldTra <[email protected]> Co-authored-by: returntoice <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: 송지원 <[email protected]> Co-authored-by: Niccolò <[email protected]> Co-authored-by: Yonmaru40 <[email protected]> Co-authored-by: Arxxer <[email protected]> * [Localization] Localization arena flyout (Active Battle Effects) (#2932) * localizing Active Battle Effects (working) * Localize Active Battle Effects * Change return value * Modify arena terrain desc * Update src/locales/zh_CN/arena-flyout.ts Co-authored-by: Yonmaru40 <[email protected]> * Update src/locales/de/arena-flyout.ts Co-authored-by: Jannik Tappert <[email protected]> * Update src/locales/fr/arena-flyout.ts Co-authored-by: Lugiad' <[email protected]> * Update arena-flyout.ts (IT) * Update src/locales/pt_BR/arena-flyout.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/es/arena-flyout.ts Co-authored-by: Arxxer <[email protected]> * Change util function name --------- Co-authored-by: 송지원 <[email protected]> Co-authored-by: Yonmaru40 <[email protected]> Co-authored-by: Jannik Tappert <[email protected]> Co-authored-by: Lugiad' <[email protected]> Co-authored-by: Niccolò <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: Arxxer <[email protected]> * This should prevent gym leaders appear as doubles (marnie & piers) when they arent fixed battles (#2904) * The stat messages can now be plural (#2600) * The stat messages are now plural * "And" can now be localized * Revert Override * Update src/locales/fr/battle.ts Co-authored-by: Lugiad' <[email protected]> * Update src/locales/fr/battle.ts Co-authored-by: Lugiad' <[email protected]> * Update src/locales/fr/battle.ts Co-authored-by: Lugiad' <[email protected]> * Update src/locales/zh_CN/battle.ts Co-authored-by: Yonmaru40 <[email protected]> * Update src/locales/ko/battle.ts Co-authored-by: Enoch <[email protected]> * Update src/locales/ko/battle.ts Co-authored-by: Enoch <[email protected]> * Update src/locales/es/battle.ts Co-authored-by: GoldTra <[email protected]> * Update src/locales/es/battle.ts Co-authored-by: GoldTra <[email protected]> * Update src/locales/de/battle.ts * Update src/locales/pt_BR/battle.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/pt_BR/battle.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/data/battle-stat.ts * Update src/locales/zh_CN/battle.ts Co-authored-by: Yonmaru40 <[email protected]> * Changed the way the multiple is handeled to use the i18n way * Missed one file * Apply suggestions from code review * Apply suggestions from code review * Changed the tests so they work now with the i18n hting * Fixed some other tests (chinese still makes problems... * Fix tests for chinese * Tests * Update src/test/battle-stat.spec.ts * Update src/locales/zh_CN/battle.ts Co-authored-by: Yonmaru40 <[email protected]> * Apply suggestions from code review --------- Co-authored-by: Lugiad' <[email protected]> Co-authored-by: Yonmaru40 <[email protected]> Co-authored-by: Enoch <[email protected]> Co-authored-by: GoldTra <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * [Enhancement][QoL] Add option to adjust shop overlay opacity (#2622) * add option to adjust shop overlay opacity * add localization * fix bug * Update src/locales/fr/settings.ts Co-authored-by: Lugiad' <[email protected]> * Update src/locales/zh_CN/settings.ts Co-authored-by: Yonmaru40 <[email protected]> * Update src/locales/fr/settings.ts Co-authored-by: Lugiad' <[email protected]> * update default value * update setting values * re-add value 10 * Update src/locales/pt_BR/settings.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/ko/settings.ts Co-authored-by: Enoch <[email protected]> * Update src/locales/es/settings.ts Co-authored-by: InnocentGameDev <[email protected]> * Update settings.ts --------- Co-authored-by: Lugiad' <[email protected]> Co-authored-by: Yonmaru40 <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: Enoch <[email protected]> Co-authored-by: InnocentGameDev <[email protected]> Co-authored-by: Niccolò <[email protected]> * [Bug] Fix battler tags lapsing at incorrect times (#2944) * Fix battler tags lapsing at incorrect times * Document FlinchedTag * Update French pokemon-summary.ts (#2976) * [Test] Prevent tests from running if overrides are different from the default values (#2110) * mock default overrides in test setup * change beforeEach to beforeALl * move some more enums into the enums directory * replace modules that import i18n into overrides with modules that don't * add pre tests and update vitest configs, scripts * replace tabs with spaces * fix vitest server port overlap warning * add missing overrides and clean up workspace config * change test name * include spec files in main test suite * [QoL] Highlight targets of multitarget moves instead of immediate execution (#2863) * show targets for move targeting multiple pokemon * dont allow selecting target if multiple * fix targeting * cleanup * more cleanup * only highlight targets is move is not status * fix tests failing * fix tests * change "immediately" to "auto" * nevermind just remove auto * remove status move condition * [Refactor] rewrite applyAbAttrsInternal to use an iterator. (#1832) * initial rewrite of applyAbAttrsInternal * clean up applyAbAttrsInternal * remove the await because it wraps non Promises in a promise * add TODO comment about promises * fix broken costar test, hopefully * Update typescript and typedoc (#2988) * update typescript and typedoc to latest versions * forgot to add the package-lock * add fixes for breaking type gen * update workflow (#2989) * [Qol/Balance] Dynamax cannon tweak (#2540) * Dynamax Cannon fix * Update src/locales/fr/move.ts Added fr translation. Co-authored-by: Lugiad' <[email protected]> * Update src/locales/fr/move.ts Adding an important missing precision in French description Co-authored-by: Lugiad' <[email protected]> * Update src/locales/de/move.ts German locale commit. Co-authored-by: Jannik Tappert <[email protected]> * Update src/locales/zh_CN/move.ts Chinese locale commit, checked by a native speaker Co-authored-by: Lugiad' <[email protected]> * Update src/locales/ko/move.ts Korean locale added Co-authored-by: returntoice <[email protected]> * fixed trailing space in Chinese locale * added es locale * Different Dynamax Cannon fix. This one is the one * Dynamax Cannon fix localisations * Update src/locales/fr/move.ts Added fr locale Co-authored-by: Lugiad' <[email protected]> * Update src/locales/de/move.ts German translation ^^ Co-authored-by: Jannik Tappert <[email protected]> * Update src/locales/pt_BR/move.ts pt-BR translation Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/de/move.ts Eslint fix, good catch @Enoch Co-authored-by: Enoch <[email protected]> * Update src/locales/ko/move.ts Korean locale ^^ Co-authored-by: sodam <[email protected]> * Update src/locales/zh_CN/move.ts zh_CN locale Co-authored-by: RimKnight <[email protected]> * Update src/locales/zh_TW/move.ts zh_TW locale Co-authored-by: RimKnight <[email protected]> * Update move.ts linting mistake due to how my comment was written * Update move.ts linting mistake due to how my comment was written * Update move.ts [Localization(it)] * WIP test * WIP test part 2 * [Test] Add Unit Tests for Dynamax Cannon * removed some unnecessary cases in the test to reduce testing overhead * Update src/locales/ko/move.ts Updated kr locale Co-authored-by: Enoch <[email protected]> * [Test] Adjust Unit Tests for Dynamax Cannon --------- Co-authored-by: Lugiad' <[email protected]> Co-authored-by: Jannik Tappert <[email protected]> Co-authored-by: returntoice <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: Enoch <[email protected]> Co-authored-by: sodam <[email protected]> Co-authored-by: RimKnight <[email protected]> Co-authored-by: Niccolò <[email protected]> Co-authored-by: xsn34kzx <[email protected]> * [Test] Fix/Extend Unit Test for Hard Press (#2992) * [Test] Update tests to enable no-crits override (#2971) * Update tests to enable no-crits override * Rename variable maxHP to initialHP * [Localization]Localized move-trigger text (#2913) * [Localization]Localized move-trigger text * [Localization]Localized zh-cn move-trigger text * [Localization]fix typo * [Localization]fix typo * Update src/locales/pt_BR/move-trigger.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * [Localization]add pokemonName to move-trigger.ts * [Localization]add pokemonName to move-trigger.ts * Update zh_TW move-trigger.ts * Update zh_CN move-trigger.ts * Update move.ts * Update src/locales/ko/move-trigger.ts Co-authored-by: Enoch <[email protected]> * Update src/locales/ko/move-trigger.ts Co-authored-by: Enoch <[email protected]> * Update move-trigger.ts * Update src/locales/de/move-trigger.ts Co-authored-by: Jannik Tappert <[email protected]> * [Localization]add affix to target pokemon names * Update src/locales/fr/move-trigger.ts Co-authored-by: Lugiad' <[email protected]> * localized type --------- Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: Enoch <[email protected]> Co-authored-by: Jannik Tappert <[email protected]> Co-authored-by: Lugiad' <[email protected]> * [Bug] Fix description of rare candy to have proper amount of level (#2903) * [Bug] Fix description of rare candy to have proper amount of level * Update en locales * Add locales * Add locales * Update src/locales/de/modifier-type.ts Co-authored-by: Jannik Tappert <[email protected]> * Update src/locales/de/modifier-type.ts Co-authored-by: Jannik Tappert <[email protected]> * Update src/locales/fr/modifier-type.ts Co-authored-by: Lugiad' <[email protected]> * Update src/locales/fr/modifier-type.ts Co-authored-by: Lugiad' <[email protected]> * Update src/locales/ko/modifier-type.ts Co-authored-by: Enoch <[email protected]> * Update src/locales/ko/modifier-type.ts Co-authored-by: Enoch <[email protected]> * Update src/locales/zh_CN/modifier-type.ts Co-authored-by: Yonmaru40 <[email protected]> * Update src/locales/zh_CN/modifier-type.ts Co-authored-by: Yonmaru40 <[email protected]> * Update src/locales/pt_BR/modifier-type.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/pt_BR/modifier-type.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update modifier-type.ts (IT) * Update src/locales/es/modifier-type.ts Co-authored-by: Arxxer <[email protected]> * Update src/locales/es/modifier-type.ts Co-authored-by: Arxxer <[email protected]> --------- Co-authored-by: Jannik Tappert <[email protected]> Co-authored-by: Lugiad' <[email protected]> Co-authored-by: Enoch <[email protected]> Co-authored-by: Yonmaru40 <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: Niccolò <[email protected]> Co-authored-by: Arxxer <[email protected]> * move status effect enum into separate file (#2998) * add .env.test (#2997) block i18n debug output by default * [QoL] Create default overrides class and export that with custom overrides (#2999) * Create default overrides class and export that with custom overrides * add comment to mock import and replace typecast with type narrowing * change modifier override type to pick keys from modifierTypes * [Feature][FUN] add breedersInSpace splash message (#2631) * add spaceBreeder splash message * fix typo (whops) * Add pt_BR translation Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * replace text & key with breedersInSpace * add french tanslation Co-authored-by: Lugiad' <[email protected]> * remove obsolete array split in splash-messages.ts * Update src/locales/pt_BR/splash-messages.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/es/splash-messages.ts Co-authored-by: Asdar <[email protected]> * Update splash-messages.ts (Italian) * Update src/locales/zh_CN/splash-messages.ts Co-authored-by: Yonmaru40 <[email protected]> * Update src/locales/ko/splash-messages.ts Co-authored-by: sodam <[email protected]> --------- Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: Lugiad' <[email protected]> Co-authored-by: Asdar <[email protected]> Co-authored-by: Niccolò <[email protected]> Co-authored-by: Yonmaru40 <[email protected]> Co-authored-by: sodam <[email protected]> * [Enhancement] Pokemon generation number tooltip (#2642) * Create tooltip to show Pokemon generation * Add option to toggle generation tooltip * Use roman numeral for generation tooltip * Revert "Add option to toggle generation tooltip" This reverts commit 414b2366fc55c5642f8858d6f4854aa62c4caf60. * Update src/locales/de/battle-info.ts Co-authored-by: Jannik Tappert <[email protected]> * Update src/locales/fr/battle-info.ts Co-authored-by: Lugiad' <[email protected]> * Update src/locales/pt_BR/battle-info.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/zh_TW/battle-info.ts Co-authored-by: RimKnight <[email protected]> * Update src/locales/zh_CN/battle-info.ts Co-authored-by: RimKnight <[email protected]> * Update src/locales/ko/battle-info.ts Co-authored-by: Enoch <[email protected]> * Update battle-info.ts (IT) --------- Co-authored-by: Jannik Tappert <[email protected]> Co-authored-by: Lugiad' <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: RimKnight <[email protected]> Co-authored-by: Enoch <[email protected]> Co-authored-by: Niccolò <[email protected]> * [Beta] Updating the manage data->unlock all option to work with all abilities, natures, forms and passives (#2967) * Updated code to allow user to unlock all pokemon from the manage data menu option * Added code to Utils to allow it to check for a beta env, and hid the unlock all code behind that. This should stop it from being accessed in prod envs * Updated another section to be locked behind beta check, and also updated the everything.prsv to have everything unlocked going forward * Fixed some code reviews * [Bug] vite port (for development) (#3003) * make vite-port configurable and make it default 8000 * add retries for `does not trigger by non damage moves` test * feat: Update isBeta check in utils.ts to use import.meta.env.MODE The current implementation of the isBeta check in utils.ts is using import.meta.env.DEV, which gives the same value for both beta and dev environments. This commit updates the check to use import.meta.env.MODE === "beta" to accurately determine if the environment is beta. This ensures that the unlock all code is only accessible in the beta environment and not in production environments. * refactor: Update trainerId and secretId in game data This commit updates the `trainerId` and `secretId` properties in the `GameData` class. The values are replaced with the corresponding values from the `this.trainerId` and `this.secretId` variables. This change ensures that the `trainerId` and `secretId` are correctly updated in the game data. * Adds bg glow behind starters with unlocked passives (#2497) * [Localization] Localize missed things in battlers-tag.ts (#3004) * Localize missed things in battlers-tag * Change orders of configs * Add missed phase * Update src/locales/zh_CN/battle.ts Co-authored-by: RimKnight <[email protected]> * Update src/locales/zh_CN/battle.ts Co-authored-by: RimKnight <[email protected]> * Update src/locales/zh_TW/battle.ts Co-authored-by: RimKnight <[email protected]> * Update src/locales/zh_TW/battle.ts Co-authored-by: RimKnight <[email protected]> * Update src/locales/zh_TW/battler-tags.ts Co-authored-by: RimKnight <[email protected]> * Update src/locales/zh_CN/battler-tags.ts Co-authored-by: RimKnight <[email protected]> --------- Co-authored-by: RimKnight <[email protected]> * [Feature] Fully implement Octolock (#2985) * implement octolock * Add tests * Add localization of arena tag (TODO : config add) * [Bug] Fix import of overrides in a test (#3009) * [BUG] Fixes Sketch copying the first move used by the opponent instead of the last (#2759) * Changes getMoveHistory to getLastXMoves to fix sketch copying first move used instead of last * Optimizes move search and early return * Reverts check for virtual moves * [Bug] Making FormChangeItems Untransferrable (#2695) * Made FormChangeItems untransferrable. Replaced getTransferrable() * Made isTransferrable readonly. Removed unnecessary 'm as PokemonHeldItemModifier'. * [Bug] Fix Clear terrains upon Trainer Battle (#2027) * Clear terrains upon Trainer Battle * Adjusted comment * Fix item reward overrides going out of bounds (#3012) * [Localization] Localize Berry Heal message (#2996) * Localize berry heal message (HP/PP) * Change location of translation * conflict resolve * Update src/locales/de/battle.ts Co-authored-by: Jannik Tappert <[email protected]> Update src/locales/de/battle.ts Co-authored-by: Jannik Tappert <[email protected]> Update src/locales/de/battle.ts Co-authored-by: Jannik Tappert <[email protected]> * Update src/locales/zh_CN/battle.ts Co-authored-by: mercurius-00 <[email protected]> * Update src/locales/zh_TW/battle.ts Co-authored-by: mercurius-00 <[email protected]> * Update src/locales/fr/battle.ts Co-authored-by: Lugiad' <[email protected]> * Update src/locales/pt_BR/battle.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/pt_BR/battle.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update battle.ts (Berries ITALIAN) --------- Co-authored-by: 송지원 <[email protected]> Co-authored-by: Jannik Tappert <[email protected]> Co-authored-by: mercurius-00 <[email protected]> Co-authored-by: Lugiad' <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: Niccolò <[email protected]> * Adds a check to the bgm-bar display to prevent it from being displayed in case of an empty value (#3007) * Update src/locales/fr/arena-tag.ts Co-authored-by: Lugiad' <[email protected]> * Update src/locales/de/arena-tag.ts Co-authored-by: Jannik Tappert <[email protected]> * [Sprite] Improves Corviknight Palette usage (#3020) * [Sprite] Compress Corviknight exp * [Sprite] Compress Corviknight exp * [Sprite] Compress Corviknight exp * [Sprite] Compress Corviknight exp * [Sprite] Compress Corviknight exp * [Beta][Localization] Update French battler-tags.ts and battle.ts (#3015) * Update French battler-tags.ts * Update battle.ts * [Bug] Fix Lock-On and Mind Reader not working on the first turn (#3001) * [Bug] Struggle Recoil should ignore Magic Guard (#3017) * Drafted testable conditions for Magic Guard * Weather Test * Update src/test/abilities/magic_guard.test.ts InnerThunder Co-authored-by: innerthunder <[email protected]> * Implemented checks for poison/toxic/burn * Added tests for recoil moves and volatile status * Updated Rock Head, Magic Guard, and Reckless interactions with Struggle * Removed stray file * Fixed Typedoc errors * Implemented innerthunder's feedback --------- Co-authored-by: Frutescens <info@laptop> Co-authored-by: innerthunder <[email protected]> * [Enhancement] Decouple move power calculation from Pokemon.apply(), Fixes Power Spot & Battery not boosting ally's move (#2984) * refactor power calc, fix battery & power spot * fix hard press unit test * fix hard press * refactor tests * use sypOn hp instead * rename method * cleanup tests * improve tests * use slow vs fast pokemon * fix steely spirit test * fix steely spirit for real this time * remove unnecessary test * address pr feedback * add removed code * [QoL] Offset the status indicator to keep pokeball in view (#2966) * Offset the status indicator to keep pokeball in view * Only use offsetX when the Pokemon is the enemy * Adjust position to accomodate boss health bar * [Bug] Fix to epic shiny Yungoos icon (#2991) (#3016) Fixed a floating pixel in epic shiny Yungoos' icon. Caused by Mimikyu's epic shiny sprite being placed too high on the sprite sheet. Moved Mimikyu's sprite down and updated json to reflect the change. * [Localization(ko)] Change line-break position of ghost type curse add message (#3022) * Update src/locales/de/arena-tag.ts Co-authored-by: Jannik Tappert <[email protected]> * Revert "[Localization]Localized move-trigger text (#2913)" (#3026) This reverts commit 39bdfea0c8b33a759db760809d6488d825b510e2. * [Localization(ko)] Fixed typo in Bertha's dialogue (#3025) * [Bug] Prevent fixed-damage and OHKO moves from being modified by damage-reducing abilities (#2703) * ReceivedMoveDamageMultiplierAbAttr patch: WIP refactored damage calculation, reordered ReceivedMoveDamageMultiplierAbAttr to avoid issues with fixed damage and OHKO moves, stubbed unit tests for dragon rage (fixed damage) and fissure (OHKO) * ReceivedMoveDamageMultiplierAbAttr patch: commented concerns regarding EnemyDamageBooster/ReducerModifier for others' reference in WIP branch * ReceivedMoveDamageMultiplierAbAttr patch: reordered ReceivedMoveDamageMultiplierAbAttr and EnemyDamageBooster/ReducerModifier to not trigger for fixed damage and OHKO moves, completed relevant tests for dragon rage and fissure * ReceivedMoveDamageMultiplierAbAttr patch: removed newline * ReceivedMoveDamageMultiplierAbAttr patch: in the unit test, extracted hard-coded Dragon Rage damage to a variable * ReceivedMoveDamageMultiplierAbAttr patch: naming consistency * ReceivedMoveDamageMultiplierAbAttr patch: replaced awaiting DamagePhase with TurnEndPhase as the former assumes damage will be done * ReceivedMoveDamageMultiplierAbAttr patch: removed redundant overrides in Fissure tests * ReceivedMoveDamageMultiplierAbAttr patch: tests: refactored crit removal, removed berries, fixed bug associated with Porygon sometimes getting Trace and copying the opponent's ability, which would override the manual ability override * Fixed unit tests * Added a comment and cleaned up an existing one * Update src/locales/zh_CN/arena-tag.ts Co-authored-by: Yonmaru40 <[email protected]> * [Localization] Brought german localization up to date (#3010) * Fixed errors in the german localization * Fresh Start Challenge * Update src/locales/de/move-trigger.ts Co-authored-by: flx-sta <[email protected]> * Apply suggestions from code review --------- Co-authored-by: flx-sta <[email protected]> * [Bug] Remove redundant damage number popups (#3024) * Remove magic number from Belly Drum's attr * Remove redundant damage number popup * Fix merge issue and remove another duplicate damage number instance * [Move] Implements Conversion 2 (#2943) * Creates function to get type resistances, implements conversion 2 * Removes unimplemented tag, adds condition for move history to exist * Cleans up type selection, creates i18n entries for typeChanged * Uses typeChanged i18n in Conversion move * More detailed docs, early return with stellar/unknown type * Adds note that it wont track type-changing moves properly * Rephrases doc description, adds partial since it can't track type-changing moves * Updates localization, removes typeChanged entry to use move-trigger entry * Missed locale de entry in last commit * Adds comment for reason of .partial() * Fixes localization error due to revert, removes improper merge conflict from prior commit * [BUG] Fixes bug with Metronome freezing the game (#2819) * Tests MovePhase with new PokemonMove instead of moveset search * Accounts for metronome call on charging moves * Update comment in ChargeAttr to be clearer * Add missing passive background graphic for legacy UI Relating to #2497 , this adds an identical graphic to the legacy UI files, as it will show up as a missing texture otherwise. * [Localization] Localize ability messages in ability.ts (trigger, apply...) (#2972) * localize ability messages * Update src/locales/de/ability-trigger.ts Co-authored-by: Jannik Tappert <[email protected]> * Modify parameter name, fix eslint * Korean Translation, modify some wrong param * Add missed message * Update src/locales/de/ability-trigger.ts Co-authored-by: Jannik Tappert <[email protected]> * Update ability-trigger.ts (Partial) (Italian) * Localize type name * Localize type name > Libero, Protean * param bug fix * Update src/data/ability.ts * Update zh-cn * Update ability-trigger.ts (Partial part 2, still not completed) (Italian) * Update src/locales/fr/ability-trigger.ts Co-authored-by: Lugiad' <[email protected]> * Update src/locales/pt_BR/ability-trigger.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/fr/ability-trigger.ts Co-authored-by: Lugiad' <[email protected]> --------- Co-authored-by: 송지원 <[email protected]> Co-authored-by: Jannik Tappert <[email protected]> Co-authored-by: Niccolò <[email protected]> Co-authored-by: Lugiad' <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update egg.ts (italian) (#3038) * [Sprite] Revert Larvesta, fixing stray pixels (#3042) * [Sprite] Remove normal Larvesta stray pixels Taken from original commit * [Sprite] Revert shiny Larvesta stray pixels Taken from original commit * [Sprite] Match variant Larvesta colours * [Bug] Fix level 100 moves being skipped if leveled past 100 (#3040) * [Bug][Fix][Surf][Muddy Water][Sludge Wave][Animation] Added image to move animations. (#3044) * Update muddy-water.json * Update sludge-wave.json * Update surf.json * [Sprite] Fix Cofagrigus sprite (#3045) * Fix Cofagrigus sprite * Base sprite fix * Created json variant file... manually * Fix FR typo (#3051) * [Beta][Localization] Update Portuguese battler-tags.ts and battle.ts (#3050) * [Music/BGM] Fix bgm file & loop for battle_rival (#3053) * stop loading pride-update banner (#3057) * [Item] Add Scope Lens and Leek (#2666) * [Item] Add Scope Lens and Leek * Add Entry to pt_BR * Localize for pt_BR Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Fix & Clean Unit Tests --------- Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * [Music/BGM] New music added for the "Slum" biome, composed by Andr06 (#3000) * Replacement of the BGM in the slum biome (by Andr06) * Modification of BGM credits in README.md * Replacement of the BGM name by the title chosen by its composer in all languages * Update BGM loop point for biome 'SLUM' * [Bug] implemented multi target damage penalty (#2329) * fix: damage multiplier by the number of targets * fix: used actual number value rather than the number holder * test: added unit test for counting targets * multi-target: fixed names of the unit tests. * test: simple-test changes * test: changed multi-target test code * test: testing damage decreasement * test: multi-target test fix * resolved conflicts in test --------- Co-authored-by: Tempoanon <[email protected]> * [BUG] Uturn faint switch bug fix (#2980) * reordering adding switch phases for u-turn * reverting some temp changes * generalizing function * adding PR suggestions * nit indenting * [Sprite] Remove extra Oinkologne sprites (#3067) * Delete public/images/pokemon/female/916.png * Delete public/images/pokemon/exp/female/916.json * Delete public/images/pokemon/exp/female/916.png * Delete public/images/pokemon/female/916.json * [Sprite] Mega Mewtwo sprite fixes (#3065) * [Sprite] Add static epic Mega Mewtwo Y Colours taken from exp, as consistent/exp rare backs share palettes. * [Sprite] Fix transparent pixels on Mega Mewtwo X * [Sprite] Fix transparent pixels on Mega Mewtwo X * [Sprite] Add static epic Mega Mewtwo Y Now exists, and is a paletteswap * [Music/BGM] New music added for the "Sea" biome, composed by Andr06 (#3063) * Replacement of the BGM in the sea biome (by Andr06) * Modification of BGM credits in README.md * Replacement of the BGM name by the title chosen by its composer in all languages * Update BGM loop point for biome 'SEA' * [Balance] Add 12 new TMs and remove 3 (#2733) * Added Counter TM * Counter, Aqua Tail, Gastro Acid, Pluck, Secret Power, Aurora Veil, Incinerate * Placed TMs in proper order, added to pool * Add Secret Power to the pool * Add TM for Synthesis * Covet, Heal Bell, PUPunch, Recycle, Volt Tackle, Worry Seed * Remove species specific TMs * Remove Secret Power TM until implementation * [Refactor/Test] Update Dynamax Cannon Unit Tests (#3074) * [Refactor/Test] Update Dynamax Cannon Unit Tests * Adjust Test Names * fix: update SameSite attribute in setCookie function to None * fix: update SameSite attribute in setCookie function to Strict * feat: Add prompt=none to Discord OAuth authorization URL * fix: Remove unnecessary cookie setting in LoginPhase and MenuUiHandler * feat: Improve cookie handling in getCookie function * feat: Delete duplicate cookies with the same name in getCookie function * [Localization] Add minor Korean translations to ability-trigger file (trace) (#3093) * modify trace trigger description (refered from official translation) modify trace trigger description (refered from official translation) * modify trace trigger description (refered from official translation) modify trace trigger description (refered from official translation) * Fix broken `multi_target` tests and remove RNG-based failures (#3095) * Prevent RNG from breaking the Quick Draw tests (#3096) * Make EXP boosting items stack additively and not multiplicatively (#3094) Fixes #2040 * [Bug] Fixes Encore bug with multi-target moves missing (#3060) * Pushes move history even when multi target move misses * Move pushMoveHistory out of Move Pending condition * Add remaining relearn moves (#2894) * [Enhancement] Decouple move accuracy and accuracy multiplier calculation from phases.ts (#2899) * refactor accuracy calc * update doc * move accuracy multiplier calculation outside phases * update wonder skin unit test * rename method * add docs * add unit tests * address feedback * rename method * fix imports * improve tests * add test for ohko move accuracy * [Sprite] Fix a number of sprite issues including the Zubat line, Goldeen, Golett, Dudunsparce, H-Sneasel, Garchomp, Sylveon, Marshadow (#3069) * Batfix, Goldeen, Chomp, Golett, genies * Fix Dudunsparce using Reborn shiny backsprite for whatever reason * Fix female Hisuian Sneasel missing variants * Marshadow epic front and Zenith, Sylveon back * Fix Zubat line back sprite inconsistencies * Fix Noivern shiny back * [Move] Finish implementation of Glaive Rush (#2720) * Finish implementation of Glaive Rush * Fix test RNG * Add code/test for Multi-Lens interaction * Fix off-by-one error in test caused by rounding issues * Update for code changes * Fix BattlerTag name * [Bug] fix not changing moveset after add to starter #1932 (#2396) * [Bug] Enemies can properly use stuff cheeks (#3090) * [Feature] Added pokemon nicknames/renaming (#2570) * Added basic temp renaming * Made nickname persistant after reloading * Localization and cancel button * Fixed instant rename on active pokemon * Small bugfix to prevent console errors * Changed logic to use the new nickname field. Replaced most .name with getNameToRender() for display. * Changed evolution message. Removed log messagesc * Added localization keys for other languages * Removed empty lines * French translation Co-authored-by: Lugiad' <[email protected]> * Chinese translation Co-authored-by: Yonmaru40 <[email protected]> * Portuguese (Brazil) translation Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Korean translation Co-authored-by: Enoch <[email protected]> * Update menu.ts * Update menu.ts [Localization(it)] * Changed most .getNameToRender() instance to getPokemonNameWithAffix() * Changed wild encounter messages back to just use the name without affix. * Added localization for the party ui rename selection * Escaping nickname characters to support all characters * Better Error handling * Update src/field/pokemon.ts Co-authored-by: flx-sta <[email protected]> --------- Co-authored-by: Lugiad' <[email protected]> Co-authored-by: Yonmaru40 <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: Enoch <[email protected]> Co-authored-by: Niccolò <[email protected]> Co-authored-by: flx-sta <[email protected]> * [Sprite] Show Partner Eevee variants (#3097) * [Sprite] Show Partner Eevee variants Taken from non-partner Eevee * [Sprite] Show Partner Eevee variants Taken from non-partner Eevee * [Sprite] Show Partner Eevee variants * Allow Necrozma forms to play their special music (#3054) * [BUG] fixing multi-hit and move messages on faint (#2981) * fixing order of messages, scences, to render messages before fainting * updated fix for effectiveness text rendering order for multi hit moves * fixing messages not appearing for multi-hit moves on faint * updated multi-hit condition) * fixing PR conflicts * adding comments and FaintPhase setPhaseQueueSplice bug, fixing overrides merge conflict * writing better comments * removing space diff in overrides * adding fainting check for self damage moves * emergency fixing broken last commit * additional comments for multi-hit problem * updating comments, jsdoc style * fixing linter, destiny bond errors * splitting up varaible comments to be in JSDoc format * fixing tests and merge mistakes * adding rendering of multihit moves that only hit once * fixing comment formatting_tabs and spaces --------- Co-authored-by: Benjamin Odom <[email protected]> * [Bug] Sheer Force/Serene Grace Flyout Bugfix (#2496) * Disable Show Ability for Serene Grace and Sheer Force when opponent calculates targetBenefitScore * Add comment and definition to argument * [Visual] Achievement icons (#2617) * Text Changes to MonoGen Challenges * Item Texture Files * MonoGen Ribbons added * Resolving merge conflict * Updated texture files? I think * Changed image names and added new localizations for syntax * Removed unused ribbons * [Feature] replace bug-report template with form (#2772) * replace bug-report template with form * update bug_report.yml * add palceholders for data & session file * Update item atlas * Update item atlas again This time, after merging main into the PR. * [Sprite] Show Partner Eevee variants (#3097) * [Sprite] Show Partner Eevee variants Taken from non-partner Eevee * [Sprite] Show Partner Eevee variants Taken from non-partner Eevee * [Sprite] Show Partner Eevee variants * Merged with beta's new items * Fixed typedoc issues * Removing localizations * Text Changes to MonoGen Challenges * Item Texture Files * MonoGen Ribbons added * Resolving merge conflict * Updated texture files? I think * Changed image names and added new localizations for syntax * Removed unused ribbons * Update item atlas * [Feature] replace bug-report template with form (#2772) * replace bug-report template with form * update bug_report.yml * add palceholders for data & session file * Update item atlas again This time, after merging main into the PR. * Merged with beta's new items * Fixed typedoc issues * Removing localizations * Allow Necrozma forms to play their special music (#3054) * Allow Necrozma forms to play their special music (#3054) * MonoGen Ribbons added * Text Changes to MonoGen Challenges * Item Texture Files * MonoGen Ribbons added * Updated texture files? I think * Changed image names and added new localizations for syntax * Fixed typedoc issues * Revert "Text Changes to MonoGen Challenges" This reverts commit 3bf79acc6a797b0e28e68e113e644b30096ea9ce. * Text Changes to MonoGen Challenges * Item Texture Files * MonoGen Ribbons added * Resolving merge conflict * Updated texture files? I think * Changed image names and added new localizations for syntax * Removed unused ribbons * Update item atlas * [Feature] replace bug-report template with form (#2772) * replace bug-report template with form * update bug_report.yml * add palceholders for data & session file * Update item atlas again This time, after merging main into the PR. * Merged with beta's new items * Fixed typedoc issues * Removing localizations * Text Changes to MonoGen Challenges * Item Texture Files * MonoGen Ribbons added * Resolving merge conflict * Updated texture files? I think * Changed image names and added new localizations for syntax * Removed unused ribbons * Update item atlas * Update item atlas again This time, after merging main into the PR. * Merged with beta's new items * Fixed typedoc issues * Removing localizations * MonoGen Ribbons added * Text Changes to MonoGen Challenges * Item Texture Files * MonoGen Ribbons added * Updated texture files? I think * Changed image names and added new localizations for syntax * Fixed typedoc issues * Revert "Text Changes to MonoGen Challenges" This reverts commit 3bf79acc6a797b0e28e68e113e644b30096ea9ce. * Please fix this. * Revert "[Feature] replace bug-report template with form (#2772)" This reverts commit aa69b107778123b2173bee6130e5d172d201b637. --------- Co-authored-by: Frutescens <info@laptop> Co-authored-by: flx-sta <[email protected]> Co-authored-by: Madmadness65 <[email protected]> Co-authored-by: chaosgrimmon <[email protected]> Co-authored-by: Madmadness65 <[email protected]> * Re-add changes accidentally deleted by #2617 * Fix some broken images in item atlas & achievement Fixed the broken sprites in the item atlas, and fixed the Baton Pass achievement to use the Baton item now (it was broken by the Leek being renamed). Also resized the Baton item image to 32*32, like all the other items. * fix: Remove unnecessary cookie setting in removeCookie function * fix: Update removeCookie function to use Max-Age=-1 instead of Expires header The removeCookie function was updated to use the Max-Age=-1 attribute instead of setting the Expires header to a past date. This change ensures that the cookie is immediately expired when removed, preventing any potential login loops. Additionally, a legacy cookie without a domain was added to handle older cookies. This commit resolves the unnecessary cookie setting in the removeCookie function. * [QoL] Starter UI selection update to allow removing specific pokemon from party (#1983) * Initial commits with logic to remove starters if they're in your party. Still need to make it work so that the starter selection cursor disappears when a starter is unselected * Updated code to be able to remove pokemon, including the side icons and cursor locations * Fixed popstarter to work with any index * Updating code to allow navigation of starter icons * Updating code to allow navigation of party starter icons * Updaing navigation of party icons * Updated logic to fix incorrect icon in top left of pokemon options when navigating the starter icons * Updated logic to include the ability to navigate and interact with the starter icons * Forgot to push the actual starter-select-ui-handler. Might be a bit hard to test things out without that :) * Removed some unnecessary comments * Fixed small bug with not being able to move from the far right to the gen selection when the starter icons were empty * Updated code to not be using a method to generate the party menu and made it more like it used to be. This should help with merge conflicts in the future * I committed the merged version but forgot to make the starter-select-ui-handler staged after making the changes * Accidentally broke challenges that had a specific typing requirement with last commit. This should fix it * Changed how navigation worked based on popular demand * Fixed code review comments * Accidentally left in a whole block of commented code. Intentionally removing it now * Started adding logic for mono type challenge runs to not break the game if the user tries to start a run with an invalid party * Updated the text to say the party is invalid * Updated logic to make invalid pokemon greyed out when no valid pokemon are in your party * Added comments on some code * Updated locales to include the key for trying to start with invalid parties during a challenge * Fixed some code from a bad merge where a challenge related param that was previously a number now needed to be a boolean and wasn't * Removed comment as per review * [Bug] Ability changing on evolution fix (#2995) * Prevent Pokemon with their second ability from evolving into their HA * Add check for fusions too * Localization(pt): Updated move.ts (#3078) * Localization(pt): Updated move.ts and fixed King's Shield * more fixes * [Bug] Enemy pokemon's Harvest creates berry icons on the player's side when triggered (#3077) * [Bug] Fix hustle not applying attack boost (#3101) * [Sprite] Mega Latis using opposite's eye colour (#3102) * [Sprite] Mega Latis using opposite eyes Taken from counterpart Lati * [Sprite] Update Mega Latios eyes * [Sprite] Update Mega Latias eyes * [Sprite] Mega Latias duplicated palette value Colour taken from non-exp Mega Latias * [Bug] Fix Thousand Arrows not hitting targets under the effects of Magnet Rise (#3100) * Fix Thousand Arrows not hitting through Magnet Rise * Add integration test for Thousand Arrows vs. Magnet Rise * ESLint * Remove unnecessary checks in integration tests * [Move] Aeroblast is a wind move (#3109) * Hardcoded Pokemon should have proper names * Aeroblast is a wind move * [Refactor] Replaces the single and double battles overrides with a single override (#3104) `SINGLE_BATTLE_OVERRIDE` and `DOUBLE_BATTLE_OVERRIDE` are now `BATTLE_TYPE` Also updates all uses of the old overrides with the new one * fix `Overrides` capitalization (#3111) * [Balance] More TM fixes (#3081) * More TM fixes * Leaf Storm * Removed sexy matcha * [Refactor] Code readability update (#3085) * Clean up/clarify `src/field/pokemon.ts` a bit Code provided by DerTapp on Discord * Update `PokemonSpeciesForm.getAbilityCount()` * Update `PokemonSpeciesForm.getAbility()` * Add explicit `Abilities.NONE` checks * Add tests * Add jsdoc and implement test suggestions * [Move] Implement Stockpile, Spit Up, Swallow (#2960) * feat: Implement Stockpile, Spit Up, Swallow * chore: Minor, likely unnecessary null checks * feat: Localization * Undo non-English localizations (unsure if they went through proper channels) * ko localization from @EnochG1 Co-authored-by: Enoch <[email protected]> * linting fix * add tests, tiny (non-functional) tweaks * Remove unnecessary cast * Update src/data/move.ts (oops) * remove some unnecessary comments, rename something for clarity --------- Co-authored-by: Enoch <[email protected]> * [Bug] Remove ability swap code in `PlayerPokemon.evolve()` (#3113) * [Test] Add test for rollout move (#3114) * add test for rollout move Co-authored-by: Zach Day <[email protected]> * fix tests still using `SINGLE_BATTLE_OVERRIDE` --------- Co-authored-by: Zach Day <[email protected]> * [Bug][Beta] Fix Hyper Beam, etc. permanently recharging (#3115) * Fix Hyper Beam, etc. permanently recharging * Fix override in hyper beam test * [QoL] New Starter Select UI with Filter (#2916) * update images for new UI * add updated starter UI with filter code * update starter-select test code * update win filter condition to pass test * remove unnecessary console log * update test code to match current filter UI * merge update * apply bugfix & chrry-pick small issues fix which are handled beta branch * resolve conflicts * fix lint errors * Fixed a bug where the target location for escaping using the left and right buttons on the starter button did not account for scrolling * update filter bar label color change when activated * fix lint error * fix lint * fix octolock.text.ts. it looks override import error. idk why it is happend in this PR. but it looks ok now * add passive dropdown in unlocks filter * fix lint * fix double button sound bug. refactoring genSpecies -> allSpecies, starterContainers -> starterContainer which are remove unnecessary generation axis * optimize updateStarterValueLabel function which is bottleneck of UI update latency * apply translation of gen filter label. fix lint * add # candies sort option * merge beta * resolve confilcts * fix offset of starter and start cursor * make compatible with starter UI * add missing feature * add images for legacy UI. adjust the position and size of the starterContainerWindow * [Localization] Implement Form localization (#3030) * Implement Pokemon forms localization * Update French pokemon-form.ts * Update French pokemon-form.ts * Update pokemon-form.ts * Add battle forms korean translation from returntoice Co-authored-by: returntoice <[email protected]> * Add cosplay forms korean translation from returntoice Co-authored-by: returntoice <[email protected]> * Add pichu form korean translation from returntoice Co-authored-by: returntoice <[email protected]> * Add castform forms korean translation by returntoice Co-authored-by: returntoice <[email protected]> * Add remaining forms korean translation by returntoice Co-authored-by: returntoice <[email protected]> * French typo corrections pokemon-form.ts * Update Korean pokemon-form.ts * Modify froakiBattleBond like rockruff of OwnTempo case, it is froakie, not greninja. * Modify zygardePc Power construct is more important information Switch its position to 50% or 10% to avoid overlapping with the sprite * Modify mispelling * Added german forms * Changed Gigadynamax and Unendynamax so it fits at all * Add partner pikachu and eevee form localization * Add mimikyu forms localization * Partner Pikachu, Partner Evoli und Mimikyu Formen hinzugefügt * Update pokemon-form.ts * Update partners * Fix conflicts * Fix useless ? by flx-sta Co-authored-by: flx-sta <[email protected]> * Fix switch use by flx-sta * Fix conflicts * Please work !!!!!!! * Update src/locales/fr/pokemon-form.ts Co-authored-by: Lugiad' <[email protected]> * Update src/locales/fr/pokemon-form.ts Co-authored-by: Lugiad' <[email protected]> * Add pt_br primal localization Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Add pt_br pikachu localization Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Add pt_br castform localization Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Add pt_br 3g localization Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Add zh_cn localization Co-authored-by: Yonmaru40 <[email protected]> * Add pt_br other localization Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Add es castform localization Co-authored-by: InnocentGameDev <[email protected]> * Add es burmy localization Co-authored-by: InnocentGameDev <[email protected]> * Add es shellos localization Co-authored-by: InnocentGameDev <[email protected]> * Add es rotom localization Co-authored-by: InnocentGameDev <[email protected]> * Add es basculin localization Co-authored-by: InnocentGameDev <[email protected]> * Add es deerling localization Co-authored-by: InnocentGameDev <[email protected]> * Add es froakie localization Co-authored-by: InnocentGameDev <[email protected]> * Add es scatterbug localization Co-authored-by: InnocentGameDev <[email protected]> * Add es furfrou localization Co-authored-by: InnocentGameDev <[email protected]> * Add es xerneas localization Co-authored-by: InnocentGameDev <[email protected]> * Add es zygarde localization Co-authored-by: InnocentGameDev <[email protected]> * Add es pumpkaboo localization Co-authored-by: InnocentGameDev <[email protected]> * Add es flabebe localization Co-authored-by: InnocentGameDev <[email protected]> * Add es oricorio localization Co-authored-by: InnocentGameDev <[email protected]> * Add es minior localization Co-authored-by: InnocentGameDev <[email protected]> * Add es magearna localization Co-authored-by: InnocentGameDev <[email protected]> * Add es marshadow localization Co-authored-by: InnocentGameDev <[email protected]> * Add es sinistea ocalization Co-authored-by: InnocentGameDev <[email protected]> * Add es eiscue localization Co-authored-by: InnocentGameDev <[email protected]> * Add es indeedee localization Co-authored-by: InnocentGameDev <[email protected]> * Add es rockruff localization Co-authored-by: InnocentGameDev <[email protected]> * Add es mimikyu localization Co-authored-by: InnocentGameDev <[email protected]> * Add es zarude localization Co-authored-by: InnocentGameDev <[email protected]> * Add es squawkabilly localization Co-authored-by: InnocentGameDev <[email protected]> * Add es tatsugiri localization Co-authored-by: InnocentGameDev <[email protected]> * Add es gimmighoul localization Co-authored-by: InnocentGameDev <[email protected]> * Add es poltchageit localization Co-authored-by: InnocentGameDev <[email protected]> * Add es paldeaTauros localization Co-authored-by: InnocentGameDev <[email protected]> * Add es primal localization Co-authored-by: InnocentGameDev <[email protected]> * Add es pikachu localization Co-authored-by: InnocentGameDev <[email protected]> * Add es partner localization Co-authored-by: InnocentGameDev <[email protected]> * Fix typedocs error * Fix typedocs error * cn form prefix added Co-authored-by: Yonmaru40 <[email protected]> * Fix german translate error * Fix typo Zh_CN Co-authored-by: mercurius-00 <[email protected]> * Update pokemon-form.ts [Localization(it)] * Update src/locales/es/pokemon-form.ts Co-authored-by: InnocentGameDev <[email protected]> * Fix megas forms bug and add forgotten forms * Fix wrong ko config * Add fr localization for new forms Co-authored-by: Lugiad' <[email protected]> * Add de localization for new forms Co-authored-by: Jannik Tappert <[email protected]> * Remove forgotten debug line Co-authored-by: Jannik Tappert <[email protected]> * Optimize battle forms * Update pokemon-form.ts (additional forms, italian localization) * The same typo is in the zh_TW placeholder text too. Co-authored-by: Madmadness65 <[email protected]> * Fix forgotten megaY Co-authored-by: Jannik Tappert <[email protected]> * Add capitalizeString to utils * Fix typedoc error * Update src/data/pokemon-species.ts Co-authored-by: Jannik Tappert <[email protected]> * Add ko localization for new forms Co-authored-by: MrWaterT <[email protected]> --------- Co-authored-by: Lugiad <[email protected]> Co-authored-by: returntoice <[email protected]> Co-authored-by: Mr.WaterT <[email protected]> Co-authored-by: MrWaterT <[email protected]> Co-authored-by: Jannik Tappert <[email protected]> Co-authored-by: flx-sta <[email protected]> Co-authored-by: Benjamin Odom <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: Yonmaru40 <[email protected]> Co-authored-by: InnocentGameDev <[email protected]> Co-authored-by: EnochG1 <[email protected]> Co-authored-by: mercurius-00 <[email protected]> Co-authored-by: Niccolò <[email protected]> Co-authored-by: Madmadness65 <[email protected]> * [Move] Fully implement Jungle Healing/Lunar Blessing status heal (#2785) * [Bug] Fix tags not resetting on switch (#3119) Fixes #2982 * [Move] Water Shuriken guarantees 3 hits with battle bond (#2687) * [Bug] Make on-summon abilities trigger after the switch check (#3118) * Make on-summon abilities trigger after the switch check * Add test * [Ability] Cloud Nine now displays a message on activation Maintains parity with Air Lock. Both of these probably need to be localized. Should fix issue 491 though * [QoL] Summary Option for Caught Pokemon (#2921) * Option to view Summary before adding new Pokemon to party * Fixed issues described by HopsWas * Adjusted makeRoomForConfirmUi to improve window spacing * Fixed ESLint issue + addressed OrangeRed review * Fixed Github pages issue * Removed duplicate unshiftPhase * Fixed phase order * Don't start from beginning of catch function * Option to view Summary before adding new Pokemon to party * Fixed issues described by HopsWas * Adjusted makeRoomForConfirmUi to improve window spacing * Fixed Github pages issue * Fixed phase order * Quick fix * This should fix the summaryOption feature without bugging confirm-ui-handler in other cases * Revert "Merge remote-tracking branch 'origin/summaryOption1' into summaryOption1" This reverts commit ea7d0ce59e3f5631a8ef3d76646069a3945ed036, reversing changes made…
Tempo-anon
added a commit
that referenced
this pull request
Jul 30, 2024
* feat: Add Google and Discord login functionality feat: Add link to Discord in menu UI feat: Add Discord and Google login functionality Add container around discord and google icons refactor: Update environment variable names for Discord and Google client IDs feat: Add "Or use" translation for login options in multiple languages feat: Update menu UI translations for multiple languages Code review fixes refactor: Update Discord and Google client IDs in environment variables * refactor: Add missing properties to initLoggedInUser function * Update src/locales/de/menu-ui-handler.ts Co-authored-by: Jannik Tappert <[email protected]> * make i18n debugging an optional env setting this also reduces output noise in tests * set development default also to "0" * [Localization]Localized move-trigger text * [Localization]Localized zh-cn move-trigger text * [Localization]fix typo * [Localization]fix typo * Update src/locales/pt_BR/move-trigger.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * [Localization]add pokemonName to move-trigger.ts * [Localization]add pokemonName to move-trigger.ts * Update zh_TW move-trigger.ts * Update zh_CN move-trigger.ts * Update move.ts * Update src/locales/ko/move-trigger.ts Co-authored-by: Enoch <[email protected]> * Update src/locales/ko/move-trigger.ts Co-authored-by: Enoch <[email protected]> * Update move-trigger.ts * Update src/locales/de/move-trigger.ts Co-authored-by: Jannik Tappert <[email protected]> * [Localization]add affix to target pokemon names * fix inaccurate docs for TypeImmunityAbAttr (#2957) * chore: Add beta branch to GitHub Actions tests workflow * chore: Add beta branch to GitHub Actions linter and gh-pages workflow * Update src/locales/ko/menu-ui-handler.ts Co-authored-by: lnuvy <[email protected]> * Update src/locales/ko/menu.ts Co-authored-by: lnuvy <[email protected]> * Localization(pt): translated bgm-name.ts (#2955) * Localization(pt): translated bgm-name.ts * fix * update VITE_I18N_DEBUG in .env files * chore: Update environment variables for beta and production environments * chore: Add beta branch to GitHub Actions deploy workflow * Hardcoded Pokemon should have proper names (#2941) * Refactor challenges and add fresh start (#2963) * [Balance] Update many TM learnsets (#2879) * Update TMs for more Indigo Disk changes * Fix typo, more Stored Power * Refactor challenges and add fresh start (#2964) * Refactor challenges and add fresh start * Add achievement for fresh start challenge * Update src/locales/fr/move-trigger.ts Co-authored-by: Lugiad' <[email protected]> * [Bug] Fix off-by-one error in damage calc (#2970) * Fix random damage roll to be 85-100% instead of 85-99% * Update battle.test.ts to reflect the fix * [Bug] Grounded on Terrain fixes (#2969) * [Help] [Move/Bug] Patches Psychic Terrain applicability edge cases Was cancelling moves even if targeted mons weren't on the terrain. * [Bug `]Pokemon.isGrounded` does not exist Replaced with `Pokemon.isGrounded()`, which does. * [Bug] Psychic Terrain priority move cancel ignoring ungrounded * [Bug] Semi-invulnerable should not be grounded * Update game-stats-ui-handler.ts (italian) (#2965) * [Bugfix] Fix a bug during bgm-bar initialization (#2822) * Prevent sizing error * Make reboot not necessary for show BGM * Makes the BGM Bar active by default + It had originally been decided that this would not be active by default because it was to be displayed outside the pause menu, but since its behavior has changed between this decision and its integration, the default deactivation is no longer necessary * [Mirror][Localization] Translate game victory sentences #2254 (#2906) * Translate forgotten sentences on phases * Translate to de forgotten sentences on phases * Translate to es forgotten sentences on phases * Translate to fr forgotten sentences on phases * Translate to it forgotten sentences on phases * Translate to ko forgotten sentences on phases * Translate to pt br forgotten sentences on phases * Translate to zh cn forgotten sentences on phases * Translate to zh tw forgotten sentences on phases * remove duplicate message * remove duplicate message * Update src/locales/pt_BR/battle.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/de/battle.ts Co-authored-by: Jannik Tappert <[email protected]> * Update src/locales/de/battle.ts Co-authored-by: Jannik Tappert <[email protected]> * Update battle.ts [Localization(it)] * Update src/locales/zh_CN/battle.ts Co-authored-by: Yonmaru40 <[email protected]> --------- Co-authored-by: Alexis <[email protected]> Co-authored-by: 송지원 <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: Jannik Tappert <[email protected]> Co-authored-by: Niccolò <[email protected]> Co-authored-by: Yonmaru40 <[email protected]> * [Mirror][Localization] Translate summary #2336 (#2907) * Translate pokemon summary * Translate pokemon summary to fr * Translate pokemon summary to de * Translate pokemon summary to es * Translate pokemon summary to it * Translate pokemon summary to ko * Translate pokemon summary to pt br * Translate pokemon summary to zh cn * Translate pokemon summary to zh tw * Fix import * Update partially for en and ko * Update interface name for en * Merge trainerLabel&Text and calculate typeLabel width * Update src/locales/es/pokemon-summary.ts Co-authored-by: GoldTra <[email protected]> * Apply translations key to all languages with interface TranslationEtries * Update ko/translationKey of status * Update ko/translationKey of pokemonInfo * Update de/translationKeys of memostring and metFragment * Update de/translationKeys of memostring and metFragment 2 * Update src/locales/ko/pokemon-summary.ts Co-authored-by: Enoch <[email protected]> * Update src/locales/ko/pokemon-summary.ts Co-authored-by: returntoice <[email protected]> * Update src/locales/pt_BR/pokemon-summary.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/ko/pokemon-summary.ts * Update src/locales/pt_BR/pokemon-summary.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update pokemon-summary.ts [Localization(it)] * remove unused code * Update src/locales/zh_CN/pokemon-summary.ts Co-authored-by: Yonmaru40 <[email protected]> * Update src/locales/zh_CN/pokemon-summary.ts Co-authored-by: Yonmaru40 <[email protected]> * Update src/locales/zh_CN/pokemon-summary.ts Co-authored-by: Yonmaru40 <[email protected]> * Update src/locales/es/pokemon-summary.ts Co-authored-by: Arxxer <[email protected]> * Update src/locales/es/pokemon-summary.ts Co-authored-by: Arxxer <[email protected]> --------- Co-authored-by: Alexis <[email protected]> Co-authored-by: Mr.WaterT <[email protected]> Co-authored-by: Alexis Faizeau <[email protected]> Co-authored-by: GoldTra <[email protected]> Co-authored-by: returntoice <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: 송지원 <[email protected]> Co-authored-by: Niccolò <[email protected]> Co-authored-by: Yonmaru40 <[email protected]> Co-authored-by: Arxxer <[email protected]> * [Localization] Localization arena flyout (Active Battle Effects) (#2932) * localizing Active Battle Effects (working) * Localize Active Battle Effects * Change return value * Modify arena terrain desc * Update src/locales/zh_CN/arena-flyout.ts Co-authored-by: Yonmaru40 <[email protected]> * Update src/locales/de/arena-flyout.ts Co-authored-by: Jannik Tappert <[email protected]> * Update src/locales/fr/arena-flyout.ts Co-authored-by: Lugiad' <[email protected]> * Update arena-flyout.ts (IT) * Update src/locales/pt_BR/arena-flyout.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/es/arena-flyout.ts Co-authored-by: Arxxer <[email protected]> * Change util function name --------- Co-authored-by: 송지원 <[email protected]> Co-authored-by: Yonmaru40 <[email protected]> Co-authored-by: Jannik Tappert <[email protected]> Co-authored-by: Lugiad' <[email protected]> Co-authored-by: Niccolò <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: Arxxer <[email protected]> * This should prevent gym leaders appear as doubles (marnie & piers) when they arent fixed battles (#2904) * The stat messages can now be plural (#2600) * The stat messages are now plural * "And" can now be localized * Revert Override * Update src/locales/fr/battle.ts Co-authored-by: Lugiad' <[email protected]> * Update src/locales/fr/battle.ts Co-authored-by: Lugiad' <[email protected]> * Update src/locales/fr/battle.ts Co-authored-by: Lugiad' <[email protected]> * Update src/locales/zh_CN/battle.ts Co-authored-by: Yonmaru40 <[email protected]> * Update src/locales/ko/battle.ts Co-authored-by: Enoch <[email protected]> * Update src/locales/ko/battle.ts Co-authored-by: Enoch <[email protected]> * Update src/locales/es/battle.ts Co-authored-by: GoldTra <[email protected]> * Update src/locales/es/battle.ts Co-authored-by: GoldTra <[email protected]> * Update src/locales/de/battle.ts * Update src/locales/pt_BR/battle.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/pt_BR/battle.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/data/battle-stat.ts * Update src/locales/zh_CN/battle.ts Co-authored-by: Yonmaru40 <[email protected]> * Changed the way the multiple is handeled to use the i18n way * Missed one file * Apply suggestions from code review * Apply suggestions from code review * Changed the tests so they work now with the i18n hting * Fixed some other tests (chinese still makes problems... * Fix tests for chinese * Tests * Update src/test/battle-stat.spec.ts * Update src/locales/zh_CN/battle.ts Co-authored-by: Yonmaru40 <[email protected]> * Apply suggestions from code review --------- Co-authored-by: Lugiad' <[email protected]> Co-authored-by: Yonmaru40 <[email protected]> Co-authored-by: Enoch <[email protected]> Co-authored-by: GoldTra <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * [Enhancement][QoL] Add option to adjust shop overlay opacity (#2622) * add option to adjust shop overlay opacity * add localization * fix bug * Update src/locales/fr/settings.ts Co-authored-by: Lugiad' <[email protected]> * Update src/locales/zh_CN/settings.ts Co-authored-by: Yonmaru40 <[email protected]> * Update src/locales/fr/settings.ts Co-authored-by: Lugiad' <[email protected]> * update default value * update setting values * re-add value 10 * Update src/locales/pt_BR/settings.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/ko/settings.ts Co-authored-by: Enoch <[email protected]> * Update src/locales/es/settings.ts Co-authored-by: InnocentGameDev <[email protected]> * Update settings.ts --------- Co-authored-by: Lugiad' <[email protected]> Co-authored-by: Yonmaru40 <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: Enoch <[email protected]> Co-authored-by: InnocentGameDev <[email protected]> Co-authored-by: Niccolò <[email protected]> * [Bug] Fix battler tags lapsing at incorrect times (#2944) * Fix battler tags lapsing at incorrect times * Document FlinchedTag * Update French pokemon-summary.ts (#2976) * [Test] Prevent tests from running if overrides are different from the default values (#2110) * mock default overrides in test setup * change beforeEach to beforeALl * move some more enums into the enums directory * replace modules that import i18n into overrides with modules that don't * add pre tests and update vitest configs, scripts * replace tabs with spaces * fix vitest server port overlap warning * add missing overrides and clean up workspace config * change test name * include spec files in main test suite * [QoL] Highlight targets of multitarget moves instead of immediate execution (#2863) * show targets for move targeting multiple pokemon * dont allow selecting target if multiple * fix targeting * cleanup * more cleanup * only highlight targets is move is not status * fix tests failing * fix tests * change "immediately" to "auto" * nevermind just remove auto * remove status move condition * [Refactor] rewrite applyAbAttrsInternal to use an iterator. (#1832) * initial rewrite of applyAbAttrsInternal * clean up applyAbAttrsInternal * remove the await because it wraps non Promises in a promise * add TODO comment about promises * fix broken costar test, hopefully * Update typescript and typedoc (#2988) * update typescript and typedoc to latest versions * forgot to add the package-lock * add fixes for breaking type gen * update workflow (#2989) * [Qol/Balance] Dynamax cannon tweak (#2540) * Dynamax Cannon fix * Update src/locales/fr/move.ts Added fr translation. Co-authored-by: Lugiad' <[email protected]> * Update src/locales/fr/move.ts Adding an important missing precision in French description Co-authored-by: Lugiad' <[email protected]> * Update src/locales/de/move.ts German locale commit. Co-authored-by: Jannik Tappert <[email protected]> * Update src/locales/zh_CN/move.ts Chinese locale commit, checked by a native speaker Co-authored-by: Lugiad' <[email protected]> * Update src/locales/ko/move.ts Korean locale added Co-authored-by: returntoice <[email protected]> * fixed trailing space in Chinese locale * added es locale * Different Dynamax Cannon fix. This one is the one * Dynamax Cannon fix localisations * Update src/locales/fr/move.ts Added fr locale Co-authored-by: Lugiad' <[email protected]> * Update src/locales/de/move.ts German translation ^^ Co-authored-by: Jannik Tappert <[email protected]> * Update src/locales/pt_BR/move.ts pt-BR translation Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/de/move.ts Eslint fix, good catch @Enoch Co-authored-by: Enoch <[email protected]> * Update src/locales/ko/move.ts Korean locale ^^ Co-authored-by: sodam <[email protected]> * Update src/locales/zh_CN/move.ts zh_CN locale Co-authored-by: RimKnight <[email protected]> * Update src/locales/zh_TW/move.ts zh_TW locale Co-authored-by: RimKnight <[email protected]> * Update move.ts linting mistake due to how my comment was written * Update move.ts linting mistake due to how my comment was written * Update move.ts [Localization(it)] * WIP test * WIP test part 2 * [Test] Add Unit Tests for Dynamax Cannon * removed some unnecessary cases in the test to reduce testing overhead * Update src/locales/ko/move.ts Updated kr locale Co-authored-by: Enoch <[email protected]> * [Test] Adjust Unit Tests for Dynamax Cannon --------- Co-authored-by: Lugiad' <[email protected]> Co-authored-by: Jannik Tappert <[email protected]> Co-authored-by: returntoice <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: Enoch <[email protected]> Co-authored-by: sodam <[email protected]> Co-authored-by: RimKnight <[email protected]> Co-authored-by: Niccolò <[email protected]> Co-authored-by: xsn34kzx <[email protected]> * [Test] Fix/Extend Unit Test for Hard Press (#2992) * [Test] Update tests to enable no-crits override (#2971) * Update tests to enable no-crits override * Rename variable maxHP to initialHP * localized type * [Localization]Localized move-trigger text (#2913) * [Localization]Localized move-trigger text * [Localization]Localized zh-cn move-trigger text * [Localization]fix typo * [Localization]fix typo * Update src/locales/pt_BR/move-trigger.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * [Localization]add pokemonName to move-trigger.ts * [Localization]add pokemonName to move-trigger.ts * Update zh_TW move-trigger.ts * Update zh_CN move-trigger.ts * Update move.ts * Update src/locales/ko/move-trigger.ts Co-authored-by: Enoch <[email protected]> * Update src/locales/ko/move-trigger.ts Co-authored-by: Enoch <[email protected]> * Update move-trigger.ts * Update src/locales/de/move-trigger.ts Co-authored-by: Jannik Tappert <[email protected]> * [Localization]add affix to target pokemon names * Update src/locales/fr/move-trigger.ts Co-authored-by: Lugiad' <[email protected]> * localized type --------- Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: Enoch <[email protected]> Co-authored-by: Jannik Tappert <[email protected]> Co-authored-by: Lugiad' <[email protected]> * [Bug] Fix description of rare candy to have proper amount of level (#2903) * [Bug] Fix description of rare candy to have proper amount of level * Update en locales * Add locales * Add locales * Update src/locales/de/modifier-type.ts Co-authored-by: Jannik Tappert <[email protected]> * Update src/locales/de/modifier-type.ts Co-authored-by: Jannik Tappert <[email protected]> * Update src/locales/fr/modifier-type.ts Co-authored-by: Lugiad' <[email protected]> * Update src/locales/fr/modifier-type.ts Co-authored-by: Lugiad' <[email protected]> * Update src/locales/ko/modifier-type.ts Co-authored-by: Enoch <[email protected]> * Update src/locales/ko/modifier-type.ts Co-authored-by: Enoch <[email protected]> * Update src/locales/zh_CN/modifier-type.ts Co-authored-by: Yonmaru40 <[email protected]> * Update src/locales/zh_CN/modifier-type.ts Co-authored-by: Yonmaru40 <[email protected]> * Update src/locales/pt_BR/modifier-type.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/pt_BR/modifier-type.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update modifier-type.ts (IT) * Update src/locales/es/modifier-type.ts Co-authored-by: Arxxer <[email protected]> * Update src/locales/es/modifier-type.ts Co-authored-by: Arxxer <[email protected]> --------- Co-authored-by: Jannik Tappert <[email protected]> Co-authored-by: Lugiad' <[email protected]> Co-authored-by: Enoch <[email protected]> Co-authored-by: Yonmaru40 <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: Niccolò <[email protected]> Co-authored-by: Arxxer <[email protected]> * move status effect enum into separate file (#2998) * add .env.test (#2997) block i18n debug output by default * [QoL] Create default overrides class and export that with custom overrides (#2999) * Create default overrides class and export that with custom overrides * add comment to mock import and replace typecast with type narrowing * change modifier override type to pick keys from modifierTypes * [Feature][FUN] add breedersInSpace splash message (#2631) * add spaceBreeder splash message * fix typo (whops) * Add pt_BR translation Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * replace text & key with breedersInSpace * add french tanslation Co-authored-by: Lugiad' <[email protected]> * remove obsolete array split in splash-messages.ts * Update src/locales/pt_BR/splash-messages.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/es/splash-messages.ts Co-authored-by: Asdar <[email protected]> * Update splash-messages.ts (Italian) * Update src/locales/zh_CN/splash-messages.ts Co-authored-by: Yonmaru40 <[email protected]> * Update src/locales/ko/splash-messages.ts Co-authored-by: sodam <[email protected]> --------- Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: Lugiad' <[email protected]> Co-authored-by: Asdar <[email protected]> Co-authored-by: Niccolò <[email protected]> Co-authored-by: Yonmaru40 <[email protected]> Co-authored-by: sodam <[email protected]> * [Enhancement] Pokemon generation number tooltip (#2642) * Create tooltip to show Pokemon generation * Add option to toggle generation tooltip * Use roman numeral for generation tooltip * Revert "Add option to toggle generation tooltip" This reverts commit 414b2366fc55c5642f8858d6f4854aa62c4caf60. * Update src/locales/de/battle-info.ts Co-authored-by: Jannik Tappert <[email protected]> * Update src/locales/fr/battle-info.ts Co-authored-by: Lugiad' <[email protected]> * Update src/locales/pt_BR/battle-info.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/zh_TW/battle-info.ts Co-authored-by: RimKnight <[email protected]> * Update src/locales/zh_CN/battle-info.ts Co-authored-by: RimKnight <[email protected]> * Update src/locales/ko/battle-info.ts Co-authored-by: Enoch <[email protected]> * Update battle-info.ts (IT) --------- Co-authored-by: Jannik Tappert <[email protected]> Co-authored-by: Lugiad' <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: RimKnight <[email protected]> Co-authored-by: Enoch <[email protected]> Co-authored-by: Niccolò <[email protected]> * [Beta] Updating the manage data->unlock all option to work with all abilities, natures, forms and passives (#2967) * Updated code to allow user to unlock all pokemon from the manage data menu option * Added code to Utils to allow it to check for a beta env, and hid the unlock all code behind that. This should stop it from being accessed in prod envs * Updated another section to be locked behind beta check, and also updated the everything.prsv to have everything unlocked going forward * Fixed some code reviews * [Bug] vite port (for development) (#3003) * make vite-port configurable and make it default 8000 * add retries for `does not trigger by non damage moves` test * feat: Update isBeta check in utils.ts to use import.meta.env.MODE The current implementation of the isBeta check in utils.ts is using import.meta.env.DEV, which gives the same value for both beta and dev environments. This commit updates the check to use import.meta.env.MODE === "beta" to accurately determine if the environment is beta. This ensures that the unlock all code is only accessible in the beta environment and not in production environments. * refactor: Update trainerId and secretId in game data This commit updates the `trainerId` and `secretId` properties in the `GameData` class. The values are replaced with the corresponding values from the `this.trainerId` and `this.secretId` variables. This change ensures that the `trainerId` and `secretId` are correctly updated in the game data. * Adds bg glow behind starters with unlocked passives (#2497) * [Localization] Localize missed things in battlers-tag.ts (#3004) * Localize missed things in battlers-tag * Change orders of configs * Add missed phase * Update src/locales/zh_CN/battle.ts Co-authored-by: RimKnight <[email protected]> * Update src/locales/zh_CN/battle.ts Co-authored-by: RimKnight <[email protected]> * Update src/locales/zh_TW/battle.ts Co-authored-by: RimKnight <[email protected]> * Update src/locales/zh_TW/battle.ts Co-authored-by: RimKnight <[email protected]> * Update src/locales/zh_TW/battler-tags.ts Co-authored-by: RimKnight <[email protected]> * Update src/locales/zh_CN/battler-tags.ts Co-authored-by: RimKnight <[email protected]> --------- Co-authored-by: RimKnight <[email protected]> * [Feature] Fully implement Octolock (#2985) * implement octolock * Add tests * [Bug] Fix import of overrides in a test (#3009) * [BUG] Fixes Sketch copying the first move used by the opponent instead of the last (#2759) * Changes getMoveHistory to getLastXMoves to fix sketch copying first move used instead of last * Optimizes move search and early return * Reverts check for virtual moves * [Bug] Making FormChangeItems Untransferrable (#2695) * Made FormChangeItems untransferrable. Replaced getTransferrable() * Made isTransferrable readonly. Removed unnecessary 'm as PokemonHeldItemModifier'. * [Bug] Fix Clear terrains upon Trainer Battle (#2027) * Clear terrains upon Trainer Battle * Adjusted comment * Fix item reward overrides going out of bounds (#3012) * [Localization] Localize Berry Heal message (#2996) * Localize berry heal message (HP/PP) * Change location of translation * conflict resolve * Update src/locales/de/battle.ts Co-authored-by: Jannik Tappert <[email protected]> Update src/locales/de/battle.ts Co-authored-by: Jannik Tappert <[email protected]> Update src/locales/de/battle.ts Co-authored-by: Jannik Tappert <[email protected]> * Update src/locales/zh_CN/battle.ts Co-authored-by: mercurius-00 <[email protected]> * Update src/locales/zh_TW/battle.ts Co-authored-by: mercurius-00 <[email protected]> * Update src/locales/fr/battle.ts Co-authored-by: Lugiad' <[email protected]> * Update src/locales/pt_BR/battle.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/pt_BR/battle.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update battle.ts (Berries ITALIAN) --------- Co-authored-by: 송지원 <[email protected]> Co-authored-by: Jannik Tappert <[email protected]> Co-authored-by: mercurius-00 <[email protected]> Co-authored-by: Lugiad' <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: Niccolò <[email protected]> * Adds a check to the bgm-bar display to prevent it from being displayed in case of an empty value (#3007) * [Sprite] Improves Corviknight Palette usage (#3020) * [Sprite] Compress Corviknight exp * [Sprite] Compress Corviknight exp * [Sprite] Compress Corviknight exp * [Sprite] Compress Corviknight exp * [Sprite] Compress Corviknight exp * [Beta][Localization] Update French battler-tags.ts and battle.ts (#3015) * Update French battler-tags.ts * Update battle.ts * [Bug] Fix Lock-On and Mind Reader not working on the first turn (#3001) * [Bug] Struggle Recoil should ignore Magic Guard (#3017) * Drafted testable conditions for Magic Guard * Weather Test * Update src/test/abilities/magic_guard.test.ts InnerThunder Co-authored-by: innerthunder <[email protected]> * Implemented checks for poison/toxic/burn * Added tests for recoil moves and volatile status * Updated Rock Head, Magic Guard, and Reckless interactions with Struggle * Removed stray file * Fixed Typedoc errors * Implemented innerthunder's feedback --------- Co-authored-by: Frutescens <info@laptop> Co-authored-by: innerthunder <[email protected]> * [Enhancement] Decouple move power calculation from Pokemon.apply(), Fixes Power Spot & Battery not boosting ally's move (#2984) * refactor power calc, fix battery & power spot * fix hard press unit test * fix hard press * refactor tests * use sypOn hp instead * rename method * cleanup tests * improve tests * use slow vs fast pokemon * fix steely spirit test * fix steely spirit for real this time * remove unnecessary test * address pr feedback * add removed code * [QoL] Offset the status indicator to keep pokeball in view (#2966) * Offset the status indicator to keep pokeball in view * Only use offsetX when the Pokemon is the enemy * Adjust position to accomodate boss health bar * [Bug] Fix to epic shiny Yungoos icon (#2991) (#3016) Fixed a floating pixel in epic shiny Yungoos' icon. Caused by Mimikyu's epic shiny sprite being placed too high on the sprite sheet. Moved Mimikyu's sprite down and updated json to reflect the change. * [Localization(ko)] Change line-break position of ghost type curse add message (#3022) * Revert "[Localization]Localized move-trigger text (#2913)" (#3026) This reverts commit 39bdfea0c8b33a759db760809d6488d825b510e2. * [Localization(ko)] Fixed typo in Bertha's dialogue (#3025) * [Bug] Prevent fixed-damage and OHKO moves from being modified by damage-reducing abilities (#2703) * ReceivedMoveDamageMultiplierAbAttr patch: WIP refactored damage calculation, reordered ReceivedMoveDamageMultiplierAbAttr to avoid issues with fixed damage and OHKO moves, stubbed unit tests for dragon rage (fixed damage) and fissure (OHKO) * ReceivedMoveDamageMultiplierAbAttr patch: commented concerns regarding EnemyDamageBooster/ReducerModifier for others' reference in WIP branch * ReceivedMoveDamageMultiplierAbAttr patch: reordered ReceivedMoveDamageMultiplierAbAttr and EnemyDamageBooster/ReducerModifier to not trigger for fixed damage and OHKO moves, completed relevant tests for dragon rage and fissure * ReceivedMoveDamageMultiplierAbAttr patch: removed newline * ReceivedMoveDamageMultiplierAbAttr patch: in the unit test, extracted hard-coded Dragon Rage damage to a variable * ReceivedMoveDamageMultiplierAbAttr patch: naming consistency * ReceivedMoveDamageMultiplierAbAttr patch: replaced awaiting DamagePhase with TurnEndPhase as the former assumes damage will be done * ReceivedMoveDamageMultiplierAbAttr patch: removed redundant overrides in Fissure tests * ReceivedMoveDamageMultiplierAbAttr patch: tests: refactored crit removal, removed berries, fixed bug associated with Porygon sometimes getting Trace and copying the opponent's ability, which would override the manual ability override * Fixed unit tests * Added a comment and cleaned up an existing one * [Localization] Brought german localization up to date (#3010) * Fixed errors in the german localization * Fresh Start Challenge * Update src/locales/de/move-trigger.ts Co-authored-by: flx-sta <[email protected]> * Apply suggestions from code review --------- Co-authored-by: flx-sta <[email protected]> * [Bug] Remove redundant damage number popups (#3024) * Remove magic number from Belly Drum's attr * Remove redundant damage number popup * Fix merge issue and remove another duplicate damage number instance * [Localization]fix placeholder error * [Move] Implements Conversion 2 (#2943) * Creates function to get type resistances, implements conversion 2 * Removes unimplemented tag, adds condition for move history to exist * Cleans up type selection, creates i18n entries for typeChanged * Uses typeChanged i18n in Conversion move * More detailed docs, early return with stellar/unknown type * Adds note that it wont track type-changing moves properly * Rephrases doc description, adds partial since it can't track type-changing moves * Updates localization, removes typeChanged entry to use move-trigger entry * Missed locale de entry in last commit * Adds comment for reason of .partial() * Fixes localization error due to revert, removes improper merge conflict from prior commit * [BUG] Fixes bug with Metronome freezing the game (#2819) * Tests MovePhase with new PokemonMove instead of moveset search * Accounts for metronome call on charging moves * Update comment in ChargeAttr to be clearer * Add missing passive background graphic for legacy UI Relating to #2497 , this adds an identical graphic to the legacy UI files, as it will show up as a missing texture otherwise. * [Localization]fix placeholder error * [Localization]fix placeholder error * [Localization]fix placeholder error * [Localization] Localize ability messages in ability.ts (trigger, apply...) (#2972) * localize ability messages * Update src/locales/de/ability-trigger.ts Co-authored-by: Jannik Tappert <[email protected]> * Modify parameter name, fix eslint * Korean Translation, modify some wrong param * Add missed message * Update src/locales/de/ability-trigger.ts Co-authored-by: Jannik Tappert <[email protected]> * Update ability-trigger.ts (Partial) (Italian) * Localize type name * Localize type name > Libero, Protean * param bug fix * Update src/data/ability.ts * Update zh-cn * Update ability-trigger.ts (Partial part 2, still not completed) (Italian) * Update src/locales/fr/ability-trigger.ts Co-authored-by: Lugiad' <[email protected]> * Update src/locales/pt_BR/ability-trigger.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update src/locales/fr/ability-trigger.ts Co-authored-by: Lugiad' <[email protected]> --------- Co-authored-by: 송지원 <[email protected]> Co-authored-by: Jannik Tappert <[email protected]> Co-authored-by: Niccolò <[email protected]> Co-authored-by: Lugiad' <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Update egg.ts (italian) (#3038) * [Localization]complete AddTypeAttr localization * [Sprite] Revert Larvesta, fixing stray pixels (#3042) * [Sprite] Remove normal Larvesta stray pixels Taken from original commit * [Sprite] Revert shiny Larvesta stray pixels Taken from original commit * [Sprite] Match variant Larvesta colours * [Bug] Fix level 100 moves being skipped if leveled past 100 (#3040) * [Bug][Fix][Surf][Muddy Water][Sludge Wave][Animation] Added image to move animations. (#3044) * Update muddy-water.json * Update sludge-wave.json * Update surf.json * [Sprite] Fix Cofagrigus sprite (#3045) * Fix Cofagrigus sprite * Base sprite fix * Created json variant file... manually * Update src/locales/ko/move-trigger.ts Co-authored-by: Enoch <[email protected]> * Update src/locales/de/move-trigger.ts Co-authored-by: Jannik Tappert <[email protected]> * Update src/locales/pt_BR/move-trigger.ts Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * [Localization]fix typo * Fix FR typo (#3051) * Update src/locales/fr/move-trigger.ts Co-authored-by: Lugiad' <[email protected]> * [Beta][Localization] Update Portuguese battler-tags.ts and battle.ts (#3050) * Update move-trigger.ts (PARTIAL, italian) * Update move-trigger.ts (PARTIAL, italian) * [Music/BGM] Fix bgm file & loop for battle_rival (#3053) * stop loading pride-update banner (#3057) * Update src/locales/ko/move-trigger.ts Co-authored-by: Enoch <[email protected]> * [Item] Add Scope Lens and Leek (#2666) * [Item] Add Scope Lens and Leek * Add Entry to pt_BR * Localize for pt_BR Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Fix & Clean Unit Tests --------- Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * [Music/BGM] New music added for the "Slum" biome, composed by Andr06 (#3000) * Replacement of the BGM in the slum biome (by Andr06) * Modification of BGM credits in README.md * Replacement of the BGM name by the title chosen by its composer in all languages * Update BGM loop point for biome 'SLUM' * [Bug] implemented multi target damage penalty (#2329) * fix: damage multiplier by the number of targets * fix: used actual number value rather than the number holder * test: added unit test for counting targets * multi-target: fixed names of the unit tests. * test: simple-test changes * test: changed multi-target test code * test: testing damage decreasement * test: multi-target test fix * resolved conflicts in test --------- Co-authored-by: Tempoanon <[email protected]> * [BUG] Uturn faint switch bug fix (#2980) * reordering adding switch phases for u-turn * reverting some temp changes * generalizing function * adding PR suggestions * nit indenting * [Sprite] Remove extra Oinkologne sprites (#3067) * Delete public/images/pokemon/female/916.png * Delete public/images/pokemon/exp/female/916.json * Delete public/images/pokemon/exp/female/916.png * Delete public/images/pokemon/female/916.json * [Sprite] Mega Mewtwo sprite fixes (#3065) * [Sprite] Add static epic Mega Mewtwo Y Colours taken from exp, as consistent/exp rare backs share palettes. * [Sprite] Fix transparent pixels on Mega Mewtwo X * [Sprite] Fix transparent pixels on Mega Mewtwo X * [Sprite] Add static epic Mega Mewtwo Y Now exists, and is a paletteswap * [Music/BGM] New music added for the "Sea" biome, composed by Andr06 (#3063) * Replacement of the BGM in the sea biome (by Andr06) * Modification of BGM credits in README.md * Replacement of the BGM name by the title chosen by its composer in all languages * Update BGM loop point for biome 'SEA' * [Balance] Add 12 new TMs and remove 3 (#2733) * Added Counter TM * Counter, Aqua Tail, Gastro Acid, Pluck, Secret Power, Aurora Veil, Incinerate * Placed TMs in proper order, added to pool * Add Secret Power to the pool * Add TM for Synthesis * Covet, Heal Bell, PUPunch, Recycle, Volt Tackle, Worry Seed * Remove species specific TMs * Remove Secret Power TM until implementation * [Refactor/Test] Update Dynamax Cannon Unit Tests (#3074) * [Refactor/Test] Update Dynamax Cannon Unit Tests * Adjust Test Names * fix: update SameSite attribute in setCookie function to None * fix: update SameSite attribute in setCookie function to Strict * feat: Add prompt=none to Discord OAuth authorization URL * fix: Remove unnecessary cookie setting in LoginPhase and MenuUiHandler * feat: Improve cookie handling in getCookie function * feat: Delete duplicate cookies with the same name in getCookie function * [Localization] Add minor Korean translations to ability-trigger file (trace) (#3093) * modify trace trigger description (refered from official translation) modify trace trigger description (refered from official translation) * modify trace trigger description (refered from official translation) modify trace trigger description (refered from official translation) * Fix broken `multi_target` tests and remove RNG-based failures (#3095) * Prevent RNG from breaking the Quick Draw tests (#3096) * Make EXP boosting items stack additively and not multiplicatively (#3094) Fixes #2040 * [Bug] Fixes Encore bug with multi-target moves missing (#3060) * Pushes move history even when multi target move misses * Move pushMoveHistory out of Move Pending condition * Add remaining relearn moves (#2894) * [Enhancement] Decouple move accuracy and accuracy multiplier calculation from phases.ts (#2899) * refactor accuracy calc * update doc * move accuracy multiplier calculation outside phases * update wonder skin unit test * rename method * add docs * add unit tests * address feedback * rename method * fix imports * improve tests * add test for ohko move accuracy * [Sprite] Fix a number of sprite issues including the Zubat line, Goldeen, Golett, Dudunsparce, H-Sneasel, Garchomp, Sylveon, Marshadow (#3069) * Batfix, Goldeen, Chomp, Golett, genies * Fix Dudunsparce using Reborn shiny backsprite for whatever reason * Fix female Hisuian Sneasel missing variants * Marshadow epic front and Zenith, Sylveon back * Fix Zubat line back sprite inconsistencies * Fix Noivern shiny back * [Move] Finish implementation of Glaive Rush (#2720) * Finish implementation of Glaive Rush * Fix test RNG * Add code/test for Multi-Lens interaction * Fix off-by-one error in test caused by rounding issues * Update for code changes * Fix BattlerTag name * [Bug] fix not changing moveset after add to starter #1932 (#2396) * [Bug] Enemies can properly use stuff cheeks (#3090) * [Feature] Added pokemon nicknames/renaming (#2570) * Added basic temp renaming * Made nickname persistant after reloading * Localization and cancel button * Fixed instant rename on active pokemon * Small bugfix to prevent console errors * Changed logic to use the new nickname field. Replaced most .name with getNameToRender() for display. * Changed evolution message. Removed log messagesc * Added localization keys for other languages * Removed empty lines * French translation Co-authored-by: Lugiad' <[email protected]> * Chinese translation Co-authored-by: Yonmaru40 <[email protected]> * Portuguese (Brazil) translation Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Korean translation Co-authored-by: Enoch <[email protected]> * Update menu.ts * Update menu.ts [Localization(it)] * Changed most .getNameToRender() instance to getPokemonNameWithAffix() * Changed wild encounter messages back to just use the name without affix. * Added localization for the party ui rename selection * Escaping nickname characters to support all characters * Better Error handling * Update src/field/pokemon.ts Co-authored-by: flx-sta <[email protected]> --------- Co-authored-by: Lugiad' <[email protected]> Co-authored-by: Yonmaru40 <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: Enoch <[email protected]> Co-authored-by: Niccolò <[email protected]> Co-authored-by: flx-sta <[email protected]> * [Sprite] Show Partner Eevee variants (#3097) * [Sprite] Show Partner Eevee variants Taken from non-partner Eevee * [Sprite] Show Partner Eevee variants Taken from non-partner Eevee * [Sprite] Show Partner Eevee variants * Allow Necrozma forms to play their special music (#3054) * [BUG] fixing multi-hit and move messages on faint (#2981) * fixing order of messages, scences, to render messages before fainting * updated fix for effectiveness text rendering order for multi hit moves * fixing messages not appearing for multi-hit moves on faint * updated multi-hit condition) * fixing PR conflicts * adding comments and FaintPhase setPhaseQueueSplice bug, fixing overrides merge conflict * writing better comments * removing space diff in overrides * adding fainting check for self damage moves * emergency fixing broken last commit * additional comments for multi-hit problem * updating comments, jsdoc style * fixing linter, destiny bond errors * splitting up varaible comments to be in JSDoc format * fixing tests and merge mistakes * adding rendering of multihit moves that only hit once * fixing comment formatting_tabs and spaces --------- Co-authored-by: Benjamin Odom <[email protected]> * [Bug] Sheer Force/Serene Grace Flyout Bugfix (#2496) * Disable Show Ability for Serene Grace and Sheer Force when opponent calculates targetBenefitScore * Add comment and definition to argument * [Visual] Achievement icons (#2617) * Text Changes to MonoGen Challenges * Item Texture Files * MonoGen Ribbons added * Resolving merge conflict * Updated texture files? I think * Changed image names and added new localizations for syntax * Removed unused ribbons * [Feature] replace bug-report template with form (#2772) * replace bug-report template with form * update bug_report.yml * add palceholders for data & session file * Update item atlas * Update item atlas again This time, after merging main into the PR. * [Sprite] Show Partner Eevee variants (#3097) * [Sprite] Show Partner Eevee variants Taken from non-partner Eevee * [Sprite] Show Partner Eevee variants Taken from non-partner Eevee * [Sprite] Show Partner Eevee variants * Merged with beta's new items * Fixed typedoc issues * Removing localizations * Text Changes to MonoGen Challenges * Item Texture Files * MonoGen Ribbons added * Resolving merge conflict * Updated texture files? I think * Changed image names and added new localizations for syntax * Removed unused ribbons * Update item atlas * [Feature] replace bug-report template with form (#2772) * replace bug-report template with form * update bug_report.yml * add palceholders for data & session file * Update item atlas again This time, after merging main into the PR. * Merged with beta's new items * Fixed typedoc issues * Removing localizations * Allow Necrozma forms to play their special music (#3054) * Allow Necrozma forms to play their special music (#3054) * MonoGen Ribbons added * Text Changes to MonoGen Challenges * Item Texture Files * MonoGen Ribbons added * Updated texture files? I think * Changed image names and added new localizations for syntax * Fixed typedoc issues * Revert "Text Changes to MonoGen Challenges" This reverts commit 3bf79acc6a797b0e28e68e113e644b30096ea9ce. * Text Changes to MonoGen Challenges * Item Texture Files * MonoGen Ribbons added * Resolving merge conflict * Updated texture files? I think * Changed image names and added new localizations for syntax * Removed unused ribbons * Update item atlas * [Feature] replace bug-report template with form (#2772) * replace bug-report template with form * update bug_report.yml * add palceholders for data & session file * Update item atlas again This time, after merging main into the PR. * Merged with beta's new items * Fixed typedoc issues * Removing localizations * Text Changes to MonoGen Challenges * Item Texture Files * MonoGen Ribbons added * Resolving merge conflict * Updated texture files? I think * Changed image names and added new localizations for syntax * Removed unused ribbons * Update item atlas * Update item atlas again This time, after merging main into the PR. * Merged with beta's new items * Fixed typedoc issues * Removing localizations * MonoGen Ribbons added * Text Changes to MonoGen Challenges * Item Texture Files * MonoGen Ribbons added * Updated texture files? I think * Changed image names and added new localizations for syntax * Fixed typedoc issues * Revert "Text Changes to MonoGen Challenges" This reverts commit 3bf79acc6a797b0e28e68e113e644b30096ea9ce. * Please fix this. * Revert "[Feature] replace bug-report template with form (#2772)" This reverts commit aa69b107778123b2173bee6130e5d172d201b637. --------- Co-authored-by: Frutescens <info@laptop> Co-authored-by: flx-sta <[email protected]> Co-authored-by: Madmadness65 <[email protected]> Co-authored-by: chaosgrimmon <[email protected]> Co-authored-by: Madmadness65 <[email protected]> * Re-add changes accidentally deleted by #2617 * Fix some broken images in item atlas & achievement Fixed the broken sprites in the item atlas, and fixed the Baton Pass achievement to use the Baton item now (it was broken by the Leek being renamed). Also resized the Baton item image to 32*32, like all the other items. * fix: Remove unnecessary cookie setting in removeCookie function * fix: Update removeCookie function to use Max-Age=-1 instead of Expires header The removeCookie function was updated to use the Max-Age=-1 attribute instead of setting the Expires header to a past date. This change ensures that the cookie is immediately expired when removed, preventing any potential login loops. Additionally, a legacy cookie without a domain was added to handle older cookies. This commit resolves the unnecessary cookie setting in the removeCookie function. * [QoL] Starter UI selection update to allow removing specific pokemon from party (#1983) * Initial commits with logic to remove starters if they're in your party. Still need to make it work so that the starter selection cursor disappears when a starter is unselected * Updated code to be able to remove pokemon, including the side icons and cursor locations * Fixed popstarter to work with any index * Updating code to allow navigation of starter icons * Updating code to allow navigation of party starter icons * Updaing navigation of party icons * Updated logic to fix incorrect icon in top left of pokemon options when navigating the starter icons * Updated logic to include the ability to navigate and interact with the starter icons * Forgot to push the actual starter-select-ui-handler. Might be a bit hard to test things out without that :) * Removed some unnecessary comments * Fixed small bug with not being able to move from the far right to the gen selection when the starter icons were empty * Updated code to not be using a method to generate the party menu and made it more like it used to be. This should help with merge conflicts in the future * I committed the merged version but forgot to make the starter-select-ui-handler staged after making the changes * Accidentally broke challenges that had a specific typing requirement with last commit. This should fix it * Changed how navigation worked based on popular demand * Fixed code review comments * Accidentally left in a whole block of commented code. Intentionally removing it now * Started adding logic for mono type challenge runs to not break the game if the user tries to start a run with an invalid party * Updated the text to say the party is invalid * Updated logic to make invalid pokemon greyed out when no valid pokemon are in your party * Added comments on some code * Updated locales to include the key for trying to start with invalid parties during a challenge * Fixed some code from a bad merge where a challenge related param that was previously a number now needed to be a boolean and wasn't * Removed comment as per review * [Bug] Ability changing on evolution fix (#2995) * Prevent Pokemon with their second ability from evolving into their HA * Add check for fusions too * Localization(pt): Updated move.ts (#3078) * Localization(pt): Updated move.ts and fixed King's Shield * more fixes * [Bug] Enemy pokemon's Harvest creates berry icons on the player's side when triggered (#3077) * [Bug] Fix hustle not applying attack boost (#3101) * [Sprite] Mega Latis using opposite's eye colour (#3102) * [Sprite] Mega Latis using opposite eyes Taken from counterpart Lati * [Sprite] Update Mega Latios eyes * [Sprite] Update Mega Latias eyes * [Sprite] Mega Latias duplicated palette value Colour taken from non-exp Mega Latias * [Bug] Fix Thousand Arrows not hitting targets under the effects of Magnet Rise (#3100) * Fix Thousand Arrows not hitting through Magnet Rise * Add integration test for Thousand Arrows vs. Magnet Rise * ESLint * Remove unnecessary checks in integration tests * [Move] Aeroblast is a wind move (#3109) * Hardcoded Pokemon should have proper names * Aeroblast is a wind move * [Refactor] Replaces the single and double battles overrides with a single override (#3104) `SINGLE_BATTLE_OVERRIDE` and `DOUBLE_BATTLE_OVERRIDE` are now `BATTLE_TYPE` Also updates all uses of the old overrides with the new one * fix `Overrides` capitalization (#3111) * [Balance] More TM fixes (#3081) * More TM fixes * Leaf Storm * Removed sexy matcha * [Refactor] Code readability update (#3085) * Clean up/clarify `src/field/pokemon.ts` a bit Code provided by DerTapp on Discord * Update `PokemonSpeciesForm.getAbilityCount()` * Update `PokemonSpeciesForm.getAbility()` * Add explicit `Abilities.NONE` checks * Add tests * Add jsdoc and implement test suggestions * [Move] Implement Stockpile, Spit Up, Swallow (#2960) * feat: Implement Stockpile, Spit Up, Swallow * chore: Minor, likely unnecessary null checks * feat: Localization * Undo non-English localizations (unsure if they went through proper channels) * ko localization from @EnochG1 Co-authored-by: Enoch <[email protected]> * linting fix * add tests, tiny (non-functional) tweaks * Remove unnecessary cast * Update src/data/move.ts (oops) * remove some unnecessary comments, rename something for clarity --------- Co-authored-by: Enoch <[email protected]> * [Bug] Remove ability swap code in `PlayerPokemon.evolve()` (#3113) * [Test] Add test for rollout move (#3114) * add test for rollout move Co-authored-by: Zach Day <[email protected]> * fix tests still using `SINGLE_BATTLE_OVERRIDE` --------- Co-authored-by: Zach Day <[email protected]> * [Bug][Beta] Fix Hyper Beam, etc. permanently recharging (#3115) * Fix Hyper Beam, etc. permanently recharging * Fix override in hyper beam test * [QoL] New Starter Select UI with Filter (#2916) * update images for new UI * add updated starter UI with filter code * update starter-select test code * update win filter condition to pass test * remove unnecessary console log * update test code to match current filter UI * merge update * apply bugfix & chrry-pick small issues fix which are handled beta branch * resolve conflicts * fix lint errors * Fixed a bug where the target location for escaping using the left and right buttons on the starter button did not account for scrolling * update filter bar label color change when activated * fix lint error * fix lint * fix octolock.text.ts. it looks override import error. idk why it is happend in this PR. but it looks ok now * add passive dropdown in unlocks filter * fix lint * fix double button sound bug. refactoring genSpecies -> allSpecies, starterContainers -> starterContainer which are remove unnecessary generation axis * optimize updateStarterValueLabel function which is bottleneck of UI update latency * apply translation of gen filter label. fix lint * add # candies sort option * merge beta * resolve confilcts * fix offset of starter and start cursor * make compatible with starter UI * add missing feature * add images for legacy UI. adjust the position and size of the starterContainerWindow * [Localization] Implement Form localization (#3030) * Implement Pokemon forms localization * Update French pokemon-form.ts * Update French pokemon-form.ts * Update pokemon-form.ts * Add battle forms korean translation from returntoice Co-authored-by: returntoice <[email protected]> * Add cosplay forms korean translation from returntoice Co-authored-by: returntoice <[email protected]> * Add pichu form korean translation from returntoice Co-authored-by: returntoice <[email protected]> * Add castform forms korean translation by returntoice Co-authored-by: returntoice <[email protected]> * Add remaining forms korean translation by returntoice Co-authored-by: returntoice <[email protected]> * French typo corrections pokemon-form.ts * Update Korean pokemon-form.ts * Modify froakiBattleBond like rockruff of OwnTempo case, it is froakie, not greninja. * Modify zygardePc Power construct is more important information Switch its position to 50% or 10% to avoid overlapping with the sprite * Modify mispelling * Added german forms * Changed Gigadynamax and Unendynamax so it fits at all * Add partner pikachu and eevee form localization * Add mimikyu forms localization * Partner Pikachu, Partner Evoli und Mimikyu Formen hinzugefügt * Update pokemon-form.ts * Update partners * Fix conflicts * Fix useless ? by flx-sta Co-authored-by: flx-sta <[email protected]> * Fix switch use by flx-sta * Fix conflicts * Please work !!!!!!! * Update src/locales/fr/pokemon-form.ts Co-authored-by: Lugiad' <[email protected]> * Update src/locales/fr/pokemon-form.ts Co-authored-by: Lugiad' <[email protected]> * Add pt_br primal localization Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Add pt_br pikachu localization Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Add pt_br castform localization Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Add pt_br 3g localization Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Add zh_cn localization Co-authored-by: Yonmaru40 <[email protected]> * Add pt_br other localization Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> * Add es castform localization Co-authored-by: InnocentGameDev <[email protected]> * Add es burmy localization Co-authored-by: InnocentGameDev <[email protected]> * Add es shellos localization Co-authored-by: InnocentGameDev <[email protected]> * Add es rotom localization Co-authored-by: InnocentGameDev <[email protected]> * Add es basculin localization Co-authored-by: InnocentGameDev <[email protected]> * Add es deerling localization Co-authored-by: InnocentGameDev <[email protected]> * Add es froakie localization Co-authored-by: InnocentGameDev <[email protected]> * Add es scatterbug localization Co-authored-by: InnocentGameDev <[email protected]> * Add es furfrou localization Co-authored-by: InnocentGameDev <[email protected]> * Add es xerneas localization Co-authored-by: InnocentGameDev <[email protected]> * Add es zygarde localization Co-authored-by: InnocentGameDev <[email protected]> * Add es pumpkaboo localization Co-authored-by: InnocentGameDev <[email protected]> * Add es flabebe localization Co-authored-by: InnocentGameDev <[email protected]> * Add es oricorio localization Co-authored-by: InnocentGameDev <[email protected]> * Add es minior localization Co-authored-by: InnocentGameDev <[email protected]> * Add es magearna localization Co-authored-by: InnocentGameDev <[email protected]> * Add es marshadow localization Co-authored-by: InnocentGameDev <[email protected]> * Add es sinistea ocalization Co-authored-by: InnocentGameDev <[email protected]> * Add es eiscue localization Co-authored-by: InnocentGameDev <[email protected]> * Add es indeedee localization Co-authored-by: InnocentGameDev <[email protected]> * Add es rockruff localization Co-authored-by: InnocentGameDev <[email protected]> * Add es mimikyu localization Co-authored-by: InnocentGameDev <[email protected]> * Add es zarude localization Co-authored-by: InnocentGameDev <[email protected]> * Add es squawkabilly localization Co-authored-by: InnocentGameDev <[email protected]> * Add es tatsugiri localization Co-authored-by: InnocentGameDev <[email protected]> * Add es gimmighoul localization Co-authored-by: InnocentGameDev <[email protected]> * Add es poltchageit localization Co-authored-by: InnocentGameDev <[email protected]> * Add es paldeaTauros localization Co-authored-by: InnocentGameDev <[email protected]> * Add es primal localization Co-authored-by: InnocentGameDev <[email protected]> * Add es pikachu localization Co-authored-by: InnocentGameDev <[email protected]> * Add es partner localization Co-authored-by: InnocentGameDev <[email protected]> * Fix typedocs error * Fix typedocs error * cn form prefix added Co-authored-by: Yonmaru40 <[email protected]> * Fix german translate error * Fix typo Zh_CN Co-authored-by: mercurius-00 <[email protected]> * Update pokemon-form.ts [Localization(it)] * Update src/locales/es/pokemon-form.ts Co-authored-by: InnocentGameDev <[email protected]> * Fix megas forms bug and add forgotten forms * Fix wrong ko config * Add fr localization for new forms Co-authored-by: Lugiad' <[email protected]> * Add de localization for new forms Co-authored-by: Jannik Tappert <[email protected]> * Remove forgotten debug line Co-authored-by: Jannik Tappert <[email protected]> * Optimize battle forms * Update pokemon-form.ts (additional forms, italian localization) * The same typo is in the zh_TW placeholder text too. Co-authored-by: Madmadness65 <[email protected]> * Fix forgotten megaY Co-authored-by: Jannik Tappert <[email protected]> * Add capitalizeString to utils * Fix typedoc error * Update src/data/pokemon-species.ts Co-authored-by: Jannik Tappert <[email protected]> * Add ko localization for new forms Co-authored-by: MrWaterT <[email protected]> --------- Co-authored-by: Lugiad <[email protected]> Co-authored-by: returntoice <[email protected]> Co-authored-by: Mr.WaterT <[email protected]> Co-authored-by: MrWaterT <[email protected]> Co-authored-by: Jannik Tappert <[email protected]> Co-authored-by: flx-sta <[email protected]> Co-authored-by: Benjamin Odom <[email protected]> Co-authored-by: José Ricardo Fleury Oliveira <[email protected]> Co-authored-by: Yonmaru40 <[email protected]> Co-authored-by: InnocentGameDev <[email protected]> Co-authored-by: EnochG1 <[email protected]> Co-authored-by: mercurius-00 <[email protected]> Co-authored-by: Niccolò <[email protected]> Co-authored-by: Madmadness65 <[email protected]> * [Move] Fully implement Jungle Healing/Lunar Blessing status heal (#2785) * [Bug] Fix tags not resetting…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes?
Some non-functional changes are made to improve the readability of the code in
src/field/pokemon.ts(this code provided by DerTapp on Discord) andsrc/data/pokemon-species.ts(by me).Why am I doing these changes?
A convoluted nested ternary was noticed while looking through the code.
What did change?
Nested ternary replaced with commented if/else blocks in
src/field/pokemon.ts.Nested ternaries in
PokemonSpeciesForm.getAbilityCount()andPokemonSpeciesForm.getAbility()changed to if/then blocks insrc/data/pokemon-species.ts. These weren't that bad, but I'm not a fan of nested ternariesHow to test the changes?
Uh... play the game? All of the tests still pass and this should theoretically be entirely non-functional changes.
Checklist
npm run test)[ ] Are the changes visual?[ ] Have I provided screenshots/videos of the changes?