Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the walrus operator for Python 3.6 compatibility #450

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Remove the walrus operator for Python 3.6 compatibility #450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 52 additions & 42 deletions tests/unit/test_changelog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,47 +257,35 @@ def test_suse_style_changelog_parse():
"changelog",
data=[
"-------------------------------------------------------------------",
(
hdr1 := "Tue Dec 17 14:21:37 UTC 2024 - "
+ (dc := "Dan Čermák <[email protected]>")
),
"Tue Dec 17 14:21:37 UTC 2024 - Dan Čermák <[email protected]>",
"",
(content1 := "- First version"),
"- First version",
"",
"-------------------------------------------------------------------",
(hdr2 := f"Mon Nov 4 17:47:23 UTC 2024 - {dc}"),
"Mon Nov 4 17:47:23 UTC 2024 - Dan Čermák <[email protected]>",
"",
(content2 := "- # [0.9.37] - September 4th, 2024"),
"- # [0.9.37] - September 4th, 2024",
"",
"-------------------------------------------------------------------",
(
hdr3 := "Fri May 17 09:14:20 UTC 2024 - "
+ "Dominique Leuenberger <[email protected]>"
),
"Fri May 17 09:14:20 UTC 2024 - Dominique Leuenberger <[email protected]>",
"",
(content3 := "- Use %patch -P N instead of deprecated %patchN syntax."),
"- Use %patch -P N instead of deprecated %patchN syntax.",
"",
"-------------------------------------------------------------------",
(
hdr4 := "Mon Oct 10 13:27:24 UTC 2022 - Stephan Kulow <[email protected]>"
),
"Mon Oct 10 13:27:24 UTC 2022 - Stephan Kulow <[email protected]>",
"",
(content4_1 := "updated to version 0.9.28"),
(content4_2 := " see installed CHANGELOG.md"),
"updated to version 0.9.28",
" see installed CHANGELOG.md",
"",
"",
"-------------------------------------------------------------------",
(
hdr5 := "Fri Jun 25 07:31:34 UTC 2021 - Dan Čermák <[email protected]>"
),
"Fri Jun 25 07:31:34 UTC 2021 - Dan Čermák <[email protected]>",
"",
(content5_1 := "- New upstream release 0.9.26"),
"- New upstream release 0.9.26",
"",
(content5_2 := " - Add support for Ruby 3.0 and fix tests"),
(
content5_3 := " - Fix support for `frozen_string_literal: false`"
+ " magic comments (#1363)"
),
" - Add support for Ruby 3.0 and fix tests",
" - Fix support for `frozen_string_literal: false`"
" magic comments (#1363)",
"",
"",
],
Expand All @@ -309,14 +297,28 @@ def test_suse_style_changelog_parse():

for changelog_entry, hdr, content in zip(
changelog,
reversed((hdr1, hdr2, hdr3, hdr4, hdr5)),
reversed(
(
[content1],
[content2],
[content3],
[content4_1, content4_2],
[content5_1, "", content5_2, content5_3],
"Tue Dec 17 14:21:37 UTC 2024 - Dan Čermák <[email protected]>",
"Mon Nov 4 17:47:23 UTC 2024 - Dan Čermák <[email protected]>",
"Fri May 17 09:14:20 UTC 2024 - Dominique Leuenberger <[email protected]>",
"Mon Oct 10 13:27:24 UTC 2022 - Stephan Kulow <[email protected]>",
"Fri Jun 25 07:31:34 UTC 2021 - Dan Čermák <[email protected]>",
)
),
reversed(
(
["- First version"],
["- # [0.9.37] - September 4th, 2024"],
["- Use %patch -P N instead of deprecated %patchN syntax."],
["updated to version 0.9.28", " see installed CHANGELOG.md"],
[
"- New upstream release 0.9.26",
"",
" - Add support for Ruby 3.0 and fix tests",
" - Fix support for `frozen_string_literal: false`"
" magic comments (#1363)",
],
)
),
):
Expand All @@ -336,27 +338,35 @@ def test_suse_style_changelog_parse():
(
datetime.datetime(2021, 6, 25, 7, 31, 34),
"Dan Čermák <[email protected]>",
content_1 := ["", "New upstream release 0.9.26"],
["", "New upstream release 0.9.26"],
ChangelogEntry(
header=_OPENSUSE_CHANGELOG_SEPARATOR
+ "\n"
+ "Fri Jun 25 07:31:34 UTC 2021 - Dan Čermák <[email protected]>",
content=content_1,
header=(
_OPENSUSE_CHANGELOG_SEPARATOR
+ "\n"
+ "Fri Jun 25 07:31:34 UTC 2021 - Dan Čermák <[email protected]>"
),
content=["", "New upstream release 0.9.26"],
),
),
(
datetime.date(2021, 6, 25),
"Dan Čermák <[email protected]>",
content_2 := [
[
"",
"New upstream release 0.26",
"Fixed a major regression in Foo",
],
ChangelogEntry(
header=_OPENSUSE_CHANGELOG_SEPARATOR
+ "\n"
+ "Fri Jun 25 12:00:00 UTC 2021 - Dan Čermák <[email protected]>",
content=content_2,
header=(
_OPENSUSE_CHANGELOG_SEPARATOR
+ "\n"
+ "Fri Jun 25 12:00:00 UTC 2021 - Dan Čermák <[email protected]>"
),
content=[
"",
"New upstream release 0.26",
"Fixed a major regression in Foo",
],
),
),
]
Expand Down
Loading