Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the walrus operator for Python 3.6 compatibility #450

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

nforro
Copy link
Member

@nforro nforro commented Jan 28, 2025

Related to #444.

We still support EL8 and thus Python 3.6. CI didn't catch this because it didn't even run on RHEL8 (dcermak can't run tests (and builds) internally - is there a way for a repo owner to overcome this?).

Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/3d365d3d8f5d42a59abf868cda11aa38

✔️ pre-commit SUCCESS in 1m 48s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 03s
✔️ specfile-tests-pip-deps SUCCESS in 1m 02s

Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dcermak can't run tests (and builds) internally - is there a way for a repo owner to overcome this?

I would say just by manual comment triggering

Copy link
Member

@majamassarini majamassarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is just a test, so it is fine as it is.
But I am wondering why don't move the variables declarations at the beginning of the test, in an old style way, and use them later (instead of repeating the strings?)

@nforro
Copy link
Member Author

nforro commented Jan 28, 2025

I would say just by manual comment triggering

Right, I actually did that on #445 but the test jobs kept erroring so I didn't even try on the other PR. But the incompatibility would have been caught already during build, so I should have done it anyway.

@nforro
Copy link
Member Author

nforro commented Jan 28, 2025

But I am wondering why don't move the variables declarations at the beginning of the test, in an old style way, and use them later (instead of repeating the strings?)

You mean outside of test functions? I think that would make the readability worse.

@nforro nforro added the mergeit Zuul, merge it! label Jan 28, 2025
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/55dea3558272471eba2ac497e0c51901

✔️ pre-commit SUCCESS in 1m 47s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 6d1890a into main Jan 28, 2025
33 of 36 checks passed
@nforro nforro deleted the fix branch January 28, 2025 15:25
@lbarcziova
Copy link
Member

Right, I actually did that on #445 but the test jobs kept erroring so I didn't even try on the other PR. But the incompatibility would have been caught already during build, so I should have done it anyway.

we could also add the checks at least for builds to the required ones for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Zuul, merge it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants