Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ast): enforce doc comments on AST node methods #6714

Merged

Conversation

DonIsaac
Copy link
Collaborator

@DonIsaac DonIsaac commented Oct 20, 2024

Copy link

graphite-app bot commented Oct 20, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@DonIsaac DonIsaac marked this pull request as ready for review October 20, 2024 19:37
@DonIsaac DonIsaac force-pushed the don/10-20-docs_ast_enforce_doc_comments_on_ast_node_methods branch from c49cf04 to 766ef8c Compare October 20, 2024 19:37
@github-actions github-actions bot added A-ast Area - AST C-docs Category - Documentation. Related to user-facing or internal documentation labels Oct 20, 2024
@DonIsaac DonIsaac force-pushed the don/10-20-docs_ast_enforce_doc_comments_on_generated_astbuilder_methods branch from 8f2c8ad to ff37a74 Compare October 20, 2024 19:41
@DonIsaac DonIsaac force-pushed the don/10-20-docs_ast_enforce_doc_comments_on_ast_node_methods branch from 766ef8c to 8c9ac66 Compare October 20, 2024 19:41
Copy link

codspeed-hq bot commented Oct 20, 2024

CodSpeed Performance Report

Merging #6714 will not alter performance

Comparing don/10-20-docs_ast_enforce_doc_comments_on_ast_node_methods (a7dd5aa) with main (abb4ff3)

Summary

✅ 30 untouched benchmarks

@DonIsaac DonIsaac force-pushed the don/10-20-docs_ast_enforce_doc_comments_on_generated_astbuilder_methods branch from ff37a74 to 4c43bb3 Compare October 20, 2024 20:00
@DonIsaac DonIsaac force-pushed the don/10-20-docs_ast_enforce_doc_comments_on_ast_node_methods branch from 8c9ac66 to 2e2fa03 Compare October 20, 2024 20:00
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Oct 21, 2024
Copy link
Member

Boshen commented Oct 21, 2024

Merge activity

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 21, 2024
@DonIsaac DonIsaac force-pushed the don/10-20-docs_ast_enforce_doc_comments_on_generated_astbuilder_methods branch from 4c43bb3 to c711257 Compare October 21, 2024 05:23
@DonIsaac DonIsaac force-pushed the don/10-20-docs_ast_enforce_doc_comments_on_ast_node_methods branch from 2e2fa03 to 8e98780 Compare October 21, 2024 05:23
@DonIsaac DonIsaac added the 0-merge Merge with Graphite Merge Queue label Oct 21, 2024 — with Graphite App
@DonIsaac DonIsaac force-pushed the don/10-20-docs_ast_enforce_doc_comments_on_generated_astbuilder_methods branch from c711257 to 8d27e2d Compare October 21, 2024 05:28
@DonIsaac DonIsaac force-pushed the don/10-20-docs_ast_enforce_doc_comments_on_ast_node_methods branch from 8e98780 to a7dd5aa Compare October 21, 2024 05:29
Base automatically changed from don/10-20-docs_ast_enforce_doc_comments_on_generated_astbuilder_methods to main October 21, 2024 05:33
@graphite-app graphite-app bot merged commit a7dd5aa into main Oct 21, 2024
27 checks passed
@graphite-app graphite-app bot deleted the don/10-20-docs_ast_enforce_doc_comments_on_ast_node_methods branch October 21, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST C-docs Category - Documentation. Related to user-facing or internal documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants