Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ast): enforce doc comments on generated ASTBuilder methods #6713

Conversation

DonIsaac
Copy link
Collaborator

@DonIsaac DonIsaac commented Oct 20, 2024

Copy link

graphite-app bot commented Oct 20, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@DonIsaac DonIsaac marked this pull request as ready for review October 20, 2024 19:37
@github-actions github-actions bot added A-ast Area - AST A-ast-tools Area - AST tools C-docs Category - Documentation. Related to user-facing or internal documentation labels Oct 20, 2024
@DonIsaac DonIsaac force-pushed the don/10-20-docs_ast_enforce_doc_comments_on_jsx_nodes_literal_nodes_and_comments branch from 7238424 to 6cf53c6 Compare October 20, 2024 19:41
@DonIsaac DonIsaac force-pushed the don/10-20-docs_ast_enforce_doc_comments_on_generated_astbuilder_methods branch 2 times, most recently from ff37a74 to 4c43bb3 Compare October 20, 2024 20:00
Copy link

codspeed-hq bot commented Oct 20, 2024

CodSpeed Performance Report

Merging #6713 will not alter performance

Comparing don/10-20-docs_ast_enforce_doc_comments_on_generated_astbuilder_methods (8d27e2d) with main (abb4ff3)

Summary

✅ 30 untouched benchmarks

@DonIsaac DonIsaac force-pushed the don/10-20-docs_ast_enforce_doc_comments_on_jsx_nodes_literal_nodes_and_comments branch from 6cf53c6 to 99c74fc Compare October 21, 2024 00:22
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Oct 21, 2024
Copy link
Member

Boshen commented Oct 21, 2024

Merge activity

  • Oct 20, 10:01 PM EDT: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Oct 20, 10:02 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 20, 10:20 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 20, 10:36 PM EDT: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Oct 21, 1:29 AM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 21, 1:33 AM EDT: A user merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the don/10-20-docs_ast_enforce_doc_comments_on_jsx_nodes_literal_nodes_and_comments branch from 99c74fc to bad8770 Compare October 21, 2024 02:08
Base automatically changed from don/10-20-docs_ast_enforce_doc_comments_on_jsx_nodes_literal_nodes_and_comments to main October 21, 2024 02:13
@github-actions github-actions bot added the A-codegen Area - Code Generation label Oct 21, 2024
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 21, 2024
@DonIsaac DonIsaac force-pushed the don/10-20-docs_ast_enforce_doc_comments_on_generated_astbuilder_methods branch from 4c43bb3 to c711257 Compare October 21, 2024 05:23
@DonIsaac DonIsaac added the 0-merge Merge with Graphite Merge Queue label Oct 21, 2024 — with Graphite App
@DonIsaac DonIsaac force-pushed the don/10-20-docs_ast_enforce_doc_comments_on_generated_astbuilder_methods branch from c711257 to 8d27e2d Compare October 21, 2024 05:28
@graphite-app graphite-app bot merged commit 8d27e2d into main Oct 21, 2024
26 checks passed
@graphite-app graphite-app bot deleted the don/10-20-docs_ast_enforce_doc_comments_on_generated_astbuilder_methods branch October 21, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST A-ast-tools Area - AST tools A-codegen Area - Code Generation C-docs Category - Documentation. Related to user-facing or internal documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants