Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: drop go generate from ci pipeline #10337

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 4 additions & 24 deletions .drone.star
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,7 @@ def restoreGoBinCache():
]

def testOcis(ctx):
steps = skipIfUnchanged(ctx, "unit-tests") + restoreGoBinCache() + makeGoGenerate("") + [
steps = skipIfUnchanged(ctx, "unit-tests") + restoreGoBinCache() + [
{
"name": "golangci-lint",
"image": OC_CI_GOLANG,
Expand Down Expand Up @@ -584,7 +584,7 @@ def testOcis(ctx):
}

def scanOcis(ctx):
steps = skipIfUnchanged(ctx, "unit-tests") + restoreGoBinCache() + makeGoGenerate("") + [
steps = skipIfUnchanged(ctx, "unit-tests") + restoreGoBinCache() + [
{
"name": "govulncheck",
"image": OC_CI_GOLANG,
Expand Down Expand Up @@ -626,7 +626,6 @@ def buildOcisBinaryForTesting(ctx):
},
"steps": skipIfUnchanged(ctx, "acceptance-tests") +
makeNodeGenerate("") +
makeGoGenerate("") +
build() +
rebuildBuildArtifactCache(ctx, "ocis-binary-amd64", "ocis/bin"),
"trigger": {
Expand Down Expand Up @@ -1399,8 +1398,7 @@ def dockerRelease(ctx, arch, repo, build_type):
"arch": arch,
},
"steps": skipIfUnchanged(ctx, "build-docker") +
makeNodeGenerate("") +
makeGoGenerate("") + [
makeNodeGenerate("") + [
{
"name": "build",
"image": OC_CI_GOLANG,
Expand Down Expand Up @@ -1544,8 +1542,7 @@ def binaryRelease(ctx, arch, build_type, target, depends_on = []):
"arch": "amd64",
},
"steps": skipIfUnchanged(ctx, "build-binary") +
makeNodeGenerate("") +
makeGoGenerate("") + [
makeNodeGenerate("") + [
{
"name": "build",
"image": OC_CI_GOLANG,
Expand Down Expand Up @@ -2020,23 +2017,6 @@ def makeNodeGenerate(module):
},
]

def makeGoGenerate(module):
if module == "":
make = "make"
else:
make = "make -C %s" % (module)
return [
{
"name": "generate go",
"image": OC_CI_GOLANG,
"commands": [
"retry -t 3 '%s ci-go-generate'" % (make),
],
"environment": DRONE_HTTP_PROXY_ENV,
"volumes": [stepVolumeGo],
},
]

def notify(ctx):
status = ["failure"]
channel = config["rocketchat"]["channel"]
Expand Down