Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: drop go generate from ci pipeline #10337

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rhafer
Copy link
Contributor

@rhafer rhafer commented Oct 17, 2024

All the files generated by the ci-go-generate target should already be tracked in git. So there is not need to run it (multiple times) in the ci.

All the files generated by the ci-go-generate target should already be
tracked in git. So there is not need to run it (multiple times) in the ci.
Copy link

update-docs bot commented Oct 17, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@rhafer
Copy link
Contributor Author

rhafer commented Oct 17, 2024

It might make sense to just add a single make ci-go-generate step and fail if that generates a diff with the git checkout.

Copy link

sonarcloud bot commented Oct 17, 2024

@micbar
Copy link
Contributor

micbar commented Oct 17, 2024

Imho buf generate is not needed in the docs-generate step too.

@micbar
Copy link
Contributor

micbar commented Oct 17, 2024

We should commit the protobuf docs

@rhafer
Copy link
Contributor Author

rhafer commented Oct 17, 2024

We should commit the protobuf docs

Fine with me. But then we should IMO still have at least one make ci-go-generate call in the CI to make sure that nothing was forgotten to commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants