feat: Making giveItem more intuitive #1819
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before when giving a stack of items to another player an error would be given if the exact amount wasn't specified in the count box. A single item was given when "0" was put in the count box. With this change, if 0 is given the entire stack will be given, if an amount greater than the stack is used in the count box then the entire stack will be given. This change is a more natural change than how it was previously being used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before when giving a stack of items to another player an error would be given if the exact amount wasn't specified in the count box.
A single item was given when "0" was put in the count box which didn't feel intuitive.
With this change, if 0 is given the entire stack will be given, if an amount greater than the stack is used in the count box then the entire stack will be given, if somehow a negative is given an error is generated.
This change gives a more natural user experience.