Fix: SWD no-response data phase handling #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, following discussion on the BMD channel on 1b² Discord, we address ORBTrace's handling of the SWD no-response data phase which was previously not being generated.
This phase must be generated per ADIv5.2 §B4.2.5 (Protocol error response) subsection "Host response to protocol errors", first paragraph - "If the host does not receive an expected response from the target, it must not drive the line for at least the length of any potential data phase and then attempt a line reset". Otherwise targets get deeply unhappy and become unrecoverable by protocol recovery.