Fix #1736: Add Bazel Linter

.github/workflows/main.yml

@@ -38,12 +38,22 @@ jobs:
         echo Using Bufbuild version $BUFVERSION
         curl -sSL https://github.com/bufbuild/buf/releases/download/$BUFVERSION/buf-$(uname -s)-$(uname -m) > buf
         chmod a+x buf
+
+    - name: Download Buildifier
+      run: |
+        BUILDIFIER="3.4.0"
+        echo Using Buildifier version $BUILDIFIER
+        curl -sSLO https://github.com/bazelbuild/buildtools/releases/download/$BUILDIFIER/buildifier > buildifier
+        chmod a+x buildifier
 
     - name: Kotlin lint check
       run: ./ktlint --android domain/src/**/*.kt utility/src/**/*.kt data/src/**/*.kt app/src/**/*.kt testing/src/**/*.kt && echo "Lint completed successfully"
 
     -  name: Protobuf lint check
        run: ./buf check lint --input=model/src/main/proto --input-config buf.yaml && echo "Protobuf lint check completed successfully"
+
+    - name: Bazel lint check
+      run: ./buildifier --lint=warn --mode=check --warnings=all -r app data domain model testing utility tools BUILD.bazel WORKSPACE oppia_android_test.bzl
 
   robolectric_tests:
     name: Robolectric Tests (Non-App Modules)

BUILD.bazel

@@ -1,3 +1,5 @@
+load("@rules_android//android:rules.bzl", "android_binary")
+
 # TODO(#1532): Rename file to 'BUILD' post-Gradle.
 # TODO(#1640): Move binary manifest to top-level package post-Gradle.
 android_binary(
@@ -7,10 +9,10 @@ android_binary(
     manifest = "//app:src/main/AndroidManifest.xml",
     manifest_values = {
         "applicationId": "org.oppia.android",
-        "versionCode": "0",
-        "versionName": "0.1-alpha",
         "minSdkVersion": "19",
         "targetSdkVersion": "29",
+        "versionCode": "0",
+        "versionName": "0.1-alpha",
     },
     multidex = "native",  # TODO(#1875): Re-enable legacy for optimized release builds.
     deps = [

WORKSPACE

@@ -2,9 +2,8 @@
 This file lists and imports all external dependencies needed to build Oppia Android.
 """
 
-load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
-load("@bazel_tools//tools/build_defs/repo:jvm.bzl", "jvm_maven_import_external")
 load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository")
+load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
 
 # Android SDK configuration. For more details, see:
 # https://docs.bazel.build/versions/master/be/android.html#android_sdk_repository
@@ -14,6 +13,17 @@ android_sdk_repository(
     api_level = 28,
 )
 
+RULES_ANDROID_TAG = "0.1.1"
+
+RULES_ANDROIDL_SHA = "cd06d15dd8bb59926e4d65f9003bfc20f9da4b2519985c27e190cddc8b7a7806"
+
+http_archive(
+    name = "rules_android",
+    sha256 = RULES_ANDROIDL_SHA,
+    strip_prefix = "rules_android-%s" % RULES_ANDROID_TAG,
+    urls = ["https://github.com/bazelbuild/rules_android/archive/v0.1.1.zip"],
+)
+
 # Add support for JVM rules: https://github.com/bazelbuild/rules_jvm_external
 RULES_JVM_EXTERNAL_TAG = "2.9"
 
@@ -50,12 +60,10 @@ kotlin_repositories()
 
 kt_register_toolchains()
 
-"""
-The proto_compiler and proto_java_toolchain bindings load the protos rules needed for the model
-module while helping us avoid the unnecessary compilation of protoc. Referecences:
-- https://github.com/google/startup-os/blob/5f30a62/WORKSPACE#L179-L187
-- https://github.com/bazelbuild/bazel/issues/7095
-"""
+# The proto_compiler and proto_java_toolchain bindings load the protos rules needed for the model
+# module while helping us avoid the unnecessary compilation of protoc. Referecences:
+# - https://github.com/google/startup-os/blob/5f30a62/WORKSPACE#L179-L187
+# - https://github.com/bazelbuild/bazel/issues/7095
 
 bind(
     name = "proto_compiler",