Fix #1736: Add Bazel Linter #2048

anandwana001 · 2020-10-27T05:11:56Z

Explanation

Fixes #1736: added linter for bazel

Checklist

The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
The PR follows the style guide.
The PR does not contain any unnecessary auto-generated code from Android Studio.
The PR is made from a branch that's not called "develop".
The PR is made from a branch that is up-to-date with "develop".
The PR's branch is based on "develop" and not on any other branch.
The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

app/BUILD.bazel

.github/workflows/main.yml

app/BUILD.bazel

vinitamurthi

LGTM!

BenHenning · 2020-11-17T02:21:26Z

Will need to take a look at this tomorrow. Sorry for the delay.

BenHenning

Thanks @anandwana001! Took a pass.

WORKSPACE

app/BUILD.bazel

app/test_with_resources.bzl

model/src/main/proto/format_import_proto_library.bzl

oppia_android_test.bzl

BenHenning · 2021-01-26T01:51:41Z

That sounds fine @anandwana001. Thanks for the initial investigation work. Since we're taking that approach, please make sure that:

There's an issue tracking specific pre-push hook support for Buildifier
That this PR is updated to not include pre-push hook stuff
We have sufficiently captured the things that worked & didn't work from our investigation, and the initial solution that was tried so that we can continue iterating on that after this PR is merged

Luffy18346 · 2021-02-01T14:20:19Z

@anandwana001 PTAL

anandwana001 · 2021-02-01T14:44:23Z

I will be updating this pr by this week

Luffy18346 · 2021-02-02T15:32:51Z

I will be updating this pr by this week

Ok, thanks

anandwana001 · 2021-02-04T05:16:30Z

pre-push tracking issue - #2107
Updated the description as well, will continue the work from thereafter merging this PR.

… introduce-bazel-linter # Conflicts: # model/BUILD.bazel

BenHenning

Thanks @anandwana001. Just had one comment about how we handle the CI linting check. PTAL.

BenHenning · 2021-02-05T00:53:31Z

.github/workflows/main.yml

@@ -53,7 +53,7 @@ jobs:
       run: ./buf check lint --input=model/src/main/proto --input-config buf.yaml && echo "Protobuf lint check completed successfully"

    - name: Bazel lint check
-      run: ./buildifier --lint=warn --mode=check --warnings=all -r app data domain model testing utility tools BUILD.bazel WORKSPACE oppia_android_test.bzl
+      run: ./buildifier --lint=warn --mode=check --warnings=-native-android,+out-of-order-load,+unsorted-dict-items -r app data domain model testing utility tools BUILD.bazel WORKSPACE oppia_android_test.bzl && echo "Bazel lint check completed successfully"


To clarify: I'm actually suggesting we move to the pattern of running our linters via scripts to avoid duplicating the code between the workflow file & the script. I think adding the pre-push hook in a subsequent PR is fine, but can we also move this to a linter script in this PR to establish that new pattern?

BenHenning

Thanks @anandwana001! This LGTM.

BenHenning · 2021-02-12T05:35:42Z

Looks like a rare test infra flake. Restarting.

… introduce-bazel-linter

bazel lint fix

d33a90b

anandwana001 requested a review from BenHenning as a code owner October 27, 2020 05:11

anandwana001 marked this pull request as draft October 27, 2020 05:12

anandwana001 added 2 commits October 27, 2020 10:48

bazel lint fix

a01bdbb

rules_android

f0d55be

anandwana001 commented Oct 29, 2020

View reviewed changes

app/BUILD.bazel Outdated Show resolved Hide resolved

anandwana001 commented Oct 29, 2020

View reviewed changes

.github/workflows/main.yml Outdated Show resolved Hide resolved

anandwana001 self-assigned this Oct 31, 2020

anandwana001 added 3 commits November 13, 2020 15:54

app package visibility modify

6753a03

exporting app manifest file

8806c0a

target path fix

1668680

anandwana001 requested a review from vinitamurthi November 13, 2020 11:10

anandwana001 assigned vinitamurthi Nov 13, 2020

anandwana001 mentioned this pull request Nov 13, 2020

Fix #1736: Add Bazel Linter to the project #1745

Closed

8 tasks

anandwana001 commented Nov 13, 2020

View reviewed changes

app/BUILD.bazel Show resolved Hide resolved

anandwana001 marked this pull request as ready for review November 13, 2020 11:12

anandwana001 mentioned this pull request Nov 13, 2020

Introduce pre push hook for Bazel #2107

Closed

anandwana001 removed their assignment Nov 13, 2020

vinitamurthi approved these changes Nov 13, 2020

View reviewed changes

anandwana001 assigned BenHenning and unassigned vinitamurthi Nov 13, 2020

BenHenning requested changes Nov 18, 2020

View reviewed changes

BenHenning assigned anandwana001 and unassigned BenHenning Nov 18, 2020

merge develop

9c4a207

anandwana001 marked this pull request as draft December 18, 2020 12:23

anandwana001 added 3 commits January 4, 2021 11:43

nit formatting

b5d2416

nit change

afe258e

nit fix

fde338d

anandwana001 assigned BenHenning Jan 25, 2021

BenHenning assigned anandwana001 and unassigned BenHenning Jan 26, 2021

anandwana001 added 2 commits February 4, 2021 10:57

Merge branch 'develop' of https://github.com/oppia/oppia-android into…

fc70b42

… introduce-bazel-linter # Conflicts: # model/BUILD.bazel

nit fix

14c596c

anandwana001 assigned BenHenning and unassigned anandwana001 Feb 4, 2021

BenHenning requested changes Feb 5, 2021

View reviewed changes

BenHenning assigned anandwana001 and unassigned BenHenning Feb 5, 2021

anandwana001 changed the title ~~Fix #1736: Add Bazel Linter~~ Fix #1736: Add Bazel Linter [Blocked #2101] Feb 5, 2021

anandwana001 added 4 commits February 11, 2021 10:48

merge and resolve conflicts

fac0210

adding scripts

d40e412

putting buildifier error

b4d8be8

fixing buildifier error

0b92e55

anandwana001 assigned BenHenning and unassigned anandwana001 Feb 11, 2021

anandwana001 changed the title ~~Fix #1736: Add Bazel Linter [Blocked #2101]~~ Fix #1736: Add Bazel Linter Feb 11, 2021

BenHenning approved these changes Feb 12, 2021

View reviewed changes

BenHenning assigned anandwana001 and unassigned BenHenning Feb 12, 2021

Merge branch 'develop' of https://github.com/oppia/oppia-android into…

fad6866

… introduce-bazel-linter

anandwana001 enabled auto-merge (squash) February 13, 2021 03:52

anandwana001 merged commit 35f50c5 into oppia:develop Feb 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #1736: Add Bazel Linter #2048

Fix #1736: Add Bazel Linter #2048

anandwana001 commented Oct 27, 2020 •

edited

Loading

vinitamurthi left a comment

BenHenning commented Nov 17, 2020

BenHenning left a comment

BenHenning commented Jan 26, 2021

Luffy18346 commented Feb 1, 2021

anandwana001 commented Feb 1, 2021

Luffy18346 commented Feb 2, 2021

anandwana001 commented Feb 4, 2021 •

edited

Loading

BenHenning left a comment

BenHenning Feb 5, 2021

BenHenning left a comment

BenHenning commented Feb 12, 2021 •

edited

Loading

Fix #1736: Add Bazel Linter #2048

Fix #1736: Add Bazel Linter #2048

Conversation

anandwana001 commented Oct 27, 2020 • edited Loading

Explanation

Checklist

vinitamurthi left a comment

Choose a reason for hiding this comment

BenHenning commented Nov 17, 2020

BenHenning left a comment

Choose a reason for hiding this comment

BenHenning commented Jan 26, 2021

Luffy18346 commented Feb 1, 2021

anandwana001 commented Feb 1, 2021

Luffy18346 commented Feb 2, 2021

anandwana001 commented Feb 4, 2021 • edited Loading

BenHenning left a comment

Choose a reason for hiding this comment

BenHenning Feb 5, 2021

Choose a reason for hiding this comment

BenHenning left a comment

Choose a reason for hiding this comment

BenHenning commented Feb 12, 2021 • edited Loading

anandwana001 commented Oct 27, 2020 •

edited

Loading

anandwana001 commented Feb 4, 2021 •

edited

Loading

BenHenning commented Feb 12, 2021 •

edited

Loading