Skip to content

implemented feedback from product team, finalized new specs, cleanup,…

Sign in for the full log view
GitHub Actions / rubocop failed Aug 20, 2024 in 0s

reviewdog [rubocop] report

reported by reviewdog 🐶

Findings (8)

app/components/work_packages/activities_tab/index_component.rb|54 col 131| Line is too long. [132/130]
app/components/work_packages/activities_tab/journals/empty_component.rb|39 col 9| Useless method definition detected.
app/components/work_packages/activities_tab/journals/empty_component.rb|39 col 9| Remove unnecessary initialize method.
app/components/work_packages/activities_tab/journals/item_component.rb|148 col 13| Tagging a string as html safe may be a security risk.
app/components/work_packages/activities_tab/journals/item_component/details.rb|56 col 9| Assignment Branch Condition size for render_details_header is too high. [<4, 52, 5> 52.39/17]
app/components/work_packages/activities_tab/journals/item_component/details.rb|117 col 9| Assignment Branch Condition size for render_details is too high. [<3, 17, 6> 18.28/17]
app/components/work_packages/activities_tab/journals/item_component/details.rb|146 col 13| Tagging a string as html safe may be a security risk.
app/controllers/work_packages/activities_tab_controller.rb|99 col 3| Assignment Branch Condition size for create is too high. [<1, 26, 7> 26.94/17]

Filtered Findings (7466)

Guardfile|32 col 9| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Guardfile|32 col 35| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Guardfile|40 col 57| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Guardfile|41 col 9| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Guardfile|41 col 57| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Guardfile|42 col 9| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Guardfile|42 col 57| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Guardfile|49 col 102| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/components/activities/item_component.rb|31 col 55| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/admin/attachments_settings_header_component.rb|33 col 5| Call super to initialize state of the parent class.
app/components/admin/quarantined_attachments/row_component.rb|47 col 7| Assignment Branch Condition size for attached_to is too high. [<2, 33, 7> 33.79/17]
app/components/members/delete_member_dialog_component.rb|32 col 62| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/members/delete_work_package_shares_dialog_component.rb|32 col 73| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/members/row_component.rb|32 col 39| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/members/row_component.rb|188 col 5| Assignment Branch Condition size for actions is too high. [<2, 16, 7> 17.58/17]
app/components/members/table_component.rb|32 col 43| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/op_primer/box_collection_component.rb|30 col 9| Missing Lookbook preview for /home/runner/work/openproject/openproject/app/components/op_primer/box_collection_component.rb. Expected preview to exist at /home/runner/work/openproject/openproject/lookbook/previews/op_primer/box_collection_component_preview.rb.
app/components/op_primer/component_collection_component.rb|30 col 9| Missing Lookbook preview for /home/runner/work/openproject/openproject/app/components/op_primer/component_collection_component.rb. Expected preview to exist at /home/runner/work/openproject/openproject/lookbook/previews/op_primer/component_collection_component_preview.rb.
app/components/op_primer/relative_time_component.rb|32 col 9| Missing Lookbook preview for /home/runner/work/openproject/openproject/app/components/op_primer/relative_time_component.rb. Expected preview to exist at /home/runner/work/openproject/openproject/lookbook/previews/op_primer/relative_time_component_preview.rb.
app/components/projects/delete_list_modal_component.rb|31 col 65| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/projects/export_list_modal_component.rb|31 col 65| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/projects/row_component.rb|76 col 5| Assignment Branch Condition size for custom_field_column is too high. [<2, 16, 6> 17.2/17]
app/components/projects/settings/project_custom_field_sections/index_page_header_component.rb|32 col 1| Re-enable OpenProject/AddPreviewForViewComponent cop with # rubocop:enable after disabling it.
app/components/projects/settings/project_custom_field_sections/index_page_header_component.rb|32 col 3| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/queries/sort_by_field_component.rb|31 col 60| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/settings/project_custom_field_sections/dialog_body_form_component.rb|52 col 131| Line is too long. [189/130]
app/components/settings/project_custom_fields/project_custom_field_mapping/new_project_mapping_component.rb|32 col 63| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/settings/project_custom_fields/project_custom_field_mapping/new_project_mapping_form_component.rb|32 col 67| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/settings/project_custom_fields/project_custom_field_mapping/row_component.rb|32 col 51| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/settings/project_custom_fields/project_custom_field_mapping/table_component.rb|32 col 55| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/shares/bulk_permission_button_component.rb|32 col 62| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/shares/bulk_selection_counter_component.rb|32 col 62| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/shares/counter_component.rb|32 col 49| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/shares/empty_state_component.rb|30 col 52| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/shares/invite_user_form_component.rb|30 col 56| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/shares/manage_shares_component.rb|30 col 54| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/shares/modal_body_component.rb|30 col 51| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/shares/permission_button_component.rb|30 col 58| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/shares/project_queries/empty_state_component.rb|31 col 54| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/shares/project_queries/project_access_warning_component.rb|3 col 63| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/shares/project_queries/public_flag_component.rb|33 col 54| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/shares/project_queries/upsale_component.rb|31 col 50| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/shares/share_counter_component.rb|32 col 54| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/shares/share_row_component.rb|32 col 50| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/shares/user_details_component.rb|32 col 53| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/shares/work_packages/modal_upsale_component.rb|31 col 55| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/table_component.rb|34 col 28| Use anonymous keyword arguments forwarding (**).
app/components/table_component.rb|35 col 17| Use anonymous keyword arguments forwarding (**).
app/components/users/profile/activities_component.rb|31 col 54| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/users/profile/attributes_component.rb|31 col 54| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/users/profile/groups_component.rb|31 col 50| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/users/profile/projects_component.rb|31 col 52| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/users/profile/side_panel_component.rb|31 col 53| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/users/profile_component.rb|30 col 49| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/components/work_packages/progress/status_based/modal_body_component.rb|34 col 53| Unnecessary disabling of OpenProject/AddPreviewForViewComponent.
app/contracts/authentication/omniauth_auth_hash_contract.rb|54 col 40| Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.xmlschema, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.httpdate, Time.now.to_i, Time.now.to_f instead.
app/contracts/backups/create_contract.rb|41 col 15| Use find_by instead of dynamic find_by_plaintext_value.
app/contracts/backups/create_contract.rb|61 col 17| Use where(created_at: Time.zone.today..) instead of manually constructing SQL.
app/contracts/concerns/requires_enterprise_guard.rb|41 col 7| Rename has_enterprise to has_enterprise?.
app/contracts/custom_actions/execute_contract.rb|42 col 40| Prefer exists?(id: model.work_package_id) over where(id: model.work_package_id).exists?.
app/contracts/empty_contract.rb|30 col 3| Call super to initialize state of the parent class.
app/contracts/news/delete_contract.rb|29 col 30| Remove redundant ::.
app/contracts/projects/base_contract.rb|99 col 30| Prefer exists?(id: parent.id) over where(id: parent.id).exists?.
app/contracts/relations/base_contract.rb|57 col 5| Assignment Branch Condition size for validate_nodes_relatable is too high. [<0, 17, 3> 17.26/17]
app/contracts/types/base_contract.rb|61 col 60| Use if group.key.blank? instead of unless group.key.present?.
app/contracts/user_preferences/params_contract.rb|82 col 7| Use NotificationSetting.date_alert_settings.intersect?(notifications.flat_map(&:keys)) instead of (NotificationSetting.date_alert_settings & notifications.flat_map(&:keys)).any?.
app/contracts/users/update_contract.rb|51 col 5| Assignment Branch Condition size for at_least_one_admin_is_active is too high. [<0, 19, 6> 19.92/17]
app/controllers/account_controller.rb|90 col 3| Assignment Branch Condition size for lost_password is too high. [<8, 53, 13> 55.15/17]
app/controllers/account_controller.rb|90 col 3| Perceived complexity for lost_password is too high. [15/8]
app/controllers/account_controller.rb|94 col 16| Use find_by instead of dynamic find_by_plaintext_value.
app/controllers/account_controller.rb|112 col 14| Use find_by instead of dynamic find_by_mail.
app/controllers/account_controller.rb|163 col 13| Use find_by instead of dynamic find_by_plaintext_value.
app/controllers/account_controller.rb|173 col 5| Duplicate branch body detected.
app/controllers/account_controller.rb|221 col 3| Assignment Branch Condition size for activate_self_registered is too high. [<5, 24, 6> 25.24/17]
app/controllers/account_controller.rb|301 col 26| Use if session[:auth_source_sso_failure].blank? instead of unless session[:auth_source_sso_failure].present?.
app/controllers/account_controller.rb|349 col 3| Assignment Branch Condition size for register_plain_user is too high. [<5, 24, 3> 24.7/17]
app/controllers/account_controller.rb|364 col 3| Assignment Branch Condition size for register_with_auth_source is too high. [<3, 20, 2> 20.32/17]
app/controllers/account_controller.rb|396 col 3| Assignment Branch Condition size for direct_login is too high. [<5, 16, 5> 17.49/17]
app/controllers/account_controller.rb|422 col 3| Assignment Branch Condition size for password_authentication is too high. [<2, 27, 14> 30.48/17]
app/controllers/account_controller.rb|422 col 3| Perceived complexity for password_authentication is too high. [15/8]
app/controllers/account_controller.rb|427 col 10| Use safe navigation (&.) instead of checking if an object exists before calling the method.
app/controllers/account_controller.rb|443 col 13| Use safe navigation (&.) instead of checking if an object exists before calling the method.
app/controllers/account_controller.rb|520 col 15| Use find_by instead of dynamic find_by_plaintext_value.
app/controllers/activities_controller.rb|92 col 3| Assignment Branch Condition size for determine_subprojects is too high. [<2, 24, 7> 25.08/17]
app/controllers/admin/backups_controller.rb|103 col 5| Use flash.now before render.
app/controllers/admin/backups_controller.rb|117 col 5| Use flash.now before render.
app/controllers/admin/settings/project_custom_field_sections_controller.rb|71 col 7| Redundant else-clause.
app/controllers/admin/settings/project_custom_field_sections_controller.rb|85 col 7| Redundant else-clause.
app/controllers/admin/settings/project_custom_field_sections_controller.rb|99 col 7| Redundant else-clause.
app/controllers/admin/settings/project_custom_fields_controller.rb|126 col 7| Redundant else-clause.
app/controllers/admin/settings/project_custom_fields_controller.rb|141 col 7| Redundant else-clause.
app/controllers/admin/settings/virus_scanning_settings_controller.rb|62 col 5| Assignment Branch Condition size for check_clamav is too high. [<3, 18, 3> 18.49/17]
app/controllers/admin_controller.rb|63 col 3| Assignment Branch Condition size for test_email is too high. [<7, 19, 1> 20.27/17]
app/controllers/application_controller.rb|110 col 19| Prefer string interpolation to string concatenation.
app/controllers/application_controller.rb|287 col 3| Assignment Branch Condition size for find_object_and_scope is too high. [<4, 19, 3> 19.65/17]
app/controllers/application_controller.rb|295 col 29| Prefer string interpolation to string concatenation.
app/controllers/application_controller.rb|306 col 3| Assignment Branch Condition size for find_belongs_to_chained_objects is too high. [<4, 24, 5> 24.84/17]
app/controllers/application_controller.rb|325 col 3| protected (on line 42) does not make singleton methods protected. Use protected inside a class << self block instead.
app/controllers/application_controller.rb|347 col 41| Prefer keyword arguments for arguments with a boolean default value; use use_escaped: true instead of use_escaped = true.
app/controllers/application_controller.rb|373 col 3| protected (on line 42) does not make singleton methods protected. Use protected inside a class << self block instead.
app/controllers/application_controller.rb|449 col 12| Prefer string interpolation to string concatenation.
app/controllers/application_controller.rb|475 col 33| Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.xmlschema, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.httpdate, Time.now.to_i, Time.now.to_f instead.
app/controllers/attribute_help_texts_controller.rb|49 col 3| Assignment Branch Condition size for create is too high. [<4, 18, 3> 18.68/17]
app/controllers/categories_controller.rb|41 col 3| Assignment Branch Condition size for create is too high. [<6, 24, 2> 24.82/17]
app/controllers/categories_controller.rb|77 col 3| Assignment Branch Condition size for destroy is too high. [<3, 18, 5> 18.92/17]
app/controllers/colors_controller.rb|46 col 5| Empty block detected.
app/controllers/concerns/accounts/authentication_stages.rb|30 col 3| Assignment Branch Condition size for successful_authentication is too high. [<5, 20, 6> 21.47/17]
app/controllers/concerns/accounts/authentication_stages.rb|52 col 3| Assignment Branch Condition size for stage_success is too high. [<4, 31, 9> 32.53/17]
app/controllers/concerns/accounts/authentication_stages.rb|87 col 37| Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.xmlschema, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.httpdate, Time.now.to_i, Time.now.to_f instead.
app/controllers/concerns/accounts/authentication_stages.rb|94 col 50| Use any? instead of select.any?.
app/controllers/concerns/accounts/current_user.rb|110 col 7| Use find_by instead of dynamic find_by_rss_key.
app/controllers/concerns/accounts/current_user.rb|121 col 7| Use find_by instead of dynamic find_by_api_key.
app/controllers/concerns/accounts/current_user.rb|127 col 12| Redundant safe navigation detected, use . instead.
app/controllers/concerns/accounts/omniauth_login.rb|74 col 68| Do not use Time.new without zone. Use one of Time.zone.now, Time.current, Time.new.in_time_zone, Time.new.utc, Time.new.getlocal, Time.new.xmlschema, Time.new.iso8601, Time.new.jisx0301, Time.new.rfc3339, Time.new.httpdate, Time.new.to_i, Time.new.to_f instead.
app/controllers/concerns/accounts/omniauth_login.rb|81 col 5| Return false instead of nil in predicate methods.
app/controllers/concerns/accounts/omniauth_login.rb|102 col 3| Assignment Branch Condition size for handle_omniauth_authentication is too high. [<4, 25, 4> 25.63/17]
app/controllers/concerns/accounts/user_consent.rb|54 col 15| Prefer string interpolation to string concatenation.
app/controllers/concerns/accounts/user_limits.rb|103 col 13| Tagging a string as html safe may be a security risk.
app/controllers/concerns/accounts/user_limits.rb|121 col 13| Tagging a string as html safe may be a security risk.
app/controllers/concerns/accounts/user_password_change.rb|36 col 3| Assignment Branch Condition size for change_password_flow is too high. [<2, 17, 4> 17.58/17]
app/controllers/concerns/accounts/user_password_change.rb|93 col 19| Prefer string interpolation to string concatenation.
app/controllers/concerns/auth_source_sso.rb|95 col 5| Use if login.blank? instead of unless login.present?.
app/controllers/concerns/custom_fields/shared_actions.rb|50 col 7| Assignment Branch Condition size for create is too high. [<3, 22, 3> 22.41/17]
app/controllers/concerns/custom_fields/shared_actions.rb|143 col 9| Use each_value instead of each and remove the unused _id block argument.
app/controllers/concerns/member_helper.rb|54 col 3| Perceived complexity for invite_new_users is too high. [10/8]
app/controllers/concerns/member_helper.rb|62 col 13| Use find_by instead of dynamic find_by_mail.
app/controllers/concerns/work_packages/with_split_view.rb|41 col 5| Assignment Branch Condition size for close_split_view is too high. [<1, 17, 0> 17.03/17]
app/controllers/custom_fields_controller.rb|34 col 3| update, destroy, delete_option, reorder_alphabetical are not explicitly defined on the class.
app/controllers/custom_fields_controller.rb|35 col 3| update, create are not explicitly defined on the class.
app/controllers/custom_fields_controller.rb|36 col 3| delete_option is not explicitly defined on the class.
app/controllers/custom_fields_controller.rb|40 col 42| Redundant all detected.
app/controllers/custom_fields_controller.rb|82 col 23| Move locale texts to the locale files in the config/locales directory.
app/controllers/custom_styles_controller.rb|145 col 7| Use flash.now before render.
app/controllers/custom_styles_controller.rb|149 col 7| Use flash.now before render.
app/controllers/custom_styles_controller.rb|163 col 5| Use if @current_theme.blank? instead of unless @current_theme.present?.
app/controllers/custom_styles_controller.rb|192 col 8| Use safe navigation (&.) instead of checking if an object exists before calling the method.
app/controllers/enterprises_controller.rb|45 col 8| Use @current_token.blank? instead of !@current_token.present?.
app/controllers/enterprises_controller.rb|50 col 3| Assignment Branch Condition size for create is too high. [<8, 26, 5> 27.66/17]
app/controllers/errors_controller.rb|14 col 18| Prefer to_s over string interpolation.
app/controllers/forums_controller.rb|49 col 3| Assignment Branch Condition size for show is too high. [<3, 28, 0> 28.16/17]
app/controllers/journals_controller.rb|95 col 18| Consider replacing case-when with a hash lookup.
app/controllers/members_controller.rb|40 col 3| Assignment Branch Condition size for create is too high. [<6, 24, 5> 25.24/17]
app/controllers/messages_controller.rb|44 col 3| Assignment Branch Condition size for show is too high. [<6, 28, 2> 28.71/17]
app/controllers/messages_controller.rb|141 col 3| Assignment Branch Condition size for quote is too high. [<7, 19, 1> 20.27/17]
app/controllers/messages_controller.rb|148 col 17| Prefer string interpolation to string concatenation.
app/controllers/my_controller.rb|122 col 3| Assignment Branch Condition size for generate_rss_key is too high. [<4, 18, 1> 18.47/17]
app/controllers/my_controller.rb|241 col 31| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/controllers/news_controller.rb|42 col 3| Assignment Branch Condition size for index is too high. [<3, 19, 2> 19.34/17]
app/controllers/oauth/applications_controller.rb|51 col 5| Assignment Branch Condition size for create is too high. [<3, 17, 2> 17.38/17]
app/controllers/oauth/auth_base_controller.rb|65 col 14| Use block explicitly instead of block-passing a method object.
app/controllers/onboarding_controller.rb|32 col 3| Assignment Branch Condition size for user_settings is too high. [<5, 17, 1> 17.75/17]
app/controllers/placeholder_users_controller.rb|82 col 3| Assignment Branch Condition size for create is too high. [<6, 20, 3> 21.1/17]
app/controllers/placeholder_users_controller.rb|103 col 3| Assignment Branch Condition size for update is too high. [<6, 17, 3> 18.28/17]
app/controllers/projects/settings/project_custom_fields_controller.rb|61 col 5| Redundant else-clause.
app/controllers/projects/settings/project_custom_fields_controller.rb|75 col 5| Redundant else-clause.
app/controllers/projects/templated_controller.rb|43 col 3| Assignment Branch Condition size for change_templated_action is too high. [<4, 18, 2> 18.55/17]
app/controllers/repositories_controller.rb|54 col 3| Assignment Branch Condition size for show is too high. [<5, 18, 9> 20.74/17]
app/controllers/repositories_controller.rb|54 col 3| Perceived complexity for show is too high. [10/8]
app/controllers/repositories_controller.rb|79 col 3| Assignment Branch Condition size for create is too high. [<4, 18, 3> 18.68/17]
app/controllers/repositories_controller.rb|84 col 26| Prefer string interpolation to string concatenation.
app/controllers/repositories_controller.rb|99 col 3| Assignment Branch Condition size for committers is too high. [<10, 27, 7> 29.63/17]
app/controllers/repositories_controller.rb|102 col 39| Use map { |x| x.last.to_i } instead of map method chain.
app/controllers/repositories_controller.rb|223 col 3| Assignment Branch Condition size for diff is too high. [<8, 18, 8> 21.26/17]
app/controllers/repositories_controller.rb|259 col 61| Within %w/%W, quotes and ',' are unnecessary and may be unwanted in the resulting strings.
app/controllers/repositories_controller.rb|299 col 3| Assignment Branch Condition size for find_repository is too high. [<5, 28, 7> 29.29/17]
app/controllers/repositories_controller.rb|337 col 3| Assignment Branch Condition size for graph_commits_per_month is too high. [<16, 58, 2> 60.2/17]
app/controllers/repositories_controller.rb|338 col 21| Do not use Date.today without zone. Use Time.zone.today instead.
app/controllers/repositories_controller.rb|363 col 35| Do not use Date.today without zone. Use Time.zone.today instead.
app/controllers/repositories_controller.rb|391 col 3| Assignment Branch Condition size for graph_commits_per_author is too high. [<16, 46, 12> 50.16/17]
app/controllers/repositories_controller.rb|391 col 3| Perceived complexity for graph_commits_per_author is too high. [10/8]
app/controllers/repositories_controller.rb|392 col 35| Use where(repository_id: repository.id) instead of manually constructing SQL.
app/controllers/search_controller.rb|110 col 7| Use safe navigation (&.) instead of checking if an object exists before calling the method.
app/controllers/sys_controller.rb|31 col 23| Controllers should subclass ApplicationController.
app/controllers/sys_controller.rb|59 col 3| Assignment Branch Condition size for fetch_changesets is too high. [<3, 18, 5> 18.92/17]
app/controllers/sys_controller.rb|68 col 7| Use safe navigation (&.) instead of checking if an object exists before calling the method.
app/controllers/sys_controller.rb|91 col 8| Use safe navigation (&.) instead of checking if an object exists before calling the method.
app/controllers/sys_controller.rb|107 col 46| Prefer keyword arguments for arguments with a boolean default value; use force: false instead of force = false.
app/controllers/sys_controller.rb|157 col 131| Line is too long. [135/130]
app/controllers/types_controller.rb|63 col 3| Assignment Branch Condition size for create is too high. [<4, 18, 0> 18.44/17]
app/controllers/types_controller.rb|74 col 9| Use flash.now before render.
app/controllers/users_controller.rb|100 col 3| Assignment Branch Condition size for update is too high. [<12, 32, 10> 35.61/17]
app/controllers/users_controller.rb|100 col 3| Perceived complexity for update is too high. [11/8]
app/controllers/users_controller.rb|151 col 3| Assignment Branch Condition size for change_status is too high. [<5, 42, 14> 44.55/17]
app/controllers/users_controller.rb|151 col 3| Perceived complexity for change_status is too high. [14/8]
app/controllers/users_controller.rb|190 col 3| Assignment Branch Condition size for resend_invitation is too high. [<4, 24, 4> 24.66/17]
app/controllers/users_controller.rb|289 col 3| Assignment Branch Condition size for build_user_update_params is too high. [<3, 24, 3> 24.37/17]
app/controllers/users_controller.rb|306 col 7| Use update_params[:password] = params[:user][:password]; update_params[:password_confirmation] = params[:user][:password_confirmation] instead of update_params.merge!( password: params[:user][:password], password_confirmation: params[:user][:password_confirmation] ).
app/controllers/versions_controller.rb|39 col 3| Assignment Branch Condition size for index is too high. [<8, 29, 9> 31.4/17]
app/controllers/versions_controller.rb|39 col 3| Perceived complexity for index is too high. [9/8]
app/controllers/versions_controller.rb|42 col 131| Line is too long. [139/130]
app/controllers/versions_controller.rb|53 col 35| Use .exclude? and remove the negation part.
app/controllers/wiki_controller.rb|152 col 3| Assignment Branch Condition size for update is too high. [<6, 24, 5> 25.24/17]
app/controllers/wiki_controller.rb|182 col 3| Assignment Branch Condition size for rename is too high. [<6, 23, 4> 24.1/17]
app/controllers/wiki_controller.rb|222 col 19| Avoid using OpenStruct; use Struct, Hash, a class or test doubles instead.
app/controllers/wiki_controller.rb|262 col 3| Assignment Branch Condition size for diff is too high. [<2, 18, 2> 18.22/17]
app/controllers/wiki_controller.rb|280 col 3| Assignment Branch Condition size for destroy is too high. [<8, 36, 12> 38.78/17]
app/controllers/wiki_controller.rb|280 col 3| Perceived complexity for destroy is too high. [11/8]
app/controllers/wiki_controller.rb|310 col 7| Move flash[:notice] = I18n.t(:notice_successful_delete) out of the conditional.
app/controllers/wiki_controller.rb|313 col 7| Move flash[:notice] = I18n.t(:notice_successful_delete) out of the conditional.
app/controllers/wiki_controller.rb|355 col 29| Use safe navigation (&.) instead of checking if an object exists before calling the method.
app/controllers/wiki_menu_items_controller.rb|65 col 3| Assignment Branch Condition size for update is too high. [<10, 42, 21> 48.01/17]
app/controllers/wiki_menu_items_controller.rb|65 col 3| Perceived complexity for update is too high. [20/8]
app/controllers/wiki_menu_items_controller.rb|130 col 131| Line is too long. [148/130]
app/controllers/wiki_menu_items_controller.rb|145 col 3| Assignment Branch Condition size for get_data_from_params is too high. [<8, 19, 3> 20.83/17]
app/controllers/work_packages/bulk_controller.rb|59 col 3| Assignment Branch Condition size for destroy is too high. [<2, 19, 2> 19.21/17]
app/controllers/work_packages/moves_controller.rb|113 col 3| Assignment Branch Condition size for prepare_for_work_package_move is too high. [<12, 25, 7> 28.6/17]
app/controllers/work_packages_controller.rb|138 col 18| Use safe navigation (&.) instead of checking if an object exists before calling the method.
app/controllers/workflows_controller.rb|68 col 3| Assignment Branch Condition size for copy is too high. [<7, 55, 18> 58.29/17]
app/controllers/workflows_controller.rb|68 col 3| Perceived complexity for copy is too high. [17/8]
app/forms/custom_fields/inputs/base/input.rb|34 col 3| Call super to initialize state of the parent class.
app/helpers/accessibility_helper.rb|30 col 25| Prefer keyword arguments for arguments with a boolean default value; use condition: true instead of condition = true.
app/helpers/accessibility_helper.rb|32 col 131| Line is too long. [140/130]
app/helpers/accessibility_helper.rb|34 col 131| Line is too long. [139/130]
app/helpers/accessibility_helper.rb|41 col 115| Tagging a string as html safe may be a security risk.
app/helpers/accounts_helper.rb|8 col 7| Do not use instance variables in helpers.
app/helpers/announcements_helper.rb|3 col 8| Do not use instance variables in helpers.
app/helpers/application_helper.rb|45 col 50| Do not use instance variables in helpers.
app/helpers/application_helper.rb|90 col 5| Prefer string interpolation to string concatenation.
app/helpers/application_helper.rb|113 col 27| Do not use Date.today without zone. Use Time.zone.today instead.
app/helpers/application_helper.rb|114 col 59| Do not use Date.today without zone. Use Time.zone.today instead.
app/helpers/application_helper.rb|125 col 3| Assignment Branch Condition size for project_nested_ul is too high. [<3, 23, 6> 23.96/17]
app/helpers/application_helper.rb|146 col 7| Tagging a string as html safe may be a security risk.
app/helpers/application_helper.rb|155 col 3| Assignment Branch Condition size for labeled_check_box_tags is too high. [<8, 22, 3> 23.6/17]
app/helpers/application_helper.rb|171 col 14| Tagging a string as html safe may be a security risk.
app/helpers/application_helper.rb|207 col 43| Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.xmlschema, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.httpdate, Time.now.to_i, Time.now.to_f instead.
app/helpers/application_helper.rb|208 col 8| Do not use instance variables in helpers.
app/helpers/application_helper.rb|208 col 8| Use safe navigation (&.) instead of checking if an object exists before calling the method.
app/helpers/application_helper.rb|208 col 21| Do not use instance variables in helpers.
app/helpers/application_helper.rb|211 col 35| Do not use instance variables in helpers.
app/helpers/application_helper.rb|224 col 43| Tagging a string as html safe may be a security risk.
app/helpers/application_helper.rb|243 col 3| Assignment Branch Condition size for body_css_classes is too high. [<3, 21, 3> 21.42/17]
app/helpers/application_helper.rb|244 col 12| Prefer string interpolation to string concatenation.
app/helpers/application_helper.rb|247 col 15| Prefer string interpolation to string concatenation.
app/helpers/application_helper.rb|248 col 15| Prefer string interpolation to string concatenation.
app/helpers/application_helper.rb|261 col 17| Method parameter must be at least 3 characters long.
... (Too many findings. Dropped some findings)

Annotations

Check notice on line 54 in app/components/work_packages/activities_tab/index_component.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] app/components/work_packages/activities_tab/index_component.rb#L54 <Layout/LineLength>

Line is too long. [132/130]
Raw output
app/components/work_packages/activities_tab/index_component.rb:54:131: C: Layout/LineLength: Line is too long. [132/130]

Check warning on line 41 in app/components/work_packages/activities_tab/journals/empty_component.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] app/components/work_packages/activities_tab/journals/empty_component.rb#L39-L41 <Lint/UselessMethodDefinition>

Useless method definition detected.
Raw output
app/components/work_packages/activities_tab/journals/empty_component.rb:39:9: W: Lint/UselessMethodDefinition: Useless method definition detected.

Check notice on line 41 in app/components/work_packages/activities_tab/journals/empty_component.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] app/components/work_packages/activities_tab/journals/empty_component.rb#L39-L41 <Style/RedundantInitialize>

Remove unnecessary `initialize` method.
Raw output
app/components/work_packages/activities_tab/journals/empty_component.rb:39:9: C: Style/RedundantInitialize: Remove unnecessary `initialize` method.

Check notice on line 148 in app/components/work_packages/activities_tab/journals/item_component.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] app/components/work_packages/activities_tab/journals/item_component.rb#L148 <Rails/OutputSafety>

Tagging a string as html safe may be a security risk.
Raw output
app/components/work_packages/activities_tab/journals/item_component.rb:148:13: C: Rails/OutputSafety: Tagging a string as html safe may be a security risk.

Check notice on line 115 in app/components/work_packages/activities_tab/journals/item_component/details.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] app/components/work_packages/activities_tab/journals/item_component/details.rb#L56-L115 <Metrics/AbcSize>

Assignment Branch Condition size for render_details_header is too high. [<4, 52, 5> 52.39/17]
Raw output
app/components/work_packages/activities_tab/journals/item_component/details.rb:56:9: C: Metrics/AbcSize: Assignment Branch Condition size for render_details_header is too high. [<4, 52, 5> 52.39/17]

Check notice on line 134 in app/components/work_packages/activities_tab/journals/item_component/details.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] app/components/work_packages/activities_tab/journals/item_component/details.rb#L117-L134 <Metrics/AbcSize>

Assignment Branch Condition size for render_details is too high. [<3, 17, 6> 18.28/17]
Raw output
app/components/work_packages/activities_tab/journals/item_component/details.rb:117:9: C: Metrics/AbcSize: Assignment Branch Condition size for render_details is too high. [<3, 17, 6> 18.28/17]

Check notice on line 146 in app/components/work_packages/activities_tab/journals/item_component/details.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] app/components/work_packages/activities_tab/journals/item_component/details.rb#L146 <Rails/OutputSafety>

Tagging a string as html safe may be a security risk.
Raw output
app/components/work_packages/activities_tab/journals/item_component/details.rb:146:13: C: Rails/OutputSafety: Tagging a string as html safe may be a security risk.

Check notice on line 125 in app/controllers/work_packages/activities_tab_controller.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] app/controllers/work_packages/activities_tab_controller.rb#L99-L125 <Metrics/AbcSize>

Assignment Branch Condition size for create is too high. [<1, 26, 7> 26.94/17]
Raw output
app/controllers/work_packages/activities_tab_controller.rb:99:3: C: Metrics/AbcSize: Assignment Branch Condition size for create is too high. [<1, 26, 7> 26.94/17]