Skip to content
pullpreview

Feature/54733 primerise the activity panel #37225

Sign in to view logs

Feature/54733 primerise the activity panel

Feature/54733 primerise the activity panel #37225

Triggered via pull request August 20, 2024 12:54
@jjabari-opjjabari-op
synchronize #15643
feature/54733-primerise-the-activity-panel
Status Success
Total duration 11m 43s
Artifacts –

pullpreview.yml

on: pull_request
deploy
11m 33s
deploy
Fit to window
Zoom out
Zoom in

Annotations

14 errors, 1 warning, and 7 notices
[eslint] src/app/features/work-packages/components/work-package-comment/work-package-comment.component.ts#L58 <no-unused-vars>(https://eslint.org/docs/latest/rules/no-unused-vars): src/app/features/work-packages/components/work-package-comment/work-package-comment.component.ts#L58
'timeout' is defined but never used. Allowed unused vars must match /^_/u.
[eslint] src/app/features/work-packages/components/work-package-comment/work-package-comment.component.ts#L58 <@typescript-eslint/no-unused-vars>(https://typescript-eslint.io/rules/no-unused-vars): src/app/features/work-packages/components/work-package-comment/work-package-comment.component.ts#L58
'timeout' is defined but never used. Allowed unused vars must match /^_/u.
[eslint] src/app/features/work-packages/components/work-package-comment/work-package-comment.component.ts#L105 <function-paren-newline>(https://eslint.org/docs/latest/rules/function-paren-newline): src/app/features/work-packages/components/work-package-comment/work-package-comment.component.ts#L105
Expected newline before ')'.
[eslint] src/stimulus/controllers/dynamic/work-packages/activities-tab/index.controller.ts#L7 <no-unused-vars>(https://eslint.org/docs/latest/rules/no-unused-vars): src/stimulus/controllers/dynamic/work-packages/activities-tab/index.controller.ts#L7
'workPackageFilesCount' is defined but never used. Allowed unused vars must match /^_/u.
[eslint] src/stimulus/controllers/dynamic/work-packages/activities-tab/index.controller.ts#L7 <@typescript-eslint/no-unused-vars>(https://typescript-eslint.io/rules/no-unused-vars): src/stimulus/controllers/dynamic/work-packages/activities-tab/index.controller.ts#L7
'workPackageFilesCount' is defined but never used. Allowed unused vars must match /^_/u.
[eslint] src/stimulus/controllers/dynamic/work-packages/activities-tab/index.controller.ts#L8 <no-unused-vars>(https://eslint.org/docs/latest/rules/no-unused-vars): src/stimulus/controllers/dynamic/work-packages/activities-tab/index.controller.ts#L8
'set' is defined but never used. Allowed unused vars must match /^_/u.
[eslint] src/stimulus/controllers/dynamic/work-packages/activities-tab/index.controller.ts#L8 <@typescript-eslint/no-unused-vars>(https://typescript-eslint.io/rules/no-unused-vars): src/stimulus/controllers/dynamic/work-packages/activities-tab/index.controller.ts#L8
'set' is defined but never used. Allowed unused vars must match /^_/u.
[eslint] src/stimulus/controllers/dynamic/work-packages/activities-tab/index.controller.ts#L63 <@typescript-eslint/no-misused-promises>(https://typescript-eslint.io/rules/no-misused-promises): src/stimulus/controllers/dynamic/work-packages/activities-tab/index.controller.ts#L63
Promise-returning function provided to variable where a void return was expected.
[eslint] src/stimulus/controllers/dynamic/work-packages/activities-tab/index.controller.ts#L82 <@typescript-eslint/no-floating-promises>(https://typescript-eslint.io/rules/no-floating-promises): src/stimulus/controllers/dynamic/work-packages/activities-tab/index.controller.ts#L82
Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator.
[eslint] src/stimulus/controllers/dynamic/work-packages/activities-tab/index.controller.ts#L100 <no-unused-vars>(https://eslint.org/docs/latest/rules/no-unused-vars): src/stimulus/controllers/dynamic/work-packages/activities-tab/index.controller.ts#L100
'event' is defined but never used. Allowed unused args must match /^_/u.
[eslint] src/stimulus/controllers/dynamic/work-packages/activities-tab/index.controller.ts#L100 <@typescript-eslint/no-unused-vars>(https://typescript-eslint.io/rules/no-unused-vars): src/stimulus/controllers/dynamic/work-packages/activities-tab/index.controller.ts#L100
'event' is defined but never used. Allowed unused args must match /^_/u.
[eslint] src/stimulus/controllers/dynamic/work-packages/activities-tab/index.controller.ts#L212 <@typescript-eslint/no-unsafe-enum-comparison>(https://typescript-eslint.io/rules/no-unsafe-enum-comparison): src/stimulus/controllers/dynamic/work-packages/activities-tab/index.controller.ts#L212
The two values in this comparison do not have a shared enum type.
[eslint] src/stimulus/controllers/dynamic/work-packages/activities-tab/index.controller.ts#L213 <@typescript-eslint/no-floating-promises>(https://typescript-eslint.io/rules/no-floating-promises): src/stimulus/controllers/dynamic/work-packages/activities-tab/index.controller.ts#L213
Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator.
[eslint] src/stimulus/controllers/dynamic/work-packages/activities-tab/index.controller.ts#L242 <@typescript-eslint/no-unsafe-member-access>(https://typescript-eslint.io/rules/no-unsafe-member-access): src/stimulus/controllers/dynamic/work-packages/activities-tab/index.controller.ts#L242
Unsafe member access .focusTracker on an `any` value.
[rubocop] app/components/work_packages/activities_tab/journals/empty_component.rb#L39-L41 <Lint/UselessMethodDefinition>: app/components/work_packages/activities_tab/journals/empty_component.rb#L39
Useless method definition detected.
[rubocop] app/components/work_packages/activities_tab/index_component.rb#L54 <Layout/LineLength>: app/components/work_packages/activities_tab/index_component.rb#L54
Line is too long. [132/130]
[rubocop] app/components/work_packages/activities_tab/journals/empty_component.rb#L39-L41 <Style/RedundantInitialize>: app/components/work_packages/activities_tab/journals/empty_component.rb#L39
Remove unnecessary `initialize` method.
[rubocop] app/components/work_packages/activities_tab/journals/item_component.rb#L148 <Rails/OutputSafety>: app/components/work_packages/activities_tab/journals/item_component.rb#L148
Tagging a string as html safe may be a security risk.
[rubocop] app/components/work_packages/activities_tab/journals/item_component/details.rb#L56-L115 <Metrics/AbcSize>: app/components/work_packages/activities_tab/journals/item_component/details.rb#L56
Assignment Branch Condition size for render_details_header is too high. [<4, 52, 5> 52.39/17]
[rubocop] app/components/work_packages/activities_tab/journals/item_component/details.rb#L117-L134 <Metrics/AbcSize>: app/components/work_packages/activities_tab/journals/item_component/details.rb#L117
Assignment Branch Condition size for render_details is too high. [<3, 17, 6> 18.28/17]
[rubocop] app/components/work_packages/activities_tab/journals/item_component/details.rb#L146 <Rails/OutputSafety>: app/components/work_packages/activities_tab/journals/item_component/details.rb#L146
Tagging a string as html safe may be a security risk.
[rubocop] app/controllers/work_packages/activities_tab_controller.rb#L99-L125 <Metrics/AbcSize>: app/controllers/work_packages/activities_tab_controller.rb#L99
Assignment Branch Condition size for create is too high. [<1, 26, 7> 26.94/17]