Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Primer #13126

Merged
merged 73 commits into from
Jul 26, 2023
Merged

Introduce Primer #13126

merged 73 commits into from
Jul 26, 2023

Conversation

HDinger
Copy link
Contributor

@HDinger HDinger commented Jul 13, 2023 •
edited by bsatarnejad
Loading

Related PR: https://github.com/opf/saas-openproject/pull/160

Use Primer Repos

  • PrimerCSS
  • PrimerViewComponents
  • Octicons

Remove major blockers

  • Dropdowns not working
  • Flash messages broken
  • Wrong Font
  • Menu header in Backlogs misplaced
  • On overview page when Add widget is ON, there are + buttons everywhere
  • Different link colours

Remove code that interferes with Primer

  • FoundationForApps
  • Basic core styles (e.g. for headings or basics tags)

Other ToDos

  • Add theme selector

https://community.openproject.org/projects/14/work_packages/48868/activity
https://community.openproject.org/projects/14/work_packages/48869/activity
https://community.openproject.org/projects/14/work_packages/48989/activity

HDinger and others added 14 commits July 11, 2023 12:04
@HDinger
Introduce Primer CSS and Primer ViewComponents
d90573f
@HDinger
Remove code from Foundation that is not used anyways
b923805
@HDinger
Remove more unused code. For the "toast" class we switch to the mixin…
2304388 
… we already have instead of using foundations which are overwritten in most cases anyway
@HDinger
Move code of Foundation used for badges to the core file and remove t…
25335fd 
…he rest
@HDinger
Move animation code from Foundation to core and remove the rest
aa21bd5
@HDinger
Remove unnused file from Foundation
3768a31
@HDinger
Copy still used utilities from Foundation to core and remove the rest
68f2fce
@HDinger
Remove mixin file from Foundation vendored styles as there are not us…
ab4d682 
…ed anywhere anymore
@HDinger
Move still used mixins of Buttons from Foundation to code and remove …
6583ade 
…the rest
@HDinger
Cleanup usage of old "isitlight" function
5a6d7a7
@bsatarnejad
fix drop-down buttons position style, after clicking on a drop-down b…
c9b09b1 
…utton it was not opened
@HDinger
Use PrimerViewComponent Flash for the rails rendered flash messages
35edcdf
@HDinger
Revert "Use PrimerViewComponent Flash for the rails rendered flash me…
04aee52 
…ssages"

This reverts commit 35edcdf.
@bsatarnejad
force body to use lato instaed of primer font-family
5015f7f
HDinger and others added 13 commits July 14, 2023 08:14
@HDinger
Remove "normalize" styles from Foundation. They are either not used a…
f1037b8 
…nyways or also provided by Primer
@HDinger
Merge branch 'dev' into primer-dev
7ecc7f5
@HDinger
Remove Foundations typography, keep only the indentition for lists. E…
5cced55 
…verything else is covered by Primer
@HDinger
Move Foundations grid styles to core
2fcd7f8
@HDinger
Move basic stlyes (like select or input tags) to the core basic.sass …
6996189 
…and remove the foundation file
@HDinger
Move basic form styles to its own file and remove global styles from …
fd3838d 
…Foundation which are not used any more
@bsatarnejad
replace $body-background with var(--body-background) in base
d2cea1e
@HDinger
Remove the last remains of Foundation for Apps including Breakpoints.…
eb8b5f4 
… The Breakpoints are now used from Primer
@HDinger
Remove custom heading overrides
e9dd180
@HDinger
Tag repo to certain commit
97526d4
@HDinger
Readd "rem-calc" function from Foundation as it is still used
8fe0fc2
@HDinger
Remove core overrides of Primer styles
98db61b
@HDinger
Bump primer_view_components to 0.4.0
857ee8e
HDinger and others added 17 commits July 21, 2023 13:50
@HDinger
Remove usage of octicons icon for now as it crashed the page and thus…
6b77a9d 
… the tests
@HDinger
Please rubocop
ea5ed94
@HDinger
Revert changes in spot toggle components as it did not work any more …
7cfa907 
…as expected
@HDinger
Attempt to load the primer_view_component.js
b4d1771
@HDinger
Correct loading of view_component according to the Primer docs
2757a4f
fix: update openproject octicons angular package to 19.6.2
51f06eb
Revert "Remove usage of octicons icon for now as it crashed the page …
340da6d 
…and thus the tests"

This reverts commit 6b77a9d.
@HDinger
Merge remote-tracking branch 'origin/dev' into primer-dev
af7f0a8
@HDinger
Remove unwanted plugin
4b078c1
@bsatarnejad
revert style changes for widget boxes
247b94a
@bsatarnejad
over write primer styles
8bb60b9
@HDinger
Rename primer color file
8ac14d0
@HDinger
Revert "Attempt to load the primer_view_component.js"
61e7c53 
This reverts commit b4d1771.
@HDinger
Override the link color with ours even if there is no custom design s…
aa8403b 
…elected
@HDinger
Merge branch 'dev' into primer-dev
874fdea
fix: update @openproject/octicons-angular to 19.6.3
a658c1f
@oliverguenther
Use custom webpack config with terser to keep classnames
3de2e70
@HDinger HDinger marked this pull request as ready for review July 26, 2023 06:42
@lindenthal
Copy link
Member

Very well done. This is a big achievement. Thanks everybody at GitHub to make this happen. Thanks also to the OpenProject team that worked passionately on this. Very OPENP!

@lindenthal lindenthal merged commit 1e8b1bb into dev Jul 26, 2023
12 checks passed
@lindenthal lindenthal deleted the primer-dev branch July 26, 2023 09:56
@akabiru akabiru mentioned this pull request Jul 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HDinger @lindenthal @ulferts @bsatarnejad @oliverguenther