css[Op#48413] Add explicit margin bottom to project storages danger zoneul using primer css
#13301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`global_styles/vendor/foundation-apps/scss/components/_typography.scss`
defined `ul` elements with a default `margin-bottom`
```css
/* Lists */
ul,
ol,
dl {
font-size: $list-font-size;
line-height: $list-line-height;
margin-bottom: $list-margin-bottom;
list-style-position: $list-style-position;
font-family: $list-font-family;
}
```
Since the Primer release, this has since been removed. Hence updating to
using PrimerCSS [Margin Directional](https://primer.style/css/storybook/?path=/story/utilities-margin--directional) utility
https://community.openproject.org/work_packages/48413
akabiru
changed the title
ul from primer updateul using primer css
akabiru
changed the title
ul using primer cssul using primer css
HDinger
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://community.openproject.org/work_packages/48413
🚧 Bug: Missing Margin Bottom
Since the Primer release in #13126
global_styles/vendor/foundation-apps/scss/components/_typography.scsswas removed which defined a margin-bottom forulelements.Hence update to use PrimerCSS Margin Directional utility