Feature/54733 primerise the activity panel #15643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, tagging users not yet possible
…ot working yet via ckeditor
…rise-the-activity-panel' into feature/54733-primerise-the-activity-panel
|
Hi @jonasjabari and @wielinde, I just added a comment on mobile. Currently it requires two clicks/taps to enter text. Here in GitHub only one click is required. Can you please check? |
|
Hi @jonasjabari and @wielinde |
|
Thank you for your feedback @lindenthal |
…s feature, specs and refactoring required" This reverts commit 66aa229.
…ackage relation check not required anymore
…rService usage and enhancement
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
frontend/src/stimulus/controllers/dynamic/work-packages/activities-tab/index.controller.ts
Fixed
Show fixed
Hide fixed
…ased` In the original flow, which still exists- a blue banner is shown anytime there are new notifications based on unreadCountIncreased$ - however, when based on a generic unreadCountChanged$ it is not dismissible
Kharonus
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
LGTM in the context of the pair review with @akabiru
- the PR is way too big to get a good overview of all introduced decisions and code
- there are some weird architectural patterns (mixin angular, stimulus and rails) I'd challenge, if there is time
- We agreed, that the right time of raising the challenges are, when the angular part is partially deconstructed from this part of the product -> then we need to take the time and rethink some of the decision taken here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://community.openproject.org/projects/openproject/work_packages/54733