Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --manager, --service, and --namespace flags #282

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Commits on Aug 27, 2024

  1. Add management- and service-cluster flags

    Adds flags for management- and service-cluster bools, and marks the two
    mutually exclusive.  If either are provided, then --cluster-id is
    required as well.
    
    This is setting groundwork for HCP MC and SC support.
    
    Signed-off-by: Chris Collins <[email protected]>
    clcollins committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    e572639 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Add management/service/hive & namespace login flags

    * Adds `--manager` and `--service` flags to allow logging into MC/Hive and SC clusters for a provided `--cluster-id`.
    * Adds related and other helpful ENV vars inside the container
    * Adds `--namespace` flag to override the default NS on whatever cluster is being logged into
    * Removes login logic from ~/.bashrc.d/* files inside the container, moving the responsibility of login to ocm-container's binary
    
    WIP - TODO:
    
    * Add a log message immediately before spawning login execs so users will have positive feedback on why they're waiting.  This used to be incidental as a result of the different bash scripts, making it feel like login wasn't just hanging, but even though it's the same length if ocm-container executes the login, because there's no feedback it feels like ocm-container has hung.
    * Figure out how to perform the login to ocm and backplane in order, but async from the container attachment, to speed up the login.
    * Do the plumbing to pick the right cluster if `--manager`, `--service` or `--namespace` are provided.
    
    Signed-off-by: Chris Collins <[email protected]>
    clcollins committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    317341f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    13bf874 View commit details
    Browse the repository at this point in the history
  3. removing comment

    Signed-off-by: Chris Collins <[email protected]>
    clcollins committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    82b168d View commit details
    Browse the repository at this point in the history
  4. removing cluster function

    Signed-off-by: Chris Collins <[email protected]>
    clcollins committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    572c4a1 View commit details
    Browse the repository at this point in the history