-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --manager
, --service
, and --namespace
flags
#282
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clcollins The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I have been thinking about this one. The new --ohss and existing --pd flags would also be good to replicate. Kirk's changes in #295 will also help with the OCM logins. |
Adds flags for management- and service-cluster bools, and marks the two mutually exclusive. If either are provided, then --cluster-id is required as well. This is setting groundwork for HCP MC and SC support. Signed-off-by: Chris Collins <[email protected]>
* Adds `--manager` and `--service` flags to allow logging into MC/Hive and SC clusters for a provided `--cluster-id`. * Adds related and other helpful ENV vars inside the container * Adds `--namespace` flag to override the default NS on whatever cluster is being logged into * Removes login logic from ~/.bashrc.d/* files inside the container, moving the responsibility of login to ocm-container's binary WIP - TODO: * Add a log message immediately before spawning login execs so users will have positive feedback on why they're waiting. This used to be incidental as a result of the different bash scripts, making it feel like login wasn't just hanging, but even though it's the same length if ocm-container executes the login, because there's no feedback it feels like ocm-container has hung. * Figure out how to perform the login to ocm and backplane in order, but async from the container attachment, to speed up the login. * Do the plumbing to pick the right cluster if `--manager`, `--service` or `--namespace` are provided. Signed-off-by: Chris Collins <[email protected]>
Signed-off-by: Chris Collins <[email protected]>
Signed-off-by: Chris Collins <[email protected]>
Signed-off-by: Chris Collins <[email protected]>
Add management/service/hive & namespace login flags
--manager
and--service
flags to allow logging into MC/Hive and SC clusters for a provided--cluster-id
.--namespace
flag to override the default NS on whatever cluster is being logged intoExample ENVs logging into a classic cluster (or it's hive):
And example for HPC:
And extra vars that might be helpful, for any cluster:
Fixes #271
Fixes #270
WIP - TODO:
--manager
,--service
or--namespace
are provided.Signed-off-by: Chris Collins [email protected]