-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-48152: Fix mirror reference image name when ID is set #5353
Conversation
Signed-off-by: Juan Manuel Parrilla Madrid <[email protected]>
@jparrill: This pull request references Jira Issue OCPBUGS-48152, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jparrill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/area control-plane-operator |
/retest |
/lgtm |
/retest |
/retest |
4 similar comments
/retest |
/retest |
/retest |
/retest |
Looks like there is a Konflux outage we will need to try retest after that got fixed. More info here: https://redhat-internal.slack.com/archives/C04PZ7H0VA8/p1736438759559479 |
/retest |
/retest |
7 similar comments
/retest |
/retest |
/retest |
/retest |
/retest |
/retest |
/retest |
1 similar comment
/retest |
1 similar comment
/retest |
1 similar comment
/retest |
/retest |
18db34c
into
openshift:main
@jparrill: Jira Issue OCPBUGS-48152: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-48152 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira backport release-4.18 |
@LiangquanLi930: The following backport issues have been created:
Queuing cherrypicks to the requested branches to be created after this PR merges: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-ci-robot: new pull request created: #5393 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherrypick release-4.18 |
@jparrill: new pull request could not be created: failed to create pull request against openshift/hypershift#release-4.18 from head openshift-cherrypick-robot:cherry-pick-5353-to-release-4.18: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-5353-to-release-4.18."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it: When an imageName is set with the SHA256 and the ICSP/IDMS does not contain a Tag but an ID, the reference image name is using the original name instead of the mirror one. This PR fixes that situation.
Which issue(s) this PR fixes :
Fixes #OCPBUGS-48152