Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-48152: Fix mirror reference image name when ID is set #5353

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

jparrill
Copy link
Contributor

@jparrill jparrill commented Jan 8, 2025

What this PR does / why we need it: When an imageName is set with the SHA256 and the ICSP/IDMS does not contain a Tag but an ID, the reference image name is using the original name instead of the mirror one. This PR fixes that situation.

Which issue(s) this PR fixes :
Fixes #OCPBUGS-48152

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 8, 2025
@openshift-ci-robot
Copy link

@jparrill: This pull request references Jira Issue OCPBUGS-48152, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @LiangquanLi930

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it: When an imageName is set with the SHA256 and the ICSP/IDMS does not contain a Tag but an ID, the reference image name is using the original name instead of the mirror one. This PR fixes that situation.

Which issue(s) this PR fixes :
Fixes #OCPBUGS-48152

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2025
@jparrill
Copy link
Contributor Author

jparrill commented Jan 8, 2025

/retest

@jparrill
Copy link
Contributor Author

jparrill commented Jan 9, 2025

/area control-plane-operator
/area hypershift-operator

@jparrill
Copy link
Contributor Author

jparrill commented Jan 9, 2025

/retest

@openshift-ci openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release and removed do-not-merge/needs-area labels Jan 9, 2025
@LiangquanLi930
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2025
@jparrill
Copy link
Contributor Author

jparrill commented Jan 9, 2025

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 99c34c1 and 2 for PR HEAD e313856 in total

@LiangquanLi930
Copy link
Member

/retest

4 similar comments
@LiangquanLi930
Copy link
Member

/retest

@jparrill
Copy link
Contributor Author

jparrill commented Jan 9, 2025

/retest

@LiangquanLi930
Copy link
Member

/retest

@jparrill
Copy link
Contributor Author

jparrill commented Jan 9, 2025

/retest

@jparrill
Copy link
Contributor Author

jparrill commented Jan 9, 2025

Looks like there is a Konflux outage we will need to try retest after that got fixed. More info here: https://redhat-internal.slack.com/archives/C04PZ7H0VA8/p1736438759559479

@jparrill
Copy link
Contributor Author

jparrill commented Jan 9, 2025

/retest

@LiangquanLi930
Copy link
Member

/retest

7 similar comments
@LiangquanLi930
Copy link
Member

/retest

@LiangquanLi930
Copy link
Member

/retest

@LiangquanLi930
Copy link
Member

/retest

@jparrill
Copy link
Contributor Author

/retest

@jparrill
Copy link
Contributor Author

/retest

@LiangquanLi930
Copy link
Member

/retest

@LiangquanLi930
Copy link
Member

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a39bf24 and 2 for PR HEAD e313856 in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a39bf24 and 2 for PR HEAD e313856 in total

@LiangquanLi930
Copy link
Member

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a39bf24 and 2 for PR HEAD e313856 in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a39bf24 and 2 for PR HEAD e313856 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2f395fe and 1 for PR HEAD e313856 in total

@jparrill
Copy link
Contributor Author

/retest

1 similar comment
@jparrill
Copy link
Contributor Author

/retest

@jparrill
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1c6d1bb and 0 for PR HEAD e313856 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1c6d1bb and 2 for PR HEAD e313856 in total

@openshift-merge-bot openshift-merge-bot bot merged commit 18db34c into openshift:main Jan 15, 2025
12 of 14 checks passed
@openshift-ci-robot
Copy link

@jparrill: Jira Issue OCPBUGS-48152: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-48152 has been moved to the MODIFIED state.

In response to this:

What this PR does / why we need it: When an imageName is set with the SHA256 and the ICSP/IDMS does not contain a Tag but an ID, the reference image name is using the original name instead of the mirror one. This PR fixes that situation.

Which issue(s) this PR fixes :
Fixes #OCPBUGS-48152

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@LiangquanLi930
Copy link
Member

/jira backport release-4.18

@openshift-ci-robot
Copy link

@LiangquanLi930: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.18

In response to this:

/jira backport release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@openshift-ci-robot: new pull request created: #5393

In response to this:

@LiangquanLi930: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.18

In response to this:

/jira backport release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jparrill
Copy link
Contributor Author

/cherrypick release-4.18

@openshift-cherrypick-robot

@jparrill: new pull request could not be created: failed to create pull request against openshift/hypershift#release-4.18 from head openshift-cherrypick-robot:cherry-pick-5353-to-release-4.18: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-5353-to-release-4.18."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

/cherrypick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants