OCPBUGS-48117: Fix disconnected GetRegistryOverrides

[LiangquanLi930]

What this PR does / why we need it:
In some environments, the name source/mirror for the payload image in ICSP/IDMS is inconsistent, so we need to adjust the logic in this part.
icsp config

- mirrors:
    - virthost.ostest.test.metalkube.org:5000/localimages/local-release-image
  source: registry.build01.ci.openshift.org/ci-op-p2mqdwjp/release
- mirrors:
    - virthost.ostest.test.metalkube.org:5000/localimages/local-release-image
  source: registry.ci.openshift.org/ocp/4.18-2025-01-04-031500
{"level":"info","ts":"2025-01-05T13:55:14Z","msg":"debug---1","controller":"hostedcluster","controllerGroup":"hypershift.openshift.io","controllerKind":"HostedCluster","HostedCluster":{"name":"4abd3e713877d8639ca1","namespace":"local-cluster"},"namespace":"local-cluster","name":"4abd3e713877d8639ca1","reconcileID":"b2b36e7e-b782-408d-b7c2-cf67887e2c06","OpenShiftImageRegistryOverrides":{"brew.registry.redhat.io":["virthost.ostest.test.metalkube.org:6002"],"quay.io/hypershift":["virthost.ostest.test.metalkube.org:6001/hypershift"],"quay.io/olmqe":["virthost.ostest.test.metalkube.org:6001/olmqe"],"quay.io/openshift-qe-optional-operators":["virthost.ostest.test.metalkube.org:6001/openshift-qe-optional-operators"],"quay.io/openshifttest":["virthost.ostest.test.metalkube.org:6001/openshifttest"],"registry-proxy.engineering.redhat.com":["virthost.ostest.test.metalkube.org:6002"],"registry.build01.ci.openshift.org/ci-op-p2mqdwjp/release":["virthost.ostest.test.metalkube.org:5000/localimages/local-release-image"],"registry.ci.openshift.org/ocp/4.18-2025-01-04-031500":["virthost.ostest.test.metalkube.org:5000/localimages/local-release-image"],"registry.redhat.io":["virthost.ostest.test.metalkube.org:6002"],"registry.stage.redhat.io":["virthost.ostest.test.metalkube.org:6002"]}}
{"level":"info","ts":"2025-01-05T13:55:14Z","msg":"debug---2","controller":"hostedcluster","controllerGroup":"hypershift.openshift.io","controllerKind":"HostedCluster","HostedCluster":{"name":"4abd3e713877d8639ca1","namespace":"local-cluster"},"namespace":"local-cluster","name":"4abd3e713877d8639ca1","reconcileID":"b2b36e7e-b782-408d-b7c2-cf67887e2c06","parsedImageRef":"registry.ci.openshift.org/ocp/4.18-2025-01-04-031500@sha256:ba93b7791accfb38e76634edbc815d596ebf39c3d4683a001f8286b3e122ae69"}
{"level":"info","ts":"2025-01-05T13:55:14Z","msg":"debug---3","controller":"hostedcluster","controllerGroup":"hypershift.openshift.io","controllerKind":"HostedCluster","HostedCluster":{"name":"4abd3e713877d8639ca1","namespace":"local-cluster"},"namespace":"local-cluster","name":"4abd3e713877d8639ca1","reconcileID":"b2b36e7e-b782-408d-b7c2-cf67887e2c06","ref":"virthost.ostest.test.metalkube.org:5000/localimages/4.18-2025-01-04-031500@sha256:ba93b7791accfb38e76634edbc815d596ebf39c3d4683a001f8286b3e122ae69"}

error log

    - lastTransitionTime: "2025-01-05T13:55:14Z"
      message: 'failed to get controlPlaneOperatorImageLabels: failed to look up image
        metadata for registry.ci.openshift.org/ocp/4.18-2025-01-04-031500@sha256:ba93b7791accfb38e76634edbc815d596ebf39c3d4683a001f8286b3e122ae69:
        failed to obtain root manifest for registry.ci.openshift.org/ocp/4.18-2025-01-04-031500@sha256:ba93b7791accfb38e76634edbc815d596ebf39c3d4683a001f8286b3e122ae69:
        manifest unknown: manifest unknown'
      observedGeneration: 2
      reason: ReconciliationError
      status: "False"
      type: ReconciliationSucceeded

test job:
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/60159/rehearse-60159-periodic-ci-openshift-hypershift-release-4.18-periodics-mce-e2e-agent-disconnected-ovn-ipv6-metal3-conformance/1876256251864682496

Which issue(s) this PR fixes
https://issues.redhat.com/browse/OCPBUGS-48117

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

[openshift-ci-robot]

@LiangquanLi930: This pull request references Jira Issue OCPBUGS-48117, which is invalid:

• expected the bug to target only the "4.19.0" version, but multiple target versions were set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:
In some environments, the name source/mirror for the payload image in ICSP/IDMS is inconsistent, so we need to adjust the logic in this part.
icsp config

- mirrors:
   - virthost.ostest.test.metalkube.org:5000/localimages/local-release-image
 source: registry.build01.ci.openshift.org/ci-op-p2mqdwjp/release
- mirrors:
   - virthost.ostest.test.metalkube.org:5000/localimages/local-release-image
 source: registry.ci.openshift.org/ocp/4.18-2025-01-04-031500

error log

   - lastTransitionTime: "2025-01-05T13:55:14Z"
     message: 'failed to get controlPlaneOperatorImageLabels: failed to look up image
       metadata for registry.ci.openshift.org/ocp/4.18-2025-01-04-031500@sha256:ba93b7791accfb38e76634edbc815d596ebf39c3d4683a001f8286b3e122ae69:
       failed to obtain root manifest for registry.ci.openshift.org/ocp/4.18-2025-01-04-031500@sha256:ba93b7791accfb38e76634edbc815d596ebf39c3d4683a001f8286b3e122ae69:
       manifest unknown: manifest unknown'
     observedGeneration: 2
     reason: ReconciliationError
     status: "False"
     type: ReconciliationSucceeded

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Please specify an area label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LiangquanLi930
Once this PR has been reviewed and has the lgtm label, please assign enxebre for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@LiangquanLi930: This pull request references Jira Issue OCPBUGS-48117, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @LiangquanLi930

In response to this:

What this PR does / why we need it:
In some environments, the name source/mirror for the payload image in ICSP/IDMS is inconsistent, so we need to adjust the logic in this part.
icsp config

- mirrors:
   - virthost.ostest.test.metalkube.org:5000/localimages/local-release-image
 source: registry.build01.ci.openshift.org/ci-op-p2mqdwjp/release
- mirrors:
   - virthost.ostest.test.metalkube.org:5000/localimages/local-release-image
 source: registry.ci.openshift.org/ocp/4.18-2025-01-04-031500

error log

   - lastTransitionTime: "2025-01-05T13:55:14Z"
     message: 'failed to get controlPlaneOperatorImageLabels: failed to look up image
       metadata for registry.ci.openshift.org/ocp/4.18-2025-01-04-031500@sha256:ba93b7791accfb38e76634edbc815d596ebf39c3d4683a001f8286b3e122ae69:
       failed to obtain root manifest for registry.ci.openshift.org/ocp/4.18-2025-01-04-031500@sha256:ba93b7791accfb38e76634edbc815d596ebf39c3d4683a001f8286b3e122ae69:
       manifest unknown: manifest unknown'
     observedGeneration: 2
     reason: ReconciliationError
     status: "False"
     type: ReconciliationSucceeded

test job:
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/60159/rehearse-60159-periodic-ci-openshift-hypershift-release-4.18-periodics-mce-e2e-agent-disconnected-ovn-ipv6-metal3-conformance/1876256251864682496

Which issue(s) this PR fixes
https://issues.redhat.com/browse/OCPBUGS-48117

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@LiangquanLi930: This pull request references Jira Issue OCPBUGS-48117, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @LiangquanLi930

In response to this:

What this PR does / why we need it:
In some environments, the name source/mirror for the payload image in ICSP/IDMS is inconsistent, so we need to adjust the logic in this part.
icsp config

- mirrors:
   - virthost.ostest.test.metalkube.org:5000/localimages/local-release-image
 source: registry.build01.ci.openshift.org/ci-op-p2mqdwjp/release
- mirrors:
   - virthost.ostest.test.metalkube.org:5000/localimages/local-release-image
 source: registry.ci.openshift.org/ocp/4.18-2025-01-04-031500

error log

   - lastTransitionTime: "2025-01-05T13:55:14Z"
     message: 'failed to get controlPlaneOperatorImageLabels: failed to look up image
       metadata for registry.ci.openshift.org/ocp/4.18-2025-01-04-031500@sha256:ba93b7791accfb38e76634edbc815d596ebf39c3d4683a001f8286b3e122ae69:
       failed to obtain root manifest for registry.ci.openshift.org/ocp/4.18-2025-01-04-031500@sha256:ba93b7791accfb38e76634edbc815d596ebf39c3d4683a001f8286b3e122ae69:
       manifest unknown: manifest unknown'
     observedGeneration: 2
     reason: ReconciliationError
     status: "False"
     type: ReconciliationSucceeded

test job:
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/60159/rehearse-60159-periodic-ci-openshift-hypershift-release-4.18-periodics-mce-e2e-agent-disconnected-ovn-ipv6-metal3-conformance/1876256251864682496

Which issue(s) this PR fixes
https://issues.redhat.com/browse/OCPBUGS-48117

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: LiangquanLi930.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@LiangquanLi930: This pull request references Jira Issue OCPBUGS-48117, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @LiangquanLi930

In response to this:

What this PR does / why we need it:
In some environments, the name source/mirror for the payload image in ICSP/IDMS is inconsistent, so we need to adjust the logic in this part.
icsp config

- mirrors:
   - virthost.ostest.test.metalkube.org:5000/localimages/local-release-image
 source: registry.build01.ci.openshift.org/ci-op-p2mqdwjp/release
- mirrors:
   - virthost.ostest.test.metalkube.org:5000/localimages/local-release-image
 source: registry.ci.openshift.org/ocp/4.18-2025-01-04-031500

error log

   - lastTransitionTime: "2025-01-05T13:55:14Z"
     message: 'failed to get controlPlaneOperatorImageLabels: failed to look up image
       metadata for registry.ci.openshift.org/ocp/4.18-2025-01-04-031500@sha256:ba93b7791accfb38e76634edbc815d596ebf39c3d4683a001f8286b3e122ae69:
       failed to obtain root manifest for registry.ci.openshift.org/ocp/4.18-2025-01-04-031500@sha256:ba93b7791accfb38e76634edbc815d596ebf39c3d4683a001f8286b3e122ae69:
       manifest unknown: manifest unknown'
     observedGeneration: 2
     reason: ReconciliationError
     status: "False"
     type: ReconciliationSucceeded

test job:
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/60159/rehearse-60159-periodic-ci-openshift-hypershift-release-4.18-periodics-mce-e2e-agent-disconnected-ovn-ipv6-metal3-conformance/1876256251864682496

Which issue(s) this PR fixes
https://issues.redhat.com/browse/OCPBUGS-48117

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: LiangquanLi930.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@LiangquanLi930: This pull request references Jira Issue OCPBUGS-48117, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @LiangquanLi930

In response to this:

What this PR does / why we need it:
In some environments, the name source/mirror for the payload image in ICSP/IDMS is inconsistent, so we need to adjust the logic in this part.
icsp config

- mirrors:
   - virthost.ostest.test.metalkube.org:5000/localimages/local-release-image
 source: registry.build01.ci.openshift.org/ci-op-p2mqdwjp/release
- mirrors:
   - virthost.ostest.test.metalkube.org:5000/localimages/local-release-image
 source: registry.ci.openshift.org/ocp/4.18-2025-01-04-031500

error log

   - lastTransitionTime: "2025-01-05T13:55:14Z"
     message: 'failed to get controlPlaneOperatorImageLabels: failed to look up image
       metadata for registry.ci.openshift.org/ocp/4.18-2025-01-04-031500@sha256:ba93b7791accfb38e76634edbc815d596ebf39c3d4683a001f8286b3e122ae69:
       failed to obtain root manifest for registry.ci.openshift.org/ocp/4.18-2025-01-04-031500@sha256:ba93b7791accfb38e76634edbc815d596ebf39c3d4683a001f8286b3e122ae69:
       manifest unknown: manifest unknown'
     observedGeneration: 2
     reason: ReconciliationError
     status: "False"
     type: ReconciliationSucceeded

test job:
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/60159/rehearse-60159-periodic-ci-openshift-hypershift-release-4.18-periodics-mce-e2e-agent-disconnected-ovn-ipv6-metal3-conformance/1876256251864682496

Which issue(s) this PR fixes
https://issues.redhat.com/browse/OCPBUGS-48117

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@LiangquanLi930: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/unit	22f044c	link	true	/test unit
ci/prow/okd-scos-e2e-aws-ovn	22f044c	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jparrill]

Fixing the issue in this PR: #5353

[LiangquanLi930]

/close

[openshift-ci]

@LiangquanLi930: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@LiangquanLi930: This pull request references Jira Issue OCPBUGS-48117. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

What this PR does / why we need it:
In some environments, the name source/mirror for the payload image in ICSP/IDMS is inconsistent, so we need to adjust the logic in this part.
icsp config

- mirrors:
   - virthost.ostest.test.metalkube.org:5000/localimages/local-release-image
 source: registry.build01.ci.openshift.org/ci-op-p2mqdwjp/release
- mirrors:
   - virthost.ostest.test.metalkube.org:5000/localimages/local-release-image
 source: registry.ci.openshift.org/ocp/4.18-2025-01-04-031500
{"level":"info","ts":"2025-01-05T13:55:14Z","msg":"debug---1","controller":"hostedcluster","controllerGroup":"hypershift.openshift.io","controllerKind":"HostedCluster","HostedCluster":{"name":"4abd3e713877d8639ca1","namespace":"local-cluster"},"namespace":"local-cluster","name":"4abd3e713877d8639ca1","reconcileID":"b2b36e7e-b782-408d-b7c2-cf67887e2c06","OpenShiftImageRegistryOverrides":{"brew.registry.redhat.io":["virthost.ostest.test.metalkube.org:6002"],"quay.io/hypershift":["virthost.ostest.test.metalkube.org:6001/hypershift"],"quay.io/olmqe":["virthost.ostest.test.metalkube.org:6001/olmqe"],"quay.io/openshift-qe-optional-operators":["virthost.ostest.test.metalkube.org:6001/openshift-qe-optional-operators"],"quay.io/openshifttest":["virthost.ostest.test.metalkube.org:6001/openshifttest"],"registry-proxy.engineering.redhat.com":["virthost.ostest.test.metalkube.org:6002"],"registry.build01.ci.openshift.org/ci-op-p2mqdwjp/release":["virthost.ostest.test.metalkube.org:5000/localimages/local-release-image"],"registry.ci.openshift.org/ocp/4.18-2025-01-04-031500":["virthost.ostest.test.metalkube.org:5000/localimages/local-release-image"],"registry.redhat.io":["virthost.ostest.test.metalkube.org:6002"],"registry.stage.redhat.io":["virthost.ostest.test.metalkube.org:6002"]}}
{"level":"info","ts":"2025-01-05T13:55:14Z","msg":"debug---2","controller":"hostedcluster","controllerGroup":"hypershift.openshift.io","controllerKind":"HostedCluster","HostedCluster":{"name":"4abd3e713877d8639ca1","namespace":"local-cluster"},"namespace":"local-cluster","name":"4abd3e713877d8639ca1","reconcileID":"b2b36e7e-b782-408d-b7c2-cf67887e2c06","parsedImageRef":"registry.ci.openshift.org/ocp/4.18-2025-01-04-031500@sha256:ba93b7791accfb38e76634edbc815d596ebf39c3d4683a001f8286b3e122ae69"}
{"level":"info","ts":"2025-01-05T13:55:14Z","msg":"debug---3","controller":"hostedcluster","controllerGroup":"hypershift.openshift.io","controllerKind":"HostedCluster","HostedCluster":{"name":"4abd3e713877d8639ca1","namespace":"local-cluster"},"namespace":"local-cluster","name":"4abd3e713877d8639ca1","reconcileID":"b2b36e7e-b782-408d-b7c2-cf67887e2c06","ref":"virthost.ostest.test.metalkube.org:5000/localimages/4.18-2025-01-04-031500@sha256:ba93b7791accfb38e76634edbc815d596ebf39c3d4683a001f8286b3e122ae69"}

error log

   - lastTransitionTime: "2025-01-05T13:55:14Z"
     message: 'failed to get controlPlaneOperatorImageLabels: failed to look up image
       metadata for registry.ci.openshift.org/ocp/4.18-2025-01-04-031500@sha256:ba93b7791accfb38e76634edbc815d596ebf39c3d4683a001f8286b3e122ae69:
       failed to obtain root manifest for registry.ci.openshift.org/ocp/4.18-2025-01-04-031500@sha256:ba93b7791accfb38e76634edbc815d596ebf39c3d4683a001f8286b3e122ae69:
       manifest unknown: manifest unknown'
     observedGeneration: 2
     reason: ReconciliationError
     status: "False"
     type: ReconciliationSucceeded

test job:
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/60159/rehearse-60159-periodic-ci-openshift-hypershift-release-4.18-periodics-mce-e2e-agent-disconnected-ovn-ipv6-metal3-conformance/1876256251864682496

Which issue(s) this PR fixes
https://issues.redhat.com/browse/OCPBUGS-48117

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.