Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSASINFRA-3636: Enable cluster-storage-operator for OpenStack #4936

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

OSASINFRA-3636: Enable cluster-storage-operator for OpenStack #4936

wants to merge 6 commits into from
+110 −57

Conversation

stephenfin
Copy link
Contributor

@stephenfin stephenfin commented Oct 17, 2024 •
edited
Loading

What this PR does / why we need it:

Enable the Cluster Storage Operator for the OpenStack platform, enabling storage.

WIP while I test this.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:

Fixes OSASINFRA-3636

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Related changes

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 17, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 17, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 17, 2024 •
edited by openshift-ci bot
Loading

@stephenfin: This pull request references OSASINFRA-3636 which is a valid jira issue.

In response to this:

What this PR does / why we need it:

Enable the Cluster Storage Operator for the OpenStack platform, enabling storage.

WIP while I test this.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:

Fixes OSASINFRA-3636

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 17, 2024 •
edited by openshift-ci bot
Loading

@stephenfin: This pull request references OSASINFRA-3636 which is a valid jira issue.

In response to this:

What this PR does / why we need it:

Enable the Cluster Storage Operator for the OpenStack platform, enabling storage.

WIP while I test this.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:

Fixes OSASINFRA-3636

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release label Oct 17, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stephenfin
Once this PR has been reviewed and has the lgtm label, please assign bryan-cox for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added area/documentation Indicates the PR includes changes for documentation and removed do-not-merge/needs-area labels Oct 17, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 17, 2024 •
edited by openshift-ci bot
Loading

@stephenfin: This pull request references OSASINFRA-3636 which is a valid jira issue.

In response to this:

What this PR does / why we need it:

Enable the Cluster Storage Operator for the OpenStack platform, enabling storage.

WIP while I test this.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:

Fixes OSASINFRA-3636

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

This was referenced Oct 17, 2024
Draft
Draft
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 17, 2024 •
edited by openshift-ci bot
Loading

@stephenfin: This pull request references OSASINFRA-3636 which is a valid jira issue.

In response to this:

What this PR does / why we need it:

Enable the Cluster Storage Operator for the OpenStack platform, enabling storage.

WIP while I test this.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:

Fixes OSASINFRA-3636

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Related changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release label Oct 23, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 23, 2024 •
edited
Loading

✅ Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit b2ce310
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/6720f1c689bfc400087b4d69
😎 Deploy Preview https://deploy-preview-4936--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@EmilienM EmilienM mentioned this pull request Oct 24, 2024
Merged
@MaysaMacedo MaysaMacedo mentioned this pull request Oct 25, 2024
Draft
stephenfin and others added 4 commits October 29, 2024 14:30
@stephenfin
docs: Add note on pod security
09b0560 
This is necessary nowadays.

Signed-off-by: Stephen Finucane <[email protected]>
@EmilienM @stephenfin
openstack: reconcile CSI driver secret for OSP credentials
69bbb72
@stephenfin
control-plane-operator: Generate assets for OpenStack Cinder CSI
2173566 
Signed-off-by: Stephen Finucane <[email protected]>
@stephenfin
Add missing logs
b2ce310 
These are present for other reconciliation loops and are very helpful
during development.

Signed-off-by: Stephen Finucane <[email protected]>
@stephenfin
openstack: Stop creating openstack-cloud-config secret
3d202ef 
Nothing is using this. The CCM requires a config map while the Cluster
Storage Operator will manage the configuration for the CSI drivers
(which is also a config map).

Signed-off-by: Stephen Finucane <[email protected]>
@stephenfin
HACKING: Add quickstart matrix
8045baf 
Signed-off-by: Stephen Finucane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephenfin @openshift-ci-robot @EmilienM