Remove dependency on the base64 gem #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
requested review from
VijayanB,
jayeshathila,
robsears,
vamshin,
dblock,
VachaShah,
nhtruong and
harshavamsi
as code owners
dblock
previously approved these changes
Jan 2, 2024
Followup to #218 Signed-off-by: Earlopain <[email protected]>
|
Sure, done! |
nhtruong
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#218 removed a warning in ruby 3.3 because of the base64 dependency. Since it's just a wrapper around the pack/unpack methods it's trivial to replace.
base64gem from runtime dependency rubocop/rubocop#12313By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.