Remove runtime dependency on base64 #618
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 3.3 prints a warning if base64 is used without specifying it in the gemfile. Ruby 3.4 will error.
Since it's just a wrapper around the pack/unpack methods it's trivial to replace.
You don't see this in CI since the Gemfile contains dependencies that in turn already depend on
base64
, likeactivesupport
.Here is some similar work:
base64
gem from runtime dependency rubocop/rubocop#12313