-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bundle] include default files #758
Conversation
Create the bundles with default files for OpenSearch and OpenSearch Dashboards. These files include: * opensearch-tar-install.sh * config/opensearch_dashboards.yml Issue resolved: opensearch-project#610 Signed-off-by: Kawika Avilla <[email protected]>
bd553e5
to
d85e76f
Compare
Codecov Report
@@ Coverage Diff @@
## main #758 +/- ##
==========================================
+ Coverage 91.21% 91.28% +0.07%
==========================================
Files 75 75
Lines 1992 2009 +17
==========================================
+ Hits 1817 1834 +17
Misses 175 175
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to replace a hard-coded copy by another hard-coded copy, so I think we're on the wrong track.
During the assemble phase we iterate through all plugins and install them. Part of that we run a post-install script which can do things like copying additional files, e.g. k-nn/install.sh. Add an install step for the min artifact, and copy the custom .sh script for OpenSearch and the custom dashboards_config.yml in install.sh that will live under scripts/.../OpenSearch
and scripts/.../OpenSearch-Dashboards
. Then this entire code can be deleted.
source, | ||
) | ||
) | ||
if not os.path.isfile(file): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can't exit in the middle of code. The next call to shutil.copy2
will fail with an exception as needed.
Description
Create the bundles with default files for OpenSearch and OpenSearch
Dashboards.
These files include:
However, we do not want to include opensearch-tar-install.sh into
the OpenSearch Dashboards bundle because the script will just fail
to run.
Signed-off-by: Kawika Avilla [email protected]
Issues Resolved
#610
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.