[Bundle] post-install for min applications #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavilla
requested review from
dblock,
peternied,
peterzhuamazon and
Tengda-He
kavilla
commented
Oct 19, 2021
kavilla
force-pushed
the
avillk/install_core
branch
2 times, most recently
from
7e81e24
to
c2248a8
Compare
dblock
approved these changes
Oct 19, 2021
| @@ -39,6 +39,12 @@ def __init__(self, build_manifest, artifacts_dir, bundle_recorder): | |||
| self.min_tarball_path = self._copy_component(self.min_tarball, "dist") | |||
| self.__unpack_min_tarball(self.tmp_dir.name) | |||
|
|
|||
| def install_core(self): | |||
| post_install_script = ScriptFinder.find_install_script(self.min_tarball.name) | |||
There was a problem hiding this comment.
To be fair, it's the install_script or just script
kavilla
force-pushed
the
avillk/install_core
branch
from
c2248a8
to
503dc3c
Compare
Adding install script for OpenSearch and OpenSearch Dashboards so the bundles include default files. These files include: * opensearch-tar-install.sh * config/opensearch_dashboards.yml However, we did not want to include opensearch-tar-install.sh into the OpenSearch Dashboards bundle because the script will fail to execute as it is only expected to be an OpenSearch project. Issue resolved: opensearch-project#610 Signed-off-by: Kawika Avilla <[email protected]>
kavilla
force-pushed
the
avillk/install_core
branch
from
503dc3c
to
90e8e4a
Compare
kavilla
changed the title
peternied
reviewed
Oct 19, 2021
| @@ -0,0 +1,45 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
I would really prefer that this is python classes rather than shell scripts, its more testable and supports reuse
There was a problem hiding this comment.
IMO, it would need to be declarative then, not a custom class that copies a hard-coded .sh script.
There was a problem hiding this comment.
Let's unblock this PR though? It's better than what we have IMO.
dblock
approved these changes
Oct 19, 2021
peternied
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding install script for OpenSearch and OpenSearch Dashboards so
the bundles include default files.
These files include:
However, we did not want to include opensearch-tar-install.sh into
the OpenSearch Dashboards bundle because the script will fail to
execute as it is only expected to be an OpenSearch project.
Previous PR:
#758
Signed-off-by: Kawika Avilla [email protected]
Issues Resolved
#610
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.