-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bundle] post-install for min applications #762
[Bundle] post-install for min applications #762
Conversation
7e81e24
to
c2248a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits mostly, otherwise looks good.
@@ -39,6 +39,12 @@ def __init__(self, build_manifest, artifacts_dir, bundle_recorder): | |||
self.min_tarball_path = self._copy_component(self.min_tarball, "dist") | |||
self.__unpack_min_tarball(self.tmp_dir.name) | |||
|
|||
def install_core(self): | |||
post_install_script = ScriptFinder.find_install_script(self.min_tarball.name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be fair, it's the install_script
or just script
c2248a8
to
503dc3c
Compare
Adding install script for OpenSearch and OpenSearch Dashboards so the bundles include default files. These files include: * opensearch-tar-install.sh * config/opensearch_dashboards.yml However, we did not want to include opensearch-tar-install.sh into the OpenSearch Dashboards bundle because the script will fail to execute as it is only expected to be an OpenSearch project. Issue resolved: opensearch-project#610 Signed-off-by: Kawika Avilla <[email protected]>
503dc3c
to
90e8e4a
Compare
@@ -0,0 +1,45 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would really prefer that this is python classes rather than shell scripts, its more testable and supports reuse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, it would need to be declarative then, not a custom class that copies a hard-coded .sh script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's unblock this PR though? It's better than what we have IMO.
Description
Adding install script for OpenSearch and OpenSearch Dashboards so
the bundles include default files.
These files include:
However, we did not want to include opensearch-tar-install.sh into
the OpenSearch Dashboards bundle because the script will fail to
execute as it is only expected to be an OpenSearch project.
Previous PR:
#758
Signed-off-by: Kawika Avilla [email protected]
Issues Resolved
#610
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.