fix: Update getting started cards content and visual design #2209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viraj Sanghvi <[email protected]>
|
There are a lot of errors/failing checks, but I don't think they're related and these fail in other PRs. If I'm doing something to trigger any of these, please let me know. |
6 tasks
mengweieric
approved these changes
Oct 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
Signed-off-by: Viraj Sanghvi <[email protected]> (cherry picked from commit 4b5b364) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mengweieric
pushed a commit
to mengweieric/dashboards-observability
that referenced
this pull request
Oct 18, 2024
…ch-project#2209) Signed-off-by: Viraj Sanghvi <[email protected]>
TackAdam
pushed a commit
that referenced
this pull request
Oct 18, 2024
…2212) (cherry picked from commit 4b5b364) Signed-off-by: Viraj Sanghvi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
RyanL1997
pushed a commit
that referenced
this pull request
Oct 18, 2024
…pping issue (#2211) * updated release notes (#1997) Signed-off-by: sumukhswamy <[email protected]> * xaxis label default to rotate 45 angle Signed-off-by: Eric <[email protected]> * update snapshots Signed-off-by: Eric <[email protected]> * fix: Update getting started cards content and visual design (#2209) Signed-off-by: Viraj Sanghvi <[email protected]> * updated release notes (#1997) Signed-off-by: sumukhswamy <[email protected]> * updated release notes (#1997) Signed-off-by: sumukhswamy <[email protected]> * update other snapshots Signed-off-by: Eric <[email protected]> --------- Signed-off-by: sumukhswamy <[email protected]> Signed-off-by: Eric <[email protected]> Signed-off-by: Viraj Sanghvi <[email protected]> Co-authored-by: Sumukh Swamy <[email protected]> Co-authored-by: Viraj Sanghvi <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
…pping issue (#2211) * updated release notes (#1997) Signed-off-by: sumukhswamy <[email protected]> * xaxis label default to rotate 45 angle Signed-off-by: Eric <[email protected]> * update snapshots Signed-off-by: Eric <[email protected]> * fix: Update getting started cards content and visual design (#2209) Signed-off-by: Viraj Sanghvi <[email protected]> * updated release notes (#1997) Signed-off-by: sumukhswamy <[email protected]> * updated release notes (#1997) Signed-off-by: sumukhswamy <[email protected]> * update other snapshots Signed-off-by: Eric <[email protected]> --------- Signed-off-by: sumukhswamy <[email protected]> Signed-off-by: Eric <[email protected]> Signed-off-by: Viraj Sanghvi <[email protected]> Co-authored-by: Sumukh Swamy <[email protected]> Co-authored-by: Viraj Sanghvi <[email protected]> (cherry picked from commit d5853bc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
TackAdam
pushed a commit
that referenced
this pull request
Oct 18, 2024
…pping issue (#2211) (#2215) * updated release notes (#1997) * xaxis label default to rotate 45 angle * update snapshots * fix: Update getting started cards content and visual design (#2209) * updated release notes (#1997) * updated release notes (#1997) * update other snapshots --------- (cherry picked from commit d5853bc) Signed-off-by: sumukhswamy <[email protected]> Signed-off-by: Eric <[email protected]> Signed-off-by: Viraj Sanghvi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sumukh Swamy <[email protected]> Co-authored-by: Viraj Sanghvi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates getting started cards for observability overview page to new content and visual design.
Please do review, but don't merge yet as it requires an oui bump in osd (should land tomorrow afternoon) and opensearch-project/OpenSearch-Dashboards#8614 to be completed. Also, please make sure this gets backported to 2.x.
New cards:
This functionality is not currently tested so I did not add tests. Please let me know if there's a changelog mechanism I should know about.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.