Observability Overview page rework #2210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
|
New cards working with dismiss |
Signed-off-by: Adam Tackett <[email protected]>
TackAdam
changed the title
RyanL1997
approved these changes
Oct 18, 2024
| /> | ||
| } | ||
| title="Add a dashboard" | ||
| description="Customize the overview page by adding a dashboard." |
There was a problem hiding this comment.
we can add i18n as a follow-up
| } | ||
| }) | ||
| .catch((error) => { | ||
| console.error('Error fetching dashboards:', error); |
There was a problem hiding this comment.
should this be a console error? I know in before we seems to have some console errors on these fetch failures. I think it is okay to leave it here for now, but maybe we can have some better error handling as a follow up.
There was a problem hiding this comment.
Will look into, thanks for the call out.
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
vamsi-amazon
approved these changes
Oct 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
* rework the obs overview page adding dismiss to cards, and changing ui Signed-off-by: Adam Tackett <[email protected]> * hide new setting for showCards based on workspace Signed-off-by: Adam Tackett <[email protected]> * small integrations ui adjustment Signed-off-by: Adam Tackett <[email protected]> * Update snapshots Signed-off-by: Adam Tackett <[email protected]> * fix lint Signed-off-by: Adam Tackett <[email protected]> * capitalize Page Signed-off-by: Adam Tackett <[email protected]> --------- Signed-off-by: Adam Tackett <[email protected]> Signed-off-by: Adam Tackett <[email protected]> Co-authored-by: Adam Tackett <[email protected]> (cherry picked from commit 90a2baf) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
TackAdam
added a commit
that referenced
this pull request
Oct 18, 2024
* rework the obs overview page adding dismiss to cards, and changing ui * hide new setting for showCards based on workspace * small integrations ui adjustment * Update snapshots * fix lint * capitalize Page --------- (cherry picked from commit 90a2baf) Signed-off-by: Adam Tackett <[email protected]> Signed-off-by: Adam Tackett <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Tackett <[email protected]> Co-authored-by: Adam Tackett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disable cards functionality:
DismissibleCards.mov
Update to integrations table
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.