Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remote Store] Removing asserts based on translog stats as it is not applicable for … #9878

Merged
merged 1 commit into from
Sep 7, 2023
Merged

[Remote Store] Removing asserts based on translog stats as it is not applicable for … #9878

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions server/src/test/java/org/opensearch/index/shard/RemoteIndexShardTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,22 +81,18 @@ protected ReplicationGroup getReplicationGroup(int numberOfReplicas) throws IOEx
return createGroup(numberOfReplicas, settings, indexMapping, new NRTReplicationEngineFactory(), createTempDir());
}

@AwaitsFix(bugUrl = "https://github.com/opensearch-project/OpenSearch/issues/9624")
public void testNRTReplicaWithRemoteStorePromotedAsPrimaryRefreshRefresh() throws Exception {
testNRTReplicaWithRemoteStorePromotedAsPrimary(false, false);
}

@AwaitsFix(bugUrl = "https://github.com/opensearch-project/OpenSearch/issues/9624")
public void testNRTReplicaWithRemoteStorePromotedAsPrimaryRefreshCommit() throws Exception {
testNRTReplicaWithRemoteStorePromotedAsPrimary(false, true);
}

@AwaitsFix(bugUrl = "https://github.com/opensearch-project/OpenSearch/issues/9624")
public void testNRTReplicaWithRemoteStorePromotedAsPrimaryCommitRefresh() throws Exception {
testNRTReplicaWithRemoteStorePromotedAsPrimary(true, false);
}

@AwaitsFix(bugUrl = "https://github.com/opensearch-project/OpenSearch/issues/9624")
public void testNRTReplicaWithRemoteStorePromotedAsPrimaryCommitCommit() throws Exception {
testNRTReplicaWithRemoteStorePromotedAsPrimary(true, true);
}
Expand Down Expand Up @@ -156,10 +152,6 @@ public void testNRTReplicaWithRemoteStorePromotedAsPrimary(boolean performFlushF
assertEquals(InternalEngine.class, nextPrimary.getEngine().getClass());
assertDocCounts(nextPrimary, totalDocs, totalDocs);

// As we are downloading segments from remote segment store on failover, there should not be
// any operations replayed from translog
assertEquals(prevOperationCount, nextPrimary.translogStats().estimatedNumberOfOperations());

// refresh and push segments to our other replica.
nextPrimary.refresh("test");

Expand Down
Loading