Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remote Store] Removing asserts based on translog stats as it is not applicable for … #9878

Merged
merged 1 commit into from
Sep 7, 2023
Merged

[Remote Store] Removing asserts based on translog stats as it is not applicable for … #9878

merged 1 commit into from
Sep 7, 2023

Conversation

gbbafna
Copy link
Collaborator

@gbbafna gbbafna commented Sep 7, 2023 •
edited
Loading

…remote store

Description

[Describe what this change achieves]

Related Issues

Resolves #9624

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@gbbafna gbbafna marked this pull request as ready for review September 7, 2023 11:29
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Compatibility status:

Checks if related components are compatible with change ff06355

Incompatible components

Incompatible components: [https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/neural-search.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

@gbbafna
Copy link
Collaborator Author

gbbafna commented Sep 7, 2023 

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':distribution:bwc:minor:buildBwcLinuxTar'.
> Building 2.10.0 didn't generate expected file /var/jenkins/workspace/gradle-check/search/distribution/bwc/minor/build/bwc/checkout-2.x/distribution/archives/linux-tar/build/distributions/opensearch-min-2.10.0-SNAPSHOT-linux-x64.tar.gz

All the tests passed .

@sachinpkale sachinpkale merged commit 7760074 into opensearch-project:main Sep 7, 2023
11 of 40 checks passed
@sachinpkale sachinpkale added backport 2.x Backport to 2.x branch backport 2.10 Backport to 2.10 branch labels Sep 7, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 7, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 7, 2023
@github-actions
Removing asserts based on translog stats as it is not applicable for …
b938b45 
…remote store (#9878)

Signed-off-by: Gaurav Bafna <[email protected]>
(cherry picked from commit 7760074)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 7, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 7, 2023
@github-actions
Removing asserts based on translog stats as it is not applicable for …
787b4af 
…remote store (#9878)

Signed-off-by: Gaurav Bafna <[email protected]>
(cherry picked from commit 7760074)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@gbbafna gbbafna deleted the remote-ut-fix branch September 7, 2023 13:03
gbbafna pushed a commit that referenced this pull request Sep 7, 2023
@opensearch-trigger-bot @github-actions
Removing asserts based on translog stats as it is not applicable for …
fef6839 
…remote store (#9878) (#9883)

(cherry picked from commit 7760074)

Signed-off-by: Gaurav Bafna <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna pushed a commit that referenced this pull request Sep 7, 2023
@opensearch-trigger-bot @github-actions
Removing asserts based on translog stats as it is not applicable for …
d6a4de7 
…remote store (#9878) (#9882)

(cherry picked from commit 7760074)

Signed-off-by: Gaurav Bafna <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
@gbbafna @kaushalmahi12
Removing asserts based on translog stats as it is not applicable for …
d2e481b 
…remote store (opensearch-project#9878)

Signed-off-by: Gaurav Bafna <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
sarthakaggarwal97 pushed a commit to sarthakaggarwal97/OpenSearch that referenced this pull request Sep 20, 2023
@gbbafna @sarthakaggarwal97
Removing asserts based on translog stats as it is not applicable for …
8ea0e60 
…remote store (opensearch-project#9878)

Signed-off-by: Gaurav Bafna <[email protected]>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
@gbbafna @brusic
Removing asserts based on translog stats as it is not applicable for …
7af90fe 
…remote store (opensearch-project#9878)

Signed-off-by: Gaurav Bafna <[email protected]>
Signed-off-by: Ivan Brusic <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@gbbafna @shiv0408
Removing asserts based on translog stats as it is not applicable for …
3e21ce9 
…remote store (opensearch-project#9878)

Signed-off-by: Gaurav Bafna <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachinpkale sachinpkale sachinpkale approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch backport 2.10 Backport to 2.10 branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] flaky test faiure - testNRTReplicaWithRemoteStorePromotedAsPrimaryRefreshRefresh
2 participants
@gbbafna @sachinpkale