Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The last "Authorise" button on the onboarding now working #5723

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Oct 21, 2024

Hi everyone!

The "Authorise" button in the Consent screen (on the onboarding) was visually broken.
Actually, the build method of the "real" Homepage was called… but never displayed.

The main issue is that the onboarding is mixing Navigator v1 and v2 calls.
Thus, the onboarding is considered as the "/" route, which is the same as the "real" homepage.

The trick is to have a difference between the two screens + manually clear the stack.

@g123k g123k linked an issue Oct 21, 2024 that may be closed by this pull request
@github-actions github-actions bot added 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… router labels Oct 21, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 6.94%. Comparing base (4d9c7fc) to head (f64852a).
Report is 379 commits behind head on develop.

Files with missing lines Patch % Lines
...ib/pages/onboarding/onboarding_flow_navigator.dart 0.00% 8 Missing ⚠️
.../smooth_app/lib/pages/navigator/app_navigator.dart 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5723      +/-   ##
==========================================
- Coverage     9.54%   6.94%   -2.60%     
==========================================
  Files          325     404      +79     
  Lines        16411   21615    +5204     
==========================================
- Hits          1567    1502      -65     
- Misses       14844   20113    +5269     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon merged commit a4b3632 into openfoodfacts:develop Oct 21, 2024
6 checks passed
g123k added a commit to g123k/smooth-app that referenced this pull request Oct 21, 2024
g123k added a commit that referenced this pull request Oct 21, 2024
@g123k g123k deleted the unlocked_onboarding branch November 7, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… router
Development

Successfully merging this pull request may close these issues.

App blocked during onboarding after the "stats" page
4 participants