Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App blocked during onboarding after the "stats" page #5710

Closed
monsieurtanuki opened this issue Oct 18, 2024 · 2 comments · Fixed by #5723
Closed

App blocked during onboarding after the "stats" page #5710

monsieurtanuki opened this issue Oct 18, 2024 · 2 comments · Fixed by #5723
Assignees
Labels
🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…

Comments

@monsieurtanuki
Copy link
Contributor

What

  • During the onboarding, we go from page to page.
  • The last onboarding page is the "stats" page.
  • In that page there are 2 buttons: "refuse" and "authorize".
  • Whatever we select we stay on the same page. We're stuck.
  • If you want to really go to the home page, you have to kill the app then restart it.

Steps to reproduce the behavior

  1. Start the app from scratch after install, or "restart the onboarding experience" (cf. DEV mode)
  2. When you land on the "stats" page, you cannot go further with the "refuse" and/or "authorize" buttons
  3. Kill the app
  4. Restart the app and you land on the home page (barcode scan)

Expected behavior

We shouldn't have to kill the app to start it. Should we?

Why

That's detrimental to the UX, I guess.

Screenshot/Mockup/Before-After

Image

Smartphone model

  • Android Emulator and Samsung A14
  • Android 34 or 35
  • App Version: latest
@teolemon teolemon added the 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… label Oct 18, 2024
@g123k
Copy link
Collaborator

g123k commented Oct 21, 2024

I was able to reproduce it and the fix is not that trivial, as GoRouter seems to ignore to open the new page

@g123k g123k self-assigned this Oct 21, 2024
@monsieurtanuki
Copy link
Contributor Author

@g123k Hopefully it did work at one point in the past, even with GoRouter. Good luck!

@g123k g123k linked a pull request Oct 21, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from 💬 To discuss and validate to 🎊 Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…
Development

Successfully merging a pull request may close this issue.

3 participants