Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: If a "panel summary widget" is incomplete, the app shouldn't crash #4987

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jan 15, 2024

Hi everyone,

This is a fix for #4948, but I won't link to the issue, as I'm not fully sure if it answers correctly the problem for the final user.
But basically this PR ensures the product page won't crash when there is no titleElement.
I have also improved a bit the code to only use a Column when there is at least 2 children.

@g123k g123k self-assigned this Jan 15, 2024
@g123k g123k requested a review from a team as a code owner January 15, 2024 08:59
@codecov-commenter
Copy link

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (014557e) 9.61% compared to head (5fee0b8) 9.61%.

Files Patch % Lines
...s/smooth_app/lib/helpers/product_cards_helper.dart 0.00% 4 Missing ⚠️
...e_panel/knowledge_panels/knowledge_panel_card.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #4987   +/-   ##
=======================================
  Coverage     9.61%   9.61%           
=======================================
  Files          323     323           
  Lines        16279   16279           
=======================================
  Hits          1565    1565           
  Misses       14714   14714           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon merged commit 735ae8c into openfoodfacts:develop Jan 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants