fix: If a "panel summary widget" is incomplete, the app shouldn't cra…

…sh (#4987) * In the case where a "panel summary widget" is null, we have to pass a non-null WIdget * Add a missing `const`
openfoodfacts · Jan 15, 2024 · 735ae8c · 735ae8c
1 parent d1188c9
commit 735ae8c
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 11 deletions.
diff --git a/packages/smooth_app/lib/helpers/product_cards_helper.dart b/packages/smooth_app/lib/helpers/product_cards_helper.dart
@@ -97,13 +97,16 @@ Widget buildProductSmoothCard({
     SmoothCard(
       margin: margin,
       padding: padding,
-      child: Column(
-        mainAxisSize: MainAxisSize.min,
-        children: <Widget>[
-          if (header != null) header,
-          body,
-        ],
-      ),
+      child: switch (header) {
+        Object _ => Column(
+            mainAxisSize: MainAxisSize.min,
+            children: <Widget>[
+              if (header != null) header,
+              body,
+            ],
+          ),
+        _ => body
+      },
     );
 
 // used to be in now defunct `AttributeListExpandable`

diff --git a/packages/smooth_app/lib/knowledge_panel/knowledge_panels/knowledge_panel_card.dart b/packages/smooth_app/lib/knowledge_panel/knowledge_panels/knowledge_panel_card.dart
@@ -63,10 +63,11 @@ class KnowledgePanelCard extends StatelessWidget {
                   ),
                 ),
         child: KnowledgePanelsBuilder.getPanelSummaryWidget(
-          panel,
-          isClickable: isClickable,
-          margin: EdgeInsets.zero,
-        ),
+              panel,
+              isClickable: isClickable,
+              margin: EdgeInsets.zero,
+            ) ??
+            const SizedBox(),
       ),
     );
   }