-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 4947 - added local "last access" timestamp for products #4969
Merged
monsieurtanuki
merged 3 commits into
openfoodfacts:develop
from
monsieurtanuki:feat_2/4947
Jan 25, 2024
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
40 changes: 40 additions & 0 deletions
40
packages/smooth_app/lib/database/dao_product_last_access.dart
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
import 'dart:async'; | ||
import 'package:smooth_app/database/abstract_sql_dao.dart'; | ||
import 'package:smooth_app/database/local_database.dart'; | ||
import 'package:sqflite/sqflite.dart'; | ||
|
||
/// Table that stores the local last access timestamp for a product. | ||
class DaoProductLastAccess extends AbstractSqlDao { | ||
DaoProductLastAccess(super.localDatabase); | ||
|
||
static const String TABLE = 'product_last_access'; | ||
static const String COLUMN_BARCODE = 'barcode'; | ||
static const String COLUMN_LAST_ACCESS = 'last_access'; | ||
|
||
static FutureOr<void> onUpgrade( | ||
final Database db, | ||
final int oldVersion, | ||
final int newVersion, | ||
) async { | ||
if (oldVersion < 5) { | ||
await db.execute('create table $TABLE(' | ||
// cf. https://www.sqlite.org/lang_conflict.html | ||
'$COLUMN_BARCODE TEXT PRIMARY KEY on conflict replace' | ||
',$COLUMN_LAST_ACCESS INT NOT NULL' | ||
')'); | ||
} | ||
} | ||
|
||
Future<void> put(final String barcode) async => | ||
localDatabase.database.rawInsert( | ||
'insert into $TABLE($COLUMN_BARCODE, $COLUMN_LAST_ACCESS) ' | ||
'values(?, ?)', | ||
<Object>[ | ||
barcode, | ||
LocalDatabase.nowInMillis(), | ||
], | ||
); | ||
|
||
/// Delete all items from the database | ||
Future<int> deleteAll() async => localDatabase.database.delete(TABLE); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name "LastAccess" could be confusing, we should clarify somewhere that its the last server access, not last local access to the product