-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 4947 - added local "last access" timestamp for products #4969
feat: 4947 - added local "last access" timestamp for products #4969
Conversation
New file: * `dao_product_last_access.dart`: Table that stores the local last access timestamp for a product. Impacted files: * `local_database.dart`: new version of the database, because of the new "product last access" table * `new_product_page.dart`: added a call to refresh the product "last access" timestamp * `offline_data_page.dart`: added a call to delete the product "last access" timestamps * `product_model.dart`: added a call to refresh the product "last access" timestamp * `pubspec.lock`: wtf
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #4969 +/- ##
==========================================
- Coverage 9.62% 9.61% -0.01%
==========================================
Files 323 324 +1
Lines 16267 16282 +15
==========================================
Hits 1565 1565
- Misses 14702 14717 +15 ☔ View full report in Codecov by Sentry. |
@M123-dev @g123k @AshAman999 could you have a look ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small naming thing, besides that good idea 👍🏼
class DaoProductLastAccess extends AbstractSqlDao { | ||
DaoProductLastAccess(super.localDatabase); | ||
|
||
static const String TABLE = 'product_last_access'; | ||
static const String COLUMN_BARCODE = 'barcode'; | ||
static const String COLUMN_LAST_ACCESS = 'last_access'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name "LastAccess" could be confusing, we should clarify somewhere that its the last server access, not last local access to the product
Thank you @M123-dev for your review!
/// Table that stores the local last access timestamp for a product.
class DaoProductLastAccess extends AbstractSqlDao {
// ...
static const String COLUMN_LAST_ACCESS = 'last_access'; I did specify it's the "local last access timestamp for a product". Now that the table is created, if someone finds a better naming for the class ( |
What
Part of
Files
New file:
dao_product_last_access.dart
: Table that stores the local last access timestamp for a product.Impacted files:
local_database.dart
: new version of the database, because of the new "product last access" tablenew_product_page.dart
: added a call to refresh the product "last access" timestampoffline_data_page.dart
: added a call to delete the product "last access" timestampsproduct_model.dart
: added a call to refresh the product "last access" timestamppubspec.lock
: wtf