Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Create internal release on every commit #2983

Merged
merged 4 commits into from
Sep 22, 2022

Conversation

M123-dev
Copy link
Member

@M123-dev M123-dev commented Sep 9, 2022

What

@teolemon

  • now we create a new internal build to org.openfoodfacts.scanner on every commit, later to be changed to the new internal listing.
  • One problem occurs while doing it like that. in the store consoles we have no way to differentiate between builds intended for internal or release candidates.
  • My suggestion would be to push versions published by release-please to the beta branch and only promote those ones.
  • Edit: This would allow to quickly see the latest changes without creating a new GitHub release (and new release name) nearly every day

Part of

@M123-dev M123-dev requested a review from a team as a code owner September 9, 2022 13:57
@github-actions github-actions bot added Android GitHub 🍎 iOS iOS specific issues or PRs labels Sep 9, 2022
@AshAman999
Copy link
Member

Not an expert, but I guess it's too much, even for alpha or internal a new release on every merged pr is too much.
If we could do one in a week or a day.
Comments ?

@monsieurtanuki
Copy link
Contributor

The question asked here is: how much can we delegate to automatic processes?

If the idea is: "we want a full release process after each merged PR", that makes sense if you want a systematic automatic check of all the boring tiny details about a release.

But doing so we lose track (and interest) about the releases.

I prefer the semi-automatic release process as in off-dart: it's automatic because all the PR are included and all the release process is automatic (which is great), but WE decide when to trigger a release, that can be labeled "offline tasks + vertical buttons + new crop tool" (and not just "btw some random developer merged a PR 10 minutes ago").

@teolemon
Copy link
Member

@monsieurtanuki It's not a real release, it's internal to ensure we can test continuously.
Promotion to beta and stable are still manual, conscious decisions

@M123-dev
Copy link
Member Author

The plan is to eventually have two playstore listings:

  1. The main listing
  2. A secondary listing only with the internal lane for us devs to test so that we can have two versions on our phone at the same time.

I only added this change before creating a second listing as I noticed that we have a LOT of release please releases lately. This isn't a problem but I think it's overkill to have the release PR merged + a github release + a new release PR sometimes twice a day

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2022

Codecov Report

Merging #2983 (d3bce79) into develop (396822b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #2983   +/-   ##
=======================================
  Coverage     6.49%   6.49%           
=======================================
  Files          246     246           
  Lines        12132   12132           
=======================================
  Hits           788     788           
  Misses       11344   11344           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@teolemon teolemon merged commit 1a0776a into develop Sep 22, 2022
@teolemon teolemon deleted the create-internal-release-on-every-commit branch September 22, 2022 16:25
@VaiTon
Copy link
Member

VaiTon commented Oct 3, 2022

@M123-dev Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android GitHub 🍎 iOS iOS specific issues or PRs
Development

Successfully merging this pull request may close these issues.

6 participants