Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Google Play deploy to internal #2286

Closed
wants to merge 165 commits into from

Conversation

VaiTon
Copy link
Member

@VaiTon VaiTon commented Jun 15, 2022

Deploy to internal track on Google Play every night at 00:00 UTC or on manual trigger.

Also renamed closed_beta in fastfile to internal to better reflect where the deployment is made.

Related to

teolemon and others added 2 commits June 14, 2022 08:29
Deploy to internal track on Google Play every night at 00:00 UTC or on manual trigger.

Also renamed closed_beta in fastfile to internal to better reflect where the deployment is made.
@VaiTon VaiTon requested a review from a team as a code owner June 15, 2022 14:09
@M123-dev M123-dev requested a review from teolemon June 15, 2022 14:15
@g123k
Copy link
Collaborator

g123k commented Jun 19, 2022

I wonder what's the best deployment scenario.
My personal preference is to have two apps: Smoothie (for tests) and OFF (stable).

@VaiTon Do your changes still allow this mechanism?

@teolemon teolemon added this to the V1.1 milestone Jun 20, 2022
@VaiTon
Copy link
Member Author

VaiTon commented Jun 20, 2022

Hey @g123k !

My personal preference is to have two apps: Smoothie (for tests) and OFF (stable).

If you're on the internal branch team the app would update every night, so no two versions. But I wonder if that is possible with the current configuration. How do you manage to do it?

@teolemon teolemon changed the base branch from release/3.4.4 to develop June 25, 2022 07:31
@teolemon teolemon changed the base branch from develop to release/3.4.4 June 25, 2022 07:31
@teolemon teolemon changed the base branch from release/3.4.4 to develop June 25, 2022 07:32
@teolemon teolemon changed the base branch from develop to release/3.4.4 June 25, 2022 07:32
@teolemon
Copy link
Member

teolemon commented Aug 2, 2022

Run flutter analyze --fatal-infos --fatal-warnings .
Analyzing smooth-app...

error • The body might complete normally, causing 'null' to be returned, but the return type, 'Widget', is a potentially non-nullable type • packages/smooth_app/lib/knowledge_panel/knowledge_panels/knowledge_panel_element_card.dart:24:10 • body_might_complete_normally
warning • Missing case clause for 'ACTION' • packages/smooth_app/lib/knowledge_panel/knowledge_panels/knowledge_panel_element_card.dart:25:5 • missing_enum_constant_in_switch

2 issues found. (ran in 29.0s)
Error: Process completed with exit code 1.

@teolemon teolemon changed the base branch from release/3.4.4 to release/3.5.2 August 2, 2022 13:31
@M123-dev
Copy link
Member

M123-dev commented Oct 3, 2022

Fixed by #2983

@M123-dev M123-dev closed this Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants