-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: make data dir configurable #4
Changes from all commits
3e012e3
c4defb8
1202b80
6efd9ae
ab6c6a3
9a7df8b
c25849b
d435bcc
0023ef3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -51,7 +51,7 @@ spec: | |
type: DirectoryOrCreate | ||
- name: data-dir | ||
hostPath: | ||
path: /var/csi/rawfile | ||
path: {{ .Values.node.rawfile_dir }} | ||
type: DirectoryOrCreate | ||
containers: | ||
- name: csi-driver | ||
|
@@ -66,6 +66,8 @@ spec: | |
value: unix:///csi/csi.sock | ||
- name: IMAGE_REPOSITORY | ||
value: "{{ .Values.node.image.repository }}" | ||
- name: DATA_DIR | ||
value: "{{ .Values.node.data_dir }}" | ||
{{- if regexMatch "^.*-ci$" .Values.node.image.tag }} | ||
- name: IMAGE_TAG | ||
value: "{{ .Values.node.image.tag }}" | ||
|
@@ -85,7 +87,7 @@ spec: | |
mountPath: /var/lib/kubelet | ||
mountPropagation: "Bidirectional" | ||
- name: data-dir | ||
mountPath: /data | ||
mountPath: {{ .Values.node.data_dir }} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ditto |
||
resources: | ||
{{- toYaml .Values.node.resources | nindent 12 }} | ||
- name: node-driver-registrar | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,10 @@ defaults: &defaults | |
requests: | ||
cpu: 10m | ||
memory: 100Mi | ||
rawfile_dir: /var/csi/rawfile | ||
data_dir: /data | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ditto |
||
|
||
|
||
|
||
controller: | ||
<< : *defaults | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,7 @@ spec: | |
volumes: | ||
- name: data-dir | ||
hostPath: | ||
path: /var/csi/rawfile | ||
path: {rawfile_dir} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually, this needs to be passed into the templating function so that it can get rendered. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The values are interpolated not by helm, but the python code. So that's where the code needs to be updated. |
||
type: DirectoryOrCreate | ||
nodeSelector: {nodeSelector} | ||
containers: | ||
|
@@ -20,7 +20,7 @@ spec: | |
imagePullPolicy: IfNotPresent | ||
volumeMounts: | ||
- name: data-dir | ||
mountPath: /data | ||
mountPath: {data_dir} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ditto |
||
resources: | ||
requests: &rsc | ||
cpu: 10m | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "remove data_dir variable" applies to this one too