-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: make data dir configurable #4
Feature: make data dir configurable #4
Conversation
The CI is failing but I don't think it has anything to do with your code... |
I think the CI is failing because there's a problem with the docker build and push stage that needs username and password for dockerhub repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. Will you please fix the comments?
@@ -12,6 +12,10 @@ defaults: &defaults | |||
requests: | |||
cpu: 10m | |||
memory: 100Mi | |||
rawfile_dir: /rawfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change this to /var/csi/rawfile
to keep it backward-compatible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, I will change it later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello, @semekh I've updated this to /var/csi/rawfile
can you please check it again?
thank you
Dockerfile
Outdated
@@ -19,5 +19,7 @@ ENV PYTHONUNBUFFERED 1 | |||
|
|||
ARG IMAGE_TAG | |||
ARG IMAGE_REPOSITORY | |||
ARG DATA_DIR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not make data_dir configurable. This is what the container sees, and does not need to be changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah okay, I'll undo this change
…onfigurable' into feature/make_data-dir_configurable
…onfigurable' into feature/make_data-dir_configurable
…onfigurable' into feature/make_data-dir_configurable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Fix these and it's good to go.
@@ -66,6 +66,8 @@ spec: | |||
value: unix:///csi/csi.sock | |||
- name: IMAGE_REPOSITORY | |||
value: "{{ .Values.node.image.repository }}" | |||
- name: DATA_DIR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "remove data_dir variable" applies to this one too
@@ -85,7 +87,7 @@ spec: | |||
mountPath: /var/lib/kubelet | |||
mountPropagation: "Bidirectional" | |||
- name: data-dir | |||
mountPath: /data | |||
mountPath: {{ .Values.node.data_dir }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
@@ -12,6 +12,10 @@ defaults: &defaults | |||
requests: | |||
cpu: 10m | |||
memory: 100Mi | |||
rawfile_dir: /var/csi/rawfile | |||
data_dir: /data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
@@ -20,7 +20,7 @@ spec: | |||
imagePullPolicy: IfNotPresent | |||
volumeMounts: | |||
- name: data-dir | |||
mountPath: /data | |||
mountPath: {data_dir} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
@@ -11,7 +11,7 @@ spec: | |||
volumes: | |||
- name: data-dir | |||
hostPath: | |||
path: /var/csi/rawfile | |||
path: {rawfile_dir} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, this needs to be passed into the templating function so that it can get rendered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The values are interpolated not by helm, but the python code. So that's where the code needs to be updated.
This is PR for fix this issue #3
What I do:
How to tests:
rawfile_dir
anddata_dir
in the helm values file stored atdeploy/charts/rawfile-csi/values.yaml
Signed-off-by: ronaldyuwandika [email protected]