Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherrypicks from 1.8 #1637

Merged
merged 11 commits into from
Sep 20, 2024

Don't error in dataset add if `product.id` is None (#1630)

f8154ef
Select commit
Loading
Failed to load commit list.
Merged

Cherrypicks from 1.8 #1637

Don't error in dataset add if `product.id` is None (#1630)
f8154ef
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 20, 2024 in 0s

85.25% (target 80.00%)

View this Pull Request on Codecov

85.25% (target 80.00%)

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.25%. Comparing base (d4f84dc) to head (f8154ef).
Report is 4 commits behind head on develop-1.9.

Additional details and impacted files
@@               Coverage Diff               @@
##           develop-1.9    #1637      +/-   ##
===============================================
- Coverage        85.26%   85.25%   -0.02%     
===============================================
  Files              142      144       +2     
  Lines            15605    15692      +87     
===============================================
+ Hits             13306    13378      +72     
- Misses            2299     2314      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.