Cherrypicks from 1.8 #1637
Merged
Cherrypicks from 1.8 #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the warning: FromAsCasing: 'as' and 'FROM' keywords' casing do not match emitted by recent Docker releases.
This fixes the warning: LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format emitted by recent Docker releases. And while changing this, bring all the ENV lines into a single layer, which saves some space in the resulting image.
This will cause Dependabot to make pull requests for the Dockerfile when there are new releases of GDAL.
This is part of the documentation for the action: https://github.com/readthedocs/actions/tree/v1/preview
The documentation at https://github.com/readthedocs/actions/tree/v1/preview uses this. According to https://stackoverflow.com/questions/74957218/what-is-the-difference-between-pull-request-and-pull-request-target-event-in-git there is something with permissions of tokens that differ between pull_request and pull_request_target, so switch to what the action documentation suggests.
Ariana-B
requested changes
Sep 20, 2024
| @@ -1525,19 +1525,19 @@ def temporal_extent_by_prod(self, product_id: int) -> tuple[datetime.datetime, d | |||
| query = self.temporal_extent_full().where(Dataset.product_ref == product_id) | |||
| res = self._connection.execute(query) | |||
| for tmin, tmax in res: | |||
| return (self.time_min.normalise_value(tmin), self.time_max.normalise_value(tmax)) | |||
| return (time_min.normalise_value(tmin), time_max.normalise_value(tmax)) | |||
There was a problem hiding this comment.
Wasn't this change the other way around?
There was a problem hiding this comment.
Yep, totally muffed that merge. Sorry, my mind was elsewhere. This should fix it.
#1629) Bumps [osgeo/gdal](https://github.com/OSGeo/gdal) from ubuntu-full-3.9.0 to ubuntu-full-3.9.2. - [Release notes](https://github.com/OSGeo/gdal/releases) - [Changelog](https://github.com/OSGeo/gdal/blob/master/NEWS.md) - [Commits](OSGeo/gdal@v3.9.0...v3.9.2) --- updated-dependencies: - dependency-name: osgeo/gdal dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* don't assume product.id exists when adding a dataset * don't assume assume product.id exists when adding dataset * update whats_new --------- Co-authored-by: Ariana Barzinpour <[email protected]>
SpacemanPaul
force-pushed
the
cherrypicks_from_1.8
branch
from
44cb452
to
f8154ef
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop-1.9 #1637 +/- ##
===============================================
- Coverage 85.26% 85.25% -0.02%
===============================================
Files 142 144 +2
Lines 15605 15692 +87
===============================================
+ Hits 13306 13378 +72
- Misses 2299 2314 +15 ☔ View full report in Codecov by Sentry. |
Ariana-B
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this pull request
Cherry picks of #1624, #1625, #1626, #1629, #1630, #1631