Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when HTTP_PROXY env contains no auth #1366

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

dmach
Copy link
Contributor

@dmach dmach commented Jul 20, 2023

Fixes: #1363

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (ac23ed0) 28.85% compared to head (eaad34f) 28.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1366      +/-   ##
==========================================
- Coverage   28.85%   28.85%   -0.01%     
==========================================
  Files          45       45              
  Lines       17069    17070       +1     
==========================================
  Hits         4925     4925              
- Misses      12144    12145       +1     
Impacted Files Coverage Δ
osc/_private/project.py 0.00% <0.00%> (ø)
osc/connection.py 53.14% <0.00%> (-0.14%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dirkmueller dirkmueller merged commit b8f6f07 into openSUSE:master Jul 20, 2023
29 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proxy without auth does not work
2 participants