Merge pull request #1366 from dmach/connection-proxy-no-auth

Fix crash when HTTP_PROXY env contains no auth
openSUSE · Jul 20, 2023 · b8f6f07 · b8f6f07
2 parents 6f58d4f + eaad34f
commit b8f6f07
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/osc/connection.py b/osc/connection.py
@@ -107,10 +107,11 @@ def get_proxy_manager(env):
         user_agent=f"osc/{__version__}",
     )
 
-    proxy_basic_auth = urllib.parse.unquote(proxy_purl.auth)
-    proxy_basic_auth = proxy_basic_auth.encode("utf-8")
-    proxy_basic_auth = base64.b64encode(proxy_basic_auth).decode()
-    proxy_headers["Proxy-Authorization"] = f"Basic {proxy_basic_auth:s}"
+    if proxy_purl.auth:
+        proxy_basic_auth = urllib.parse.unquote(proxy_purl.auth)
+        proxy_basic_auth = proxy_basic_auth.encode("utf-8")
+        proxy_basic_auth = base64.b64encode(proxy_basic_auth).decode()
+        proxy_headers["Proxy-Authorization"] = f"Basic {proxy_basic_auth:s}"
 
     manager = urllib3.ProxyManager(proxy_url, proxy_headers=proxy_headers)
     return manager