Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: error while run command against wrong cluser #283

Merged

Conversation

ycyaoxdu
Copy link
Member

prompt warnings while running either hub oriented command against managedcluster or managedcluster oriented command against hub

Signed-off-by: ycyaoxdu [email protected]

@ycyaoxdu
Copy link
Member Author

/assign @qiujian16
PTAL

@ycyaoxdu
Copy link
Member Author

related issue: #133

Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think it should be just a warning, the command will fail, right?

Also could we have a validate func in genericControlPlane to avoid redundant code.

pkg/cmd/create/work/exec.go Outdated Show resolved Hide resolved
pkg/cmd/delete/clusterset/exec.go Outdated Show resolved Hide resolved
@ycyaoxdu ycyaoxdu force-pushed the add-warning branch 3 times, most recently from f0d699b to a2bfe7f Compare October 27, 2022 09:01
@ycyaoxdu ycyaoxdu changed the title Chore: prompt warnings while run command against wrong context Chore: error while run command against wrong cluser & fix: e2e bug Oct 27, 2022
@ycyaoxdu ycyaoxdu changed the title Chore: error while run command against wrong cluser & fix: e2e bug Chore: error while run command against wrong cluser & Fix: e2e bug Oct 27, 2022
go.mod Outdated Show resolved Hide resolved
@ycyaoxdu ycyaoxdu changed the title Chore: error while run command against wrong cluser & Fix: e2e bug Chore: error while run command against wrong cluser Oct 27, 2022
@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 28, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, ycyaoxdu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 75a6a96 into open-cluster-management-io:main Oct 28, 2022
@ycyaoxdu ycyaoxdu deleted the add-warning branch October 28, 2022 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants