-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: error while run command against wrong cluser #283
Chore: error while run command against wrong cluser #283
Conversation
/assign @qiujian16 |
related issue: #133 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think it should be just a warning, the command will fail, right?
Also could we have a validate func in genericControlPlane to avoid redundant code.
f0d699b
to
a2bfe7f
Compare
Signed-off-by: ycyaoxdu <[email protected]>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, ycyaoxdu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
prompt warnings while running either hub oriented command against managedcluster or managedcluster oriented command against hub
Signed-off-by: ycyaoxdu [email protected]