prompt warnings while running either hub oriented command against man…

…agedcluster or managedcluster oriented command against hub

Signed-off-by: ycyaoxdu <[email protected]>

pkg/cmd/accept/exec.go

@@ -7,20 +7,21 @@ import (
 	"strings"
 	"time"
 
+	"github.com/spf13/cobra"
+	certificatesv1 "k8s.io/api/certificates/v1"
 	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/types"
+	utilerrors "k8s.io/apimachinery/pkg/util/errors"
 	"k8s.io/apimachinery/pkg/util/sets"
 	"k8s.io/apimachinery/pkg/util/wait"
 	"k8s.io/client-go/kubernetes"
 	"k8s.io/klog/v2"
-	"open-cluster-management.io/clusteradm/pkg/helpers"
-
-	"github.com/spf13/cobra"
-	certificatesv1 "k8s.io/api/certificates/v1"
-	utilerrors "k8s.io/apimachinery/pkg/util/errors"
 	clusterclientset "open-cluster-management.io/api/client/cluster/clientset/versioned"
+	operatorclient "open-cluster-management.io/api/client/operator/clientset/versioned"
+	"open-cluster-management.io/clusteradm/pkg/helpers"
+	"open-cluster-management.io/clusteradm/pkg/helpers/warning"
 )
 
 const (
@@ -52,6 +53,16 @@ func (o *Options) complete(cmd *cobra.Command, args []string) (err error) {
 }
 
 func (o *Options) Validate() error {
+	config, err := o.ClusteradmFlags.KubectlFactory.ToRESTConfig()
+	if err != nil {
+		return err
+	}
+	client, err := operatorclient.NewForConfig(config)
+	if err != nil {
+		return err
+	}
+	warning.CheckKlusterletAbsent(client)
+
 	return nil
 }
 

pkg/cmd/addon/disable/exec.go

@@ -5,18 +5,19 @@ import (
 	"context"
 	"fmt"
 
-	"k8s.io/apimachinery/pkg/api/errors"
-
 	"github.com/spf13/cobra"
 	apiextensionsclient "k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset"
+	"k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/util/sets"
 	"k8s.io/client-go/dynamic"
 	"k8s.io/client-go/kubernetes"
 	"k8s.io/klog/v2"
 	addonclient "open-cluster-management.io/api/client/addon/clientset/versioned"
 	clusterclientset "open-cluster-management.io/api/client/cluster/clientset/versioned"
+	operatorclient "open-cluster-management.io/api/client/operator/clientset/versioned"
 	"open-cluster-management.io/clusteradm/pkg/helpers"
+	"open-cluster-management.io/clusteradm/pkg/helpers/warning"
 )
 
 func (o *Options) complete(cmd *cobra.Command, args []string) (err error) {
@@ -26,6 +27,16 @@ func (o *Options) complete(cmd *cobra.Command, args []string) (err error) {
 }
 
 func (o *Options) Validate() (err error) {
+	config, err := o.ClusteradmFlags.KubectlFactory.ToRESTConfig()
+	if err != nil {
+		return err
+	}
+	client, err := operatorclient.NewForConfig(config)
+	if err != nil {
+		return err
+	}
+	warning.CheckKlusterletAbsent(client)
+
 	if len(o.Names) == 0 {
 		return fmt.Errorf("names is missing")
 	}
@@ -37,6 +48,7 @@ func (o *Options) Validate() (err error) {
 	if o.Allclusters && len(o.Clusters) != 0 {
 		return fmt.Errorf("flag --all-clusters and --clusters can not be set together")
 	}
+
 	return nil
 }
 

pkg/cmd/addon/enable/exec.go

@@ -7,17 +7,18 @@ import (
 	"strings"
 
 	"github.com/spf13/cobra"
-	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-	"k8s.io/klog/v2"
-
 	"github.com/stolostron/applier/pkg/apply"
 	apiextensionsclient "k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/util/sets"
 	"k8s.io/client-go/dynamic"
 	"k8s.io/client-go/kubernetes"
+	"k8s.io/klog/v2"
 	clusterclientset "open-cluster-management.io/api/client/cluster/clientset/versioned"
+	operatorclient "open-cluster-management.io/api/client/operator/clientset/versioned"
 	"open-cluster-management.io/clusteradm/pkg/cmd/addon/enable/scenario"
 	"open-cluster-management.io/clusteradm/pkg/helpers"
+	"open-cluster-management.io/clusteradm/pkg/helpers/warning"
 )
 
 type ClusterAddonInfo struct {
@@ -53,6 +54,16 @@ func (o *Options) complete(cmd *cobra.Command, args []string) (err error) {
 }
 
 func (o *Options) Validate() error {
+	config, err := o.ClusteradmFlags.KubectlFactory.ToRESTConfig()
+	if err != nil {
+		return err
+	}
+	client, err := operatorclient.NewForConfig(config)
+	if err != nil {
+		return err
+	}
+	warning.CheckKlusterletAbsent(client)
+
 	if len(o.Names) == 0 {
 		return fmt.Errorf("names is missing")
 	}

pkg/cmd/clean/exec.go

@@ -8,11 +8,7 @@ import (
 	"log"
 	"time"
 
-	clustermanagerclient "open-cluster-management.io/api/client/operator/clientset/versioned"
-	"open-cluster-management.io/clusteradm/pkg/helpers"
-
 	"github.com/spf13/cobra"
-
 	apiextensionsclient "k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset"
 	"k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -21,6 +17,8 @@ import (
 	"k8s.io/client-go/kubernetes"
 	"k8s.io/client-go/util/retry"
 	"k8s.io/klog/v2"
+	clustermanagerclient "open-cluster-management.io/api/client/operator/clientset/versioned"
+	"open-cluster-management.io/clusteradm/pkg/helpers"
 )
 
 func (o *Options) complete(cmd *cobra.Command, args []string) (err error) {

pkg/cmd/clusterset/bind/exec.go

@@ -9,7 +9,9 @@ import (
 	"k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	clusterclientset "open-cluster-management.io/api/client/cluster/clientset/versioned"
+	operatorclient "open-cluster-management.io/api/client/operator/clientset/versioned"
 	clusterapiv1beta1 "open-cluster-management.io/api/cluster/v1beta1"
+	"open-cluster-management.io/clusteradm/pkg/helpers/warning"
 )
 
 func (o *Options) complete(cmd *cobra.Command, args []string) (err error) {
@@ -27,9 +29,20 @@ func (o *Options) complete(cmd *cobra.Command, args []string) (err error) {
 }
 
 func (o *Options) Validate() (err error) {
+	config, err := o.ClusteradmFlags.KubectlFactory.ToRESTConfig()
+	if err != nil {
+		return err
+	}
+	client, err := operatorclient.NewForConfig(config)
+	if err != nil {
+		return err
+	}
+	warning.CheckKlusterletAbsent(client)
+
 	if len(o.Namespace) == 0 {
 		return fmt.Errorf("namespace name must be specified in --namespace")
 	}
+
 	return nil
 }
 

pkg/cmd/clusterset/set/exec.go

@@ -8,6 +8,8 @@ import (
 	"github.com/spf13/cobra"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	clusterclientset "open-cluster-management.io/api/client/cluster/clientset/versioned"
+	operatorclient "open-cluster-management.io/api/client/operator/clientset/versioned"
+	"open-cluster-management.io/clusteradm/pkg/helpers/warning"
 )
 
 func (o *Options) complete(cmd *cobra.Command, args []string) (err error) {
@@ -25,9 +27,20 @@ func (o *Options) complete(cmd *cobra.Command, args []string) (err error) {
 }
 
 func (o *Options) Validate() (err error) {
+	config, err := o.ClusteradmFlags.KubectlFactory.ToRESTConfig()
+	if err != nil {
+		return err
+	}
+	client, err := operatorclient.NewForConfig(config)
+	if err != nil {
+		return err
+	}
+	warning.CheckKlusterletAbsent(client)
+
 	if len(o.Clusters) == 0 {
 		return fmt.Errorf("cluster name must be specified in --clusters")
 	}
+
 	return nil
 }
 

pkg/cmd/clusterset/unbind/exec.go

@@ -9,6 +9,8 @@ import (
 	"k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	clusterclientset "open-cluster-management.io/api/client/cluster/clientset/versioned"
+	operatorclient "open-cluster-management.io/api/client/operator/clientset/versioned"
+	"open-cluster-management.io/clusteradm/pkg/helpers/warning"
 )
 
 func (o *Options) complete(cmd *cobra.Command, args []string) (err error) {
@@ -26,9 +28,20 @@ func (o *Options) complete(cmd *cobra.Command, args []string) (err error) {
 }
 
 func (o *Options) Validate() (err error) {
+	config, err := o.ClusteradmFlags.KubectlFactory.ToRESTConfig()
+	if err != nil {
+		return err
+	}
+	client, err := operatorclient.NewForConfig(config)
+	if err != nil {
+		return err
+	}
+	warning.CheckKlusterletAbsent(client)
+
 	if len(o.Namespace) == 0 {
 		return fmt.Errorf("namespace name must be specified in --namespace")
 	}
+
 	return nil
 }
 

pkg/cmd/create/clusterset/exec.go

@@ -8,23 +8,35 @@ import (
 	"github.com/spf13/cobra"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	clusterclientset "open-cluster-management.io/api/client/cluster/clientset/versioned"
+	operatorclient "open-cluster-management.io/api/client/operator/clientset/versioned"
 	clusterapiv1beta1 "open-cluster-management.io/api/cluster/v1beta1"
+	"open-cluster-management.io/clusteradm/pkg/helpers/warning"
 )
 
 func (o *Options) complete(cmd *cobra.Command, args []string) (err error) {
-
 	o.Clustersets = args
 
 	return nil
 }
 
 func (o *Options) Validate() (err error) {
+	config, err := o.ClusteradmFlags.KubectlFactory.ToRESTConfig()
+	if err != nil {
+		return err
+	}
+	client, err := operatorclient.NewForConfig(config)
+	if err != nil {
+		return err
+	}
+	warning.CheckKlusterletAbsent(client)
+
 	if len(o.Clustersets) == 0 {
 		return fmt.Errorf("the name of the clusterset must be specified")
 	}
 	if len(o.Clustersets) > 1 {
 		return fmt.Errorf("only one clusterset can be created")
 	}
+
 	return nil
 }
 

pkg/cmd/create/sampleapp/exec.go

@@ -17,8 +17,10 @@ import (
 	"k8s.io/client-go/dynamic"
 	"k8s.io/client-go/kubernetes"
 	clusterclientset "open-cluster-management.io/api/client/cluster/clientset/versioned"
+	operatorclient "open-cluster-management.io/api/client/operator/clientset/versioned"
 	"open-cluster-management.io/clusteradm/pkg/cmd/create/sampleapp/scenario"
 	"open-cluster-management.io/clusteradm/pkg/helpers"
+	"open-cluster-management.io/clusteradm/pkg/helpers/warning"
 )
 
 const (
@@ -45,6 +47,15 @@ func (o *Options) complete(cmd *cobra.Command, args []string) (err error) {
 }
 
 func (o *Options) Validate() (err error) {
+	config, err := o.ClusteradmFlags.KubectlFactory.ToRESTConfig()
+	if err != nil {
+		return err
+	}
+	client, err := operatorclient.NewForConfig(config)
+	if err != nil {
+		return err
+	}
+	warning.CheckKlusterletAbsent(client)
 
 	return nil
 }

pkg/cmd/create/work/exec.go

@@ -14,9 +14,11 @@ import (
 	"k8s.io/apimachinery/pkg/util/sets"
 	"k8s.io/cli-runtime/pkg/resource"
 	clusterclientset "open-cluster-management.io/api/client/cluster/clientset/versioned"
+	operatorclient "open-cluster-management.io/api/client/operator/clientset/versioned"
 	workclientset "open-cluster-management.io/api/client/work/clientset/versioned"
 	clusterv1beta1 "open-cluster-management.io/api/cluster/v1beta1"
 	workapiv1 "open-cluster-management.io/api/work/v1"
+	"open-cluster-management.io/clusteradm/pkg/helpers/warning"
 )
 
 func (o *Options) complete(cmd *cobra.Command, args []string) (err error) {
@@ -34,6 +36,16 @@ func (o *Options) complete(cmd *cobra.Command, args []string) (err error) {
 }
 
 func (o *Options) validate() (err error) {
+	config, err := o.ClusteradmFlags.KubectlFactory.ToRESTConfig()
+	if err != nil {
+		return err
+	}
+	client, err := operatorclient.NewForConfig(config)
+	if err != nil {
+		return err
+	}
+	warning.CheckKlusterletAbsent(client)
+
 	if len(o.Cluster) == 0 && len(o.Placement) == 0 {
 		return fmt.Errorf("--clusters or --placement must be specified")
 	}
@@ -46,6 +58,7 @@ func (o *Options) validate() (err error) {
 	if len(*o.FileNameFlags.Filenames) == 0 {
 		return fmt.Errorf("manifest files must be specified")
 	}
+
 	return nil
 }
 

pkg/cmd/delete/clusterset/exec.go

@@ -10,7 +10,9 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/watch"
 	clusterclientset "open-cluster-management.io/api/client/cluster/clientset/versioned"
+	operatorclient "open-cluster-management.io/api/client/operator/clientset/versioned"
 	"open-cluster-management.io/clusteradm/pkg/helpers"
+	"open-cluster-management.io/clusteradm/pkg/helpers/warning"
 )
 
 func (o *Options) complete(cmd *cobra.Command, args []string) (err error) {
@@ -21,12 +23,23 @@ func (o *Options) complete(cmd *cobra.Command, args []string) (err error) {
 }
 
 func (o *Options) validate() (err error) {
+	config, err := o.ClusteradmFlags.KubectlFactory.ToRESTConfig()
+	if err != nil {
+		return err
+	}
+	client, err := operatorclient.NewForConfig(config)
+	if err != nil {
+		return err
+	}
+	warning.CheckKlusterletAbsent(client)
+
 	if len(o.Clustersets) == 0 {
 		return fmt.Errorf("the name of the clusterset must be specified")
 	}
 	if len(o.Clustersets) > 1 {
 		return fmt.Errorf("only one clusterset can be deleted")
 	}
+
 	return nil
 }
 

pkg/cmd/delete/token/exec.go

@@ -5,16 +5,13 @@ import (
 	"context"
 	"fmt"
 
+	"github.com/spf13/cobra"
+	apiextensionsclient "k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset"
 	"k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-
+	"k8s.io/client-go/kubernetes"
 	"open-cluster-management.io/clusteradm/pkg/config"
 	"open-cluster-management.io/clusteradm/pkg/helpers"
-
-	"github.com/spf13/cobra"
-
-	apiextensionsclient "k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset"
-	"k8s.io/client-go/kubernetes"
 )
 
 func (o *Options) complete(cmd *cobra.Command, args []string) (err error) {